Add "id" field and logging to DLC-BTC-POR BTC RPC request (#3487)

* Add logging to DLC-BTC-POR

* use logger instead

* could include the request too

* Add id to btc rpcs request, and log only txId

* add changeset

* fixup test

Author: cawthorne

.changeset/little-eyes-reply.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/dlc-btc-por-adapter': minor
+---
+
+Add "id" field to dlc-btc-por btc rpc request

packages/sources/dlc-btc-por/src/transport/proof-of-reserves.ts

@@ -201,6 +201,7 @@ export class DLCBTCPorTransport extends SubscriptionTransport<TransportTypes> {
       baseURL: this.settings.BITCOIN_RPC_URL,
       method: 'POST',
       data: {
+        id: 'dlc-btc-por-ea',
         jsonrpc: '2.0',
         method: 'getrawtransaction',
         params: [txId, true, null],
@@ -210,7 +211,15 @@ export class DLCBTCPorTransport extends SubscriptionTransport<TransportTypes> {
       txId,
       requestConfig,
     )
-    return response.data.result
+
+    const result = response.data.result
+
+    if (!result) {
+      logger.error('BITCOIN_RPC_URL - getrawtransaction failed, txId: ', txId)
+      logger.error('BITCOIN_RPC_URL - getrawtransaction failed, response: ', response)
+    }
+
+    return result
   }
 
   getSubscriptionTtlFromConfig(adapterSettings: TransportTypes['Settings']): number {

packages/sources/dlc-btc-por/test/integration/fixtures.ts

@@ -6,6 +6,7 @@ export const mockBitcoinRPCResponseSuccess = (): nock.Scope =>
   })
     .persist()
     .post('/', {
+      id: 'dlc-btc-por-ea',
       method: 'getrawtransaction',
       params: ['2d64eefe48cd209c4d549b065d3c04dcb29af57b01ca2a98c24274eae2732029', true, null],
       jsonrpc: '2.0',