market-status: Support nyse market and finnhub-secondary adapter (#3901)

Co-authored-by: app-token-issuer-data-feeds[bot] <134377064+app-token-issuer-data-feeds[bot]@users.noreply.github.com>

Author: martin-cll

.changeset/tidy-toys-happen.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/market-status-adapter': minor
+---
+
+Add support for nyse market and finnhub-secondary adapter

packages/composites/market-status/src/config/adapters.ts

@@ -1,4 +1,4 @@
-export const adapterNames = ['NCFX', 'TRADINGHOURS'] as const
+export const adapterNames = ['NCFX', 'TRADINGHOURS', 'FINNHUB_SECONDARY'] as const
 
 export type AdapterName = (typeof adapterNames)[number]
 
@@ -16,4 +16,8 @@ export const marketAdapters: Record<string, { primary: AdapterName; secondary: A
     primary: 'NCFX',
     secondary: 'TRADINGHOURS',
   },
+  nyse: {
+    primary: 'TRADINGHOURS',
+    secondary: 'FINNHUB_SECONDARY',
+  },
 }

packages/composites/market-status/src/config/index.ts

@@ -11,6 +11,11 @@ export const config = new AdapterConfig({
     type: 'string',
     required: true,
   },
+  FINNHUB_SECONDARY_ADAPTER_URL: {
+    description: 'URL of the Finnhub Secondary adapter',
+    type: 'string',
+    required: true,
+  },
   BACKGROUND_EXECUTE_MS: {
     description:
       'The amount of time the background execute should sleep before performing the next request',

packages/composites/market-status/test/integration/adapter.test.ts

@@ -16,6 +16,7 @@ describe('execute', () => {
     oldEnv = JSON.parse(JSON.stringify(process.env))
     process.env.NCFX_ADAPTER_URL = 'https://ncfx-adapter.com'
     process.env.TRADINGHOURS_ADAPTER_URL = 'https://tradinghours-adapter.com'
+    process.env.FINNHUB_SECONDARY_ADAPTER_URL = 'https://finnhub-secondary-adapter.com'
 
     const adapter = (await import('./../../src')).adapter as unknown as Adapter
     clock = FakeTimers.install()
@@ -165,4 +166,18 @@ describe('execute', () => {
       },
     })
   })
+
+  describe('for nyse market', () => {
+    it('returns open if tradinghours is open', async () => {
+      const market = 'nyse'
+      fixtures.mockTradinghoursOpen(market)
+      fixtures.mockFinnhubSecondaryClosed(market)
+    })
+
+    it('returns open if tradinghours is unknown and finnhub is open', async () => {
+      const market = 'nyse'
+      fixtures.mockTradinghoursUnknown(market)
+      fixtures.mockFinnhubSecondaryOpen(market)
+    })
+  })
 })

packages/composites/market-status/test/integration/fixtures.ts

@@ -78,3 +78,29 @@ export const mockNCFXError = (market: string): nock.Scope => {
     .post('/', { data: { endpoint: 'market-status', market } })
     .reply(500, {})
 }
+
+export const mockFinnhubSecondaryOpen = (market: string): nock.Scope => {
+  return nock('https://finnhub-secondary-adapter.com')
+    .persist()
+    .post('/', { data: { endpoint: 'market-status', market } })
+    .reply(200, {
+      result: 2,
+      statusCode: 200,
+      data: {
+        result: 2,
+      },
+    })
+}
+
+export const mockFinnhubSecondaryClosed = (market: string): nock.Scope => {
+  return nock('https://finnhub-secondary-adapter.com')
+    .persist()
+    .post('/', { data: { endpoint: 'market-status', market } })
+    .reply(200, {
+      result: 1,
+      statusCode: 200,
+      data: {
+        result: 1,
+      },
+    })
+}