DF-21369 fix Utils.sanitize(url) to also handle partial urls (#3933)

* DF-21369 fix Utils.sanitize(url) to also handle partial urls

i.e. those starting with '?'

* review fix: run yarn format:fix

---------

Co-authored-by: Matthew McAllister <matthew.mcallister@smartcontract.com>

Author: vlfig

.changeset/weak-chairs-think.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/ice-adapter': patch
+---
+
+fix url sanitize

packages/sources/ice/src/transport/netdania/index.ts

@@ -105,12 +105,20 @@ export class Utils {
     }
   }
 
-  static sanitize(url: string): string {
-    const urlObj = new URL(url)
-    if (urlObj.searchParams.has('h')) {
-      urlObj.searchParams.set('h', 'redacted')
+  static sanitize(urlStr: string): string {
+    try {
+      const url = new URL(urlStr)
+      if (url.searchParams.has('h')) url.searchParams.set('h', 'redacted')
+      return decodeURIComponent(url.toString())
+    } catch {
+      try {
+        const url = new URL(`https://fake-but-irrelevant.com${urlStr}`)
+        if (url.searchParams.has('h')) url.searchParams.set('h', 'redacted')
+        return '?' + decodeURIComponent(url.searchParams.toString())
+      } catch {
+        return 'redacted'
+      }
     }
-    return urlObj.toString()
   }
 }
 

packages/sources/ice/test/unit/transport-netdania-utils.test.ts

@@ -60,12 +60,26 @@ describe('PartialPriceUpdate', () => {
     )
   })
 
-  it('must sanitize a url by idempotently redacting the h parameter', () => {
-    expect(Utils.sanitize('https://example.com/path?h=12345&otherParam=value')).toBe(
-      'https://example.com/path?h=redacted&otherParam=value',
+  it('must sanitize a full url by idempotently redacting the h parameter', () => {
+    expect(Utils.sanitize('https://example.com/path?h=12345&otherParam=value&cb=?')).toBe(
+      'https://example.com/path?h=redacted&otherParam=value&cb=?',
     )
 
     const urlWithoutH = 'https://example.com/path?sessid=UP12345&otherParam=value'
     expect(Utils.sanitize(urlWithoutH)).toBe(urlWithoutH)
   })
+
+  it('must sanitize a partial url by idempotently redacting the h parameter', () => {
+    expect(
+      Utils.sanitize(
+        '?xstream=1&v=5&dt=0&h=eyJnIjoiY2hhaW4ubGluayIsImFpIjoiTm9kZUpTQVBJdjEuNS4yIiwicHIiOjIsImF1IjoibG9jYWxob3N0OjgwODAiLCJxdXAiOjEsInAiOiJmYWtlLWFwaS1rZXkifQ..&xcmd=W3sidCI6MSwiaSI6MSwibSI6MSwicyI6IkVVUlVTRCIsInAiOiJpZGMifV0.&cb=?&ts=1752653143000',
+      ),
+    ).toBe(
+      '?xstream=1&v=5&dt=0&h=redacted&xcmd=W3sidCI6MSwiaSI6MSwibSI6MSwicyI6IkVVUlVTRCIsInAiOiJpZGMifV0.&cb=?&ts=1752653143000',
+    )
+
+    const urlWithoutH =
+      '?xstream=1&v=5&dt=0&xcmd=W3sidCI6MSwiaSI6MSwibSI6MSwicyI6IkVVUlVTRCIsInAiOiJpZGMifV0.&cb=?&ts=1752653143000'
+    expect(Utils.sanitize(urlWithoutH)).toBe(urlWithoutH)
+  })
 })