Adds unit tests, addreses feedback

Author: mohamed-mehany

packages/sources/nav-libre/src/transport/date-utils.ts

@@ -13,11 +13,11 @@ export function parseDateString(dateStr: string): Date {
   if (!isValid(parsed)) {
     throw new Error(`date must be in ${DATE_FORMAT} format: got "${dateStr}"`)
   }
-  return parsed
+  return new Date(Date.UTC(parsed.getFullYear(), parsed.getMonth(), parsed.getDate()))
 }
 
-/** Ensure the window is <= N business days. Returns the (possibly adjusted) from-date. */
-export function clampToBusinessWindow(
+/** Returns a start date that is at most `maxBusinessDays` before `endDate`. */
+export function clampStartByBusinessDays(
   from: Date,
   to: Date,
   maxBusinessDays = MAX_BUSINESS_DAYS,

packages/sources/nav-libre/src/transport/fund-dates.ts

@@ -2,7 +2,7 @@ import { Requester } from '@chainlink/external-adapter-framework/util/requester'
 import { AdapterError } from '@chainlink/external-adapter-framework/validation/error'
 import { getRequestHeaders } from './authentication'
 
-interface FundDatesResponse {
+export interface FundDatesResponse {
   LogID: number
   FromDate: string
   ToDate: string
@@ -14,7 +14,7 @@ export const getFundDates = async (
   apiKey: string,
   secret: string,
   requester: Requester,
-) => {
+): Promise<FundDatesResponse> => {
   const method = 'GET'
   const url = `/navapigateway/api/v1/ClientMasterData/GetAccountingDataDates?globalFundID=${globalFundID}`
   const requestConfig = {

packages/sources/nav-libre/src/transport/fund.ts

@@ -33,7 +33,7 @@ export const getFund = async (
   apiKey: string,
   secret: string,
   requester: Requester,
-) => {
+): Promise<FundResponse['Data']> => {
   const method = 'GET'
   const url = `/navapigateway/api/v1/FundAccountingData/GetOfficialNAVAndPerformanceReturnsForFund?globalFundID=${globalFundID}&fromDate=${fromDate}&toDate=${toDate}`
   // Body is empy for GET

packages/sources/nav-libre/src/transport/nav.ts

@@ -8,7 +8,7 @@ import { SubscriptionTransport } from '@chainlink/external-adapter-framework/tra
 import { AdapterResponse, makeLogger, sleep } from '@chainlink/external-adapter-framework/util'
 import { Requester } from '@chainlink/external-adapter-framework/util/requester'
 import { AdapterInputError } from '@chainlink/external-adapter-framework/validation/error'
-import { clampToBusinessWindow, parseDateString, toDateString } from './date-utils'
+import { clampStartByBusinessDays, parseDateString, toDateString } from './date-utils'
 const logger = makeLogger('NavLibreTransport')
 
 type RequestParams = typeof inputParameters.validated
@@ -69,7 +69,7 @@ export class NavLibreTransport extends SubscriptionTransport<BaseEndpointTypes>
     )
     let from = parseDateString(FromDate)
     const to = parseDateString(ToDate)
-    from = clampToBusinessWindow(from, to)
+    from = clampStartByBusinessDays(from, to)
 
     logger.debug(`Fetching NAV for globalFundID: ${param.globalFundID} from ${from} to ${to}`)
     const fund = await getFund(
@@ -82,20 +82,23 @@ export class NavLibreTransport extends SubscriptionTransport<BaseEndpointTypes>
       this.requester,
     )
 
+    const ACCOUNTING_DATE_KEY = 'Accounting Date'
+    const NAV_PER_SHARE_KEY = 'NAV Per Share'
     // Find the latest NAV entry by Accounting Date
-    const latest = fund.reduce((a, b) => {
-      return new Date(a['Accounting Date']) > new Date(b['Accounting Date']) ? a : b
-    })
-    const [month, day, year] = latest['Accounting Date'].split('-').map(Number)
+    const latest = fund.reduce((latestRow, row) =>
+      parseDateString(row[ACCOUNTING_DATE_KEY]) > parseDateString(latestRow[ACCOUNTING_DATE_KEY])
+        ? row
+        : latestRow,
+    )
     // Assumes UTC
-    const providerIndicatedTimeUnixMs = Date.UTC(year, month - 1, day) // month is 0-based
+    const providerIndicatedTimeUnixMs = parseDateString(latest[ACCOUNTING_DATE_KEY]).getTime()
     return {
       statusCode: 200,
-      result: latest['NAV Per Share'],
+      result: latest[NAV_PER_SHARE_KEY],
       data: {
         globalFundID: param.globalFundID,
-        navPerShare: latest['NAV Per Share'],
-        navDate: latest['Accounting Date'],
+        navPerShare: latest[NAV_PER_SHARE_KEY],
+        navDate: latest[ACCOUNTING_DATE_KEY],
       },
       timestamps: {
         providerDataRequestedUnixMs,

packages/sources/nav-libre/test/unit/date-utils.test.ts

@@ -0,0 +1,59 @@
+import { differenceInBusinessDays, parse } from 'date-fns'
+import {
+  clampStartByBusinessDays,
+  DATE_FORMAT,
+  MAX_BUSINESS_DAYS,
+  parseDateString,
+  toDateString,
+} from '../../src/transport/date-utils'
+
+describe('date-utils', () => {
+  // Force UTC so tests behave the same everywhere
+  beforeAll(() => {
+    process.env.TZ = 'UTC'
+  })
+
+  describe('parseDateString', () => {
+    it('parses a valid MM-dd-yyyy string', () => {
+      const input = '07-11-2025'
+      const parsed = parseDateString(input)
+      expect(parsed).toBeInstanceOf(Date)
+      expect(parsed.getUTCFullYear()).toBe(2025)
+      expect(parsed.getUTCMonth()).toBe(6) // July is 6 (zero‑based)
+      expect(parsed.getUTCDate()).toBe(11)
+    })
+
+    it('throws for malformed input', () => {
+      const badInput = '2025-07-11'
+      expect(() => parseDateString(badInput)).toThrow(
+        `date must be in ${DATE_FORMAT} format: got "${badInput}"`,
+      )
+    })
+  })
+
+  describe('clampToBusinessWindow', () => {
+    const to = parse('07-15-2025', DATE_FORMAT, new Date())
+
+    it('returns the original from date when within the limit', () => {
+      const from = parse('07-07-2025', DATE_FORMAT, new Date()) // 6 business days before
+      const result = clampStartByBusinessDays(from, to, MAX_BUSINESS_DAYS)
+      expect(result).toEqual(from)
+    })
+
+    it('clamps when span exceeds the limit', () => {
+      const from = parse('07-01-2025', DATE_FORMAT, new Date()) // >7 business days
+      const result = clampStartByBusinessDays(from, to, MAX_BUSINESS_DAYS)
+      // Should be exactly MAX_BUSINESS_DAYS business days before `to`
+      const span = differenceInBusinessDays(to, result)
+      expect(span).toBe(MAX_BUSINESS_DAYS)
+    })
+  })
+
+  describe('toDateString', () => {
+    it('formats a Date back to MM-dd-yyyy', () => {
+      const date = new Date(Date.UTC(2025, 6, 11))
+      const formatted = toDateString(date)
+      expect(formatted).toBe('07-11-2025')
+    })
+  })
+})

packages/sources/nav-libre/test/unit/fund-dates.test.ts

@@ -0,0 +1,35 @@
+import { Requester } from '@chainlink/external-adapter-framework/util/requester'
+import { FundDatesResponse, getFundDates } from '../../src/transport/fund-dates'
+
+describe('getFundDates', () => {
+  const mockRequester = {
+    request: jest.fn(),
+  } as unknown as Requester
+
+  const mockResponse: FundDatesResponse = {
+    LogID: 1,
+    FromDate: '01-01-2023',
+    ToDate: '01-31-2023',
+  }
+
+  beforeEach(() => {
+    jest.clearAllMocks()
+  })
+
+  it('returns fund dates on success', async () => {
+    mockRequester.request = jest.fn().mockResolvedValue({
+      response: { data: mockResponse },
+    })
+    const result = await getFundDates(123, 'http://base', 'apiKey', 'secret', mockRequester)
+    expect(result).toEqual(mockResponse)
+  })
+
+  it('throws if no data returned', async () => {
+    mockRequester.request = jest.fn().mockResolvedValue({
+      response: { data: undefined },
+    })
+    await expect(
+      getFundDates(123, 'http://base', 'apiKey', 'secret', mockRequester),
+    ).rejects.toThrow()
+  })
+})

packages/sources/nav-libre/test/unit/fund.test.ts

@@ -0,0 +1,52 @@
+import { Requester } from '@chainlink/external-adapter-framework/util/requester'
+import * as authModule from '../../src/transport/authentication'
+import { getFund } from '../../src/transport/fund'
+
+describe('getFund', () => {
+  const mockRequester = {
+    request: jest.fn(),
+  } as unknown as Requester
+
+  const mockResponse = [
+    {
+      'Accounting Date': '01-01-2023',
+      'NAV Per Share': 123.45,
+    },
+  ]
+
+  let getRequestHeadersStub: jest.SpyInstance
+  beforeEach(() => {
+    jest.clearAllMocks()
+    getRequestHeadersStub = jest.spyOn(authModule, 'getRequestHeaders').mockReturnValue({})
+  })
+
+  afterEach(() => {
+    getRequestHeadersStub.mockRestore()
+  })
+  it('returns fund data on success', async () => {
+    mockRequester.request = jest.fn().mockResolvedValue({
+      response: {
+        data: { Data: mockResponse },
+      },
+    })
+    const result = await getFund(
+      123,
+      '01-01-2000',
+      '01-05-2000',
+      'http://base',
+      'apiKey',
+      'secret',
+      mockRequester,
+    )
+    expect(result).toEqual(mockResponse)
+  })
+
+  it('throws if no data returned', async () => {
+    mockRequester.request = jest.fn().mockResolvedValue({
+      response: { data: undefined },
+    })
+    await expect(
+      getFund(123, '01-01-2000', '01-05-2000', 'http://base', 'apiKey', 'secret', mockRequester),
+    ).rejects.toThrow()
+  })
+})