tradinghours: Add support for NYSE market (#3899)

Author: martin-cll

.changeset/late-dingos-push.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/tradinghours-adapter': minor
+---
+
+Add support for NYSE market

packages/sources/tradinghours/src/endpoint/market-status.ts

@@ -1,8 +1,10 @@
 import {
-  MarketStatusResultResponse,
   MarketStatusEndpoint,
+  MarketStatusResultResponse,
 } from '@chainlink/external-adapter-framework/adapter'
+import { AdapterRequest } from '@chainlink/external-adapter-framework/util'
 import { InputParameters } from '@chainlink/external-adapter-framework/validation'
+import { TypeFromDefinition } from '@chainlink/external-adapter-framework/validation/input-params'
 
 import { config } from '../config'
 import { markets, transport } from '../transport/market-status'
@@ -12,7 +14,7 @@ const inputParameters = new InputParameters({
     aliases: [],
     type: 'string',
     description: 'The name of the market',
-    options: markets,
+    options: [...markets, ...markets.map((market) => market.toUpperCase())],
     required: true,
   },
 })
@@ -28,4 +30,11 @@ export const marketStatusEndpoint = new MarketStatusEndpoint({
   aliases: markets.map((market) => `${market}-market-status`),
   transport,
   inputParameters,
+  requestTransforms: [
+    (req: AdapterRequest<TypeFromDefinition<typeof inputParameters.definition>>) => {
+      const data = req.requestContext.data
+      data.market = data.market.toLowerCase()
+      return req
+    },
+  ],
 })

packages/sources/tradinghours/src/transport/market-status.ts

@@ -4,17 +4,18 @@ import { makeLogger } from '@chainlink/external-adapter-framework/util'
 
 import type { BaseEndpointTypes } from '../endpoint/market-status'
 
-export const markets = ['forex', 'metals', 'wti'] as const
+export const markets = ['forex', 'metals', 'wti', 'nyse'] as const
 
 export type Market = (typeof markets)[number]
 
 const marketToFinId: Record<Market, string> = {
   forex: 'US.CHNLNK.FX',
   metals: 'US.CHNLNK.METAL',
   wti: 'US.CHNLNK.WTI',
+  nyse: 'US.NYSE',
 }
 
-function isMarket(v: any): v is Market {
+function isMarket(v: string): v is Market {
   return markets.includes(v as Market)
 }
 
@@ -33,10 +34,6 @@ type ResponseBody = {
       next_bell: string // 2024-06-02T17:00:00-05:00
     }
   }
-  meta: {
-    utc_time: string // 2024-05-31T21:37:34+00:00
-    time: string // 2024-05-31T21:37:34+00:00
-  }
 }
 
 export type HttpEndpointTypes = BaseEndpointTypes & {
@@ -93,9 +90,6 @@ export const transport = new HttpTransport<HttpEndpointTypes>({
             data: {
               result: marketStatus,
             },
-            timestamps: {
-              providerIndicatedTimeUnixMs: new Date(res.data.meta.time).getTime(),
-            },
           },
         },
       ]

packages/sources/tradinghours/test/integration/__snapshots__/adapter.test.ts.snap

@@ -10,7 +10,6 @@ exports[`Market status endpoint should return success with closed 1`] = `
   "timestamps": {
     "providerDataReceivedUnixMs": 1641035471111,
     "providerDataRequestedUnixMs": 1641035471111,
-    "providerIndicatedTimeUnixMs": 1717191454000,
   },
 }
 `;
@@ -25,7 +24,20 @@ exports[`Market status endpoint should return success with open 1`] = `
   "timestamps": {
     "providerDataReceivedUnixMs": 1641035471111,
     "providerDataRequestedUnixMs": 1641035471111,
-    "providerIndicatedTimeUnixMs": 1717191454000,
+  },
+}
+`;
+
+exports[`Market status endpoint should return success with open with uppercase market 1`] = `
+{
+  "data": {
+    "result": 2,
+  },
+  "result": 2,
+  "statusCode": 200,
+  "timestamps": {
+    "providerDataReceivedUnixMs": 1641035471111,
+    "providerDataRequestedUnixMs": 1641035471111,
   },
 }
 `;

packages/sources/tradinghours/test/integration/adapter.test.ts

@@ -43,6 +43,12 @@ describe('Market status endpoint', () => {
       market: 'forex',
     },
   }
+  const openDataUppercase = {
+    data: {
+      endpoint: 'market-status',
+      market: 'FOREX',
+    },
+  }
   const closedData = {
     data: {
       endpoint: 'market-status',
@@ -77,4 +83,18 @@ describe('Market status endpoint', () => {
     expect(response.body).toMatchSnapshot()
     expect(response.body.result).toEqual(MarketStatus.CLOSED)
   })
+
+  it('should return success with open with uppercase market', async () => {
+    mockResponseSuccess()
+
+    const response = await (context.req as SuperTest<Test>)
+      .post('/')
+      .send(openDataUppercase)
+      .set('Accept', '*/*')
+      .set('Content-Type', 'application/json')
+      .expect('Content-Type', /json/)
+      .expect(200)
+    expect(response.body).toMatchSnapshot()
+    expect(response.body.result).toEqual(MarketStatus.OPEN)
+  })
 })

packages/sources/tradinghours/test/integration/fixtures.ts

@@ -27,10 +27,6 @@ export const mockResponseSuccess = (): nock.Scope =>
             next_bell: '2024-06-02T17:00:00-05:00',
           },
         },
-        meta: {
-          utc_time: '2024-05-31T21:37:34+00:00',
-          time: '2024-05-31T21:37:34+00:00',
-        },
       },
       ['Content-Type', 'application/json'],
     )
@@ -66,10 +62,6 @@ export const mockResponseSuccess = (): nock.Scope =>
             next_bell: '2024-06-02T17:00:00-05:00',
           },
         },
-        meta: {
-          utc_time: '2024-05-31T21:37:34+00:00',
-          time: '2024-05-31T21:37:34+00:00',
-        },
       },
       ['Content-Type', 'application/json'],
     )