Fix/DF-21465 nav generic (#3908)

* DF-21465 nav-generic error when not https

* add changeset

---------

Co-authored-by: app-token-issuer-data-feeds[bot] <134377064+app-token-issuer-data-feeds[bot]@users.noreply.github.com>

Author: mmcallister-cll

.changeset/fair-ears-sin.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/nav-generic-adapter': patch
+---
+
+error when integration API_URL config does not start with https://

packages/sources/nav-generic/src/transport/nav.ts

@@ -41,6 +41,14 @@ export const getApiConfigs = (integration: string): { apiKey: string; apiUrl: st
     })
   }
 
+  // audit fix, ensure https at the url config level
+  if (!apiUrl.startsWith('https://')) {
+    throw new AdapterError({
+      message: `${apiUrlEnvVarName} does not start with https://`,
+      statusCode: 500,
+    })
+  }
+
   return { apiKey, apiUrl }
 }
 

packages/sources/nav-generic/test/integration/__snapshots__/adapter.test.ts.snap

@@ -33,6 +33,17 @@ exports[`execute nav endpoint should handle missing value failure 1`] = `
 }
 `;
 
+exports[`execute nav endpoint should handle non https api url error 1`] = `
+{
+  "error": {
+    "message": "INCORRECT_API_URL_API_URL does not start with https://",
+    "name": "AdapterError",
+  },
+  "status": "errored",
+  "statusCode": 500,
+}
+`;
+
 exports[`execute nav endpoint should return success 1`] = `
 {
   "data": {

packages/sources/nav-generic/test/integration/adapter.test.ts

@@ -26,6 +26,8 @@ describe('execute', () => {
       'https://dataproviderapi.com/missing-value-integration/nav'
     process.env.ERROR_RESPONSE_API_KEY = 'fake-api-key'
     process.env.ERROR_RESPONSE_API_URL = 'https://dataproviderapi.com/error-response/nav'
+    process.env.INCORRECT_API_URL_API_KEY = 'fake-api-key'
+    process.env.INCORRECT_API_URL_API_URL = 'http://dataproviderapi.com/http/nav'
     process.env.BACKGROUND_EXECUTE_MS_HTTP = '1'
 
     const mockDate = new Date('2001-01-01T11:11:11.111Z')
@@ -96,5 +98,14 @@ describe('execute', () => {
       expect(response.statusCode).toBe(500)
       expect(response.json()).toMatchSnapshot()
     })
+    it('should handle non https api url error', async () => {
+      const data = {
+        integration: 'incorrect-api-url',
+        endpoint: 'nav',
+      }
+      const response = await testAdapter.request(data)
+      expect(response.statusCode).toBe(500)
+      expect(response.json()).toMatchSnapshot()
+    })
   })
 })