nlp: be more flexible with the answers accepted from claude #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/claude-fix
branch
from
5829d01 to
a91533c
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
And do some light refactoring of NLP classes that will make a future addition of multiple-run prompts easier.
mikix
force-pushed
the
mikix/claude-fix
branch
from
a91533c to
1ac203f
Compare
mikix
commented
Oct 27, 2025
Comment on lines
+147
to
+152
| # or "$PARAMETER_NAME" :shrug: - for now, just look for those names in particular. | ||
| # If we see a wider variety, we can try to skip any single wrapper field, but I | ||
| # want to keep the option of studies that have only one top level field for now. | ||
| top_keys = set(raw_json) | ||
| if len(top_keys) == 1 and {"parameter", "$PARAMETER_NAME"} & top_keys: | ||
| raw_json = raw_json.popitem()[1] |
There was a problem hiding this comment.
This is the real fix in this PR - everything else was just some light refactoring/updating.
mikix
commented
Oct 27, 2025
|
|
||
| parsed = response.answer.model_dump(mode="json") | ||
| self.post_process(parsed, orig_note_text, orig_note) | ||
| async def process_note(self, details: NoteDetails) -> tasks.EntryBundle | None: |
There was a problem hiding this comment.
This is just some logic moved from one function into a helper function, to make it easier for subclassess to override it and add more logic if they want.
dogversioning
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do some light refactoring of NLP classes that will make a future addition of multiple-run prompts easier.
Checklist
docs/) needs to be updated