RN: Enable New Architecture & Enhance Custom Color Support for SmallPlug iOS (#122)

* fix: update method signatures to use BOOL instead of BOOL* for better clarity

* making changes to enable new arch in react native sdk

* making changes as per review

* chore(fix): resolve issue of unable to use custom colors in header and back icon in smallPlug

---------

Co-authored-by: Sourav Ganguly (isouravganguly) <sourav.ganguly@smallcase.com>

Author: dporwal-shipit

android/src/main/java/com/reactnativesmallcasegateway/SmallcaseGatewayModule.kt

@@ -179,7 +179,14 @@ class SmallcaseGatewayModule(reactContext: ReactApplicationContext) : ReactConte
     }
 
     @ReactMethod
-    fun launchSmallplugWithBranding(targetEndpoint: String, params: String, readableMap: ReadableMap?, promise: Promise) {
+    fun launchSmallplugWithBranding(targetEndpoint: String, params: String, headerColor: String?, headerOpacity: Double?, backIconColor: String?, backIconOpacity: Double?, promise: Promise
+    ) {
+        val readableMap = Arguments.createMap().apply {
+            headerColor?.let { putString("headerColor", it) }
+            headerOpacity?.let { putDouble("headerOpacity", it) }
+            backIconColor?.let { putString("backIconColor", it) }
+            backIconOpacity?.let { putDouble("backIconOpacity", it) }
+        }
 
         fun getColorValue(value: Any?, defaultValue: String): String {
             return when (value) {
@@ -196,7 +203,7 @@ class SmallcaseGatewayModule(reactContext: ReactApplicationContext) : ReactConte
         var partnerProps: SmallplugPartnerProps? = SmallplugPartnerProps(headerColor = "#2F363F", backIconColor = "ffffff")
 
         try {
-            partnerProps = readableMap?.toHashMap()?.let { map ->
+            partnerProps = readableMap.toHashMap().let { map ->
                 val hc = getColorValue(map["headerColor"], "#2F363F")
                 val ho = map["headerOpacity"]?.let { if (it is Double) it else 1.0 } ?: 1.0
                 val bc = getColorValue(map["backIconColor"], "#ffffff")
@@ -206,19 +213,16 @@ class SmallcaseGatewayModule(reactContext: ReactApplicationContext) : ReactConte
         } catch (e: Throwable) {
         }
 
-
         SmallcaseGatewaySdk.launchSmallPlug(currentActivity!!, SmallplugData(targetEndpoint, params), object : SmallPlugResponseListener {
             override fun onFailure(errorCode: Int, errorMessage: String) {
                 val err = createErrorJSON(errorCode, errorMessage, null)
-
                 promise.reject("error", err)
             }
 
             override fun onSuccess(smallPlugResult: SmallPlugResult) {
                 val res = resultToWritableMap(smallPlugResult)
                 promise.resolve(res)
             }
-
         }, partnerProps)
     }
 

ios/SmallcaseGateway.m

@@ -30,8 +30,8 @@ @interface RCT_EXTERN_MODULE(SmallcaseGateway, NSObject)
 RCT_REMAP_METHOD(setConfigEnvironment,
                  envName:(NSString *)envName
                  gateway:(NSString *)gateway
-                 isLeprechaunActive: (BOOL *)isLeprechaunActive
-                 isAmoEnabled: (BOOL *)isAmoEnabled
+                 isLeprechaunActive: (BOOL)isLeprechaunActive
+                 isAmoEnabled: (BOOL)isAmoEnabled
                  preProvidedBrokers: (NSArray *)preProvidedBrokers
                  setConfigEnvironmentWithResolver:(RCTPromiseResolveBlock)resolve
                  rejecter:(RCTPromiseRejectBlock)reject) {
@@ -383,9 +383,25 @@ @interface RCT_EXTERN_MODULE(SmallcaseGateway, NSObject)
                  rejecter:(RCTPromiseRejectBlock)reject)
 {
     dispatch_async(dispatch_get_main_queue(), ^(void) {
+        
+        NSString* (^processColorValue)(NSString*, NSString*) = ^NSString*(NSString *color, NSString *defaultColor) {
+            if (color == nil || color.length < 6) {
+                return defaultColor;
+            }
+            if ([color hasPrefix:@"#"]) {
+                return [color substringFromIndex:1];
+            }
+            return color;
+        };
+        
+        NSString *processedHeaderColor = processColorValue(headerColor, @"2F363F");
+        NSString *processedBackIconColor = processColorValue(backIconColor, @"ffffff");
+        
+        double finalHeaderOpacity = headerOpacity != nil ? [headerOpacity doubleValue] : 1.0;
+        double finalBackIconOpacity = backIconOpacity != nil ? [backIconOpacity doubleValue] : 1.0;
 
         SmallplugData *smallplugData = [[SmallplugData alloc] init:targetEndpoint :params];
-        SmallplugUiConfig *smallplugUiConfig = [[SmallplugUiConfig alloc] initWithSmallplugHeaderColor:headerColor headerColorOpacity:headerOpacity backIconColor:backIconColor backIconColorOpacity:backIconOpacity];
+        SmallplugUiConfig *smallplugUiConfig = [[SmallplugUiConfig alloc] initWithSmallplugHeaderColor:processedHeaderColor headerColorOpacity:@(finalHeaderOpacity) backIconColor:processedBackIconColor backIconColorOpacity:@(finalBackIconOpacity)];
 
         [SCGateway.shared launchSmallPlugWithPresentingController:[[[UIApplication sharedApplication] keyWindow] rootViewController] smallplugData:smallplugData smallplugUiConfig:smallplugUiConfig completion:^(id smallplugResponse, NSError * error) {
 
@@ -480,7 +496,7 @@ @interface RCT_EXTERN_MODULE(SmallcaseGateway, NSObject)
 RCT_REMAP_METHOD(triggerLeadGenWithLoginCta,
                   userParams: (NSDictionary *)userParams
                   utmParams:(NSDictionary *)utmParams
-                  showLoginCta:(BOOL *)showLoginCta
+                  showLoginCta:(BOOL)showLoginCta
                   leadGenGenWithResolver: (RCTPromiseResolveBlock)resolve
                   rejecter:(RCTPromiseRejectBlock)reject
                   ) {

smart_investing_react_native/android/gradle.properties

@@ -32,7 +32,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
 # your application. You should enable this flag either if you want
 # to write custom TurboModules/Fabric components OR use libraries that
 # are providing them.
-newArchEnabled=false
+newArchEnabled=true
 
 # Use this property to enable or disable the Hermes JS engine.
 # If set to false, you will be using JSC instead.

smart_investing_react_native/ios/Podfile

@@ -22,8 +22,9 @@ target 'smart_investing_react_native' do
 
   use_react_native!(
     :path => config[:reactNativePath],
-    # An absolute path to your application root.
-    :app_path => "#{Pod::Config.instance.installation_root}/.."
+    :app_path => "#{Pod::Config.instance.installation_root}/..",
+    :fabric_enabled => true,
+    :hermes_enabled => true
   )
 
   post_install do |installer|