Skip to content

Update accesskit_winit to 0.26 #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DataTriny opened this issue Apr 14, 2025 · 2 comments · May be fixed by #8152
Open

Update accesskit_winit to 0.26 #8148

DataTriny opened this issue Apr 14, 2025 · 2 comments · May be fixed by #8152
Assignees
@tronical
Labels
a:accessibility Support for assistive technologies (mS,bT) a:backend-winit Winit backend (mS,mO) enhancement New feature or request

Comments

@DataTriny
Copy link
Contributor

Feature Description

We recently changed the signature of the accesskit_winit adapter constructors to take the ActiveEventLoop. Since Slint currently initializes the adapter from an EventLoop, I don't see how AccessKit can easily be updated. I have no doubt you are aware of the issue with winit's event loop since it is already marked as deprecated, I just wanted to let you know that this is a blocking point for accessibility.

Please let me know if there are actions I can take to drive this forward.

Product Impact

Slint can't currently take advantage of recent improvements in AccessKit, such as support for list views.
@DataTriny DataTriny added enhancement New feature or request need triaging Issue that the owner of the area still need to triage labels Apr 14, 2025
@ogoffart ogoffart added a:backend-winit Winit backend (mS,mO) a:accessibility Support for assistive technologies (mS,bT) labels Apr 14, 2025
@tronical
Copy link
Member

Thanks for filing this - it’s good to track this :). I’m also aware and I’ve got a local branch that implements this, but it’s quite ugly. I’ve started on implementing a proper resume protocol where this becomes easy.

Now that I think about it though: we’d like to make a new release next week and it would be good to use the latest AccessKit with the latest improvements. So let me see if I can resurrect my slightly ugly change and we take the update along.

@tronical tronical removed the need triaging Issue that the owner of the area still need to triage label Apr 14, 2025
@tronical tronical self-assigned this Apr 14, 2025
@tronical tronical added this to the 1.11 milestone Apr 14, 2025
@DataTriny
Copy link
Contributor Author

Thank you guys! Feel free to ask me a review once you're ready.

tronical added a commit that referenced this issue Apr 15, 2025
@tronical
Update AccessKit
ff43022 
Fixes #8148
@tronical tronical linked a pull request Apr 15, 2025 that will close this issue
Open
@tronical tronical removed this from the 1.11 milestone Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tronical tronical

Labels
a:accessibility Support for assistive technologies (mS,bT) a:backend-winit Winit backend (mS,mO) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update AccessKit slint-ui/slint
3 participants
@tronical @ogoffart @DataTriny