From 7eabd82f33a1d4b7d6af4834bd32b62735d5e479 Mon Sep 17 00:00:00 2001 From: Brad Kent Date: Thu, 19 Jun 2025 16:18:12 -0500 Subject: [PATCH 1/2] ClassHelper::isFinal() - param 2 must be an int... null passed --- .../Sniffs/Classes/ModernClassNameReferenceSniff.php | 2 +- .../Sniffs/Classes/UselessLateStaticBindingSniff.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php b/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php index 1ff15c61e..f502b8e7f 100644 --- a/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php +++ b/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php @@ -144,7 +144,7 @@ private function checkFunctionCall(File $phpcsFile, int $functionPointer): void /** @var int $classPointer */ $classPointer = FunctionHelper::findClassPointer($phpcsFile, $functionPointer); - if (!ClassHelper::isFinal($phpcsFile, $classPointer)) { + if (!ClassHelper::isFinal($phpcsFile, (int) $classPointer)) { return; } } diff --git a/SlevomatCodingStandard/Sniffs/Classes/UselessLateStaticBindingSniff.php b/SlevomatCodingStandard/Sniffs/Classes/UselessLateStaticBindingSniff.php index e9a2366c4..08a2e552d 100644 --- a/SlevomatCodingStandard/Sniffs/Classes/UselessLateStaticBindingSniff.php +++ b/SlevomatCodingStandard/Sniffs/Classes/UselessLateStaticBindingSniff.php @@ -51,7 +51,7 @@ public function process(File $phpcsFile, $staticPointer): void break; } - if (!ClassHelper::isFinal($phpcsFile, $classPointer)) { + if (!ClassHelper::isFinal($phpcsFile, (int) $classPointer)) { return; } From a7ff95618d10929547db359d99c11d3ca5a25099 Mon Sep 17 00:00:00 2001 From: Brad Kent Date: Thu, 19 Jun 2025 16:26:00 -0500 Subject: [PATCH 2/2] /** @var int|null $classPointer */ (not sure this annotation is necessary) --- .../Sniffs/Classes/ModernClassNameReferenceSniff.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php b/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php index f502b8e7f..9769bb09b 100644 --- a/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php +++ b/SlevomatCodingStandard/Sniffs/Classes/ModernClassNameReferenceSniff.php @@ -142,7 +142,7 @@ private function checkFunctionCall(File $phpcsFile, int $functionPointer): void return; } - /** @var int $classPointer */ + /** @var int|null $classPointer */ $classPointer = FunctionHelper::findClassPointer($phpcsFile, $functionPointer); if (!ClassHelper::isFinal($phpcsFile, (int) $classPointer)) { return;