do...while loop should only increment once (not for both the T_DO and T_WHILE)

Author: bkdotcom

SlevomatCodingStandard/Sniffs/Complexity/CognitiveSniff.php

@@ -6,6 +6,7 @@
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Util\Tokens;
 use SlevomatCodingStandard\Helpers\FunctionHelper;
+use SlevomatCodingStandard\Helpers\TokenHelper;
 use function array_filter;
 use function array_pop;
 use function array_splice;
@@ -28,6 +29,7 @@
 use const T_IF;
 use const T_INLINE_ELSE;
 use const T_INLINE_THEN;
+use const T_OPEN_CURLY_BRACKET;
 use const T_OPEN_PARENTHESIS;
 use const T_SEMICOLON;
 use const T_SWITCH;
@@ -248,6 +250,16 @@ public function computeForFunctionFromTokensAndPosition(int $position): int
 		return $this->cognitiveComplexity;
 	}
 
+	protected function isPartOfDo(File $phpcsFile, int $whilePointer): bool
+	{
+		$tokens = $phpcsFile->getTokens();
+
+		$parenthesisCloserPointer = $tokens[$whilePointer]['parenthesis_closer'];
+		$pointerAfterParenthesisCloser = TokenHelper::findNextEffective($phpcsFile, $parenthesisCloserPointer + 1);
+
+		return $tokens[$pointerAfterParenthesisCloser]['code'] !== T_OPEN_CURLY_BRACKET;
+	}
+
 	/**
 	 * Keep track of consecutive matching boolean operators, that don't receive increment.
 	 *
@@ -286,7 +298,9 @@ private function isIncrementingToken(array $token, array $tokens, int $position)
 		$code = $token['code'];
 
 		if (isset(self::INCREMENTS[$code])) {
-			return true;
+			return $token['code'] === T_WHILE
+				? !$this->isPartOfDo($this->phpcsFile, $position)
+				: true;
 		}
 
 		// B1. ternary operator

tests/Sniffs/Complexity/CognitiveSniffTest.php

@@ -86,6 +86,12 @@ public static function dataProviderFiles(): array
 				'ternaryTest',
 				3,
 			],
+			[
+				__DIR__ . '/data/cognitive/doWhile.php',
+				3,
+				'doWhile',
+				9,
+			],
 		];
 	}
 

tests/Sniffs/Complexity/data/cognitive/doWhile.php

@@ -0,0 +1,15 @@
+<?php
+
+function doWhile($var)
+{
+    try {
+        if (true) { // +1
+			do {  // +2 (nesting=1)
+				for ($i = 0; $i < 10; $i++) {  // +3 (nesting=2)
+				}
+			} while (true); // don't increment!
+        }
+    } catch (\Exception | \Exception $exception) { // +1
+        if (true) { } // +2 (nesting=1)
+    }
+}