Skip to content

Commit cb0b147

Browse files
committed
Revert "MAINT: merge main into module/halos (#581)"
This reverts commit 3496ac0.
1 parent 3496ac0 commit cb0b147

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+341
-1304
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Description
22

33
## Checklist
4-
- [ ] Follow the [Contributor Guidelines](https://github.com/skypyproject/skypy/blob/main/CONTRIBUTING.rst)
4+
- [ ] Follow the [Contributor Guidelines](https://github.com/skypyproject/skypy/blob/master/CONTRIBUTING.md)
55
- [ ] Write unit tests
66
- [ ] Write documentation strings
77
- [ ] Assign someone from your working team to review this pull request

.github/workflows/codestyle.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ name: Code Style
22
on:
33
push:
44
branches:
5-
- main
5+
- master
66
- module/*
77
pull_request:
88
branches:
9-
- main
9+
- master
1010
- module/*
1111
jobs:
1212
flake8:

.github/workflows/compatibility.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ jobs:
99
fail-fast: false
1010
matrix:
1111
os: [ubuntu-latest]
12-
python: ['3.10']
13-
toxenv: [py310-test, py310-test-dev]
14-
release: [main, latest]
12+
python: [3.9]
13+
toxenv: [py39-test, py39-test-dev]
14+
release: [master, latest]
1515
steps:
1616
- name: Checkout Repository
1717
uses: actions/checkout@v2
1818
with:
1919
fetch-depth: 0
20-
- if: matrix.release != 'main'
20+
- if: matrix.release != 'master'
2121
name: Checkout Release
2222
run: |
2323
git checkout tags/$(curl -s https://api.github.com/repos/skypyproject/skypy/releases/${{ matrix.release }} | python -c "import sys, json; print(json.load(sys.stdin)['tag_name'])")

.github/workflows/tests.yaml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ name: Tests
22
on:
33
push:
44
branches:
5-
- main
5+
- master
66
- module/*
77
pull_request:
88
branches:
9-
- main
9+
- master
1010
- module/*
1111
jobs:
1212
test:
@@ -19,24 +19,24 @@ jobs:
1919

2020
- name: latest supported versions
2121
os: ubuntu-latest
22-
python: '3.10'
23-
toxenv: py310-test-all-latest-cov
22+
python: 3.9
23+
toxenv: py39-test-all-latest-cov
2424
toxposargs: --cov-report=xml:${GITHUB_WORKSPACE}/coverage.xml
2525

2626
- name: oldest supported versions
2727
os: ubuntu-latest
28-
python: 3.7
29-
toxenv: py37-test-oldest
28+
python: 3.6
29+
toxenv: py36-test-oldest
3030

3131
- name: macOS latest supported
3232
os: macos-latest
33-
python: '3.10'
34-
toxenv: py310-test-latest
33+
python: 3.9
34+
toxenv: py39-test-latest
3535

3636
- name: Windows latest supported
3737
os: windows-latest
38-
python: '3.10'
39-
toxenv: py310-test-latest
38+
python: 3.9
39+
toxenv: py39-test-latest
4040

4141
steps:
4242
- name: Checkout Repository

.mailmap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@
1313
Adam Amara <adam.amara@phys.ethz.ch> adamamara <adamamara@penguin>
1414
Coleman Krawczyk <coleman.krawczyk@gmail.com> CKrawczyk
1515
Ian Harry <ian.harry@ligo.org> <iwharry@googlemail.com>
16-
Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
1716
Nicolas Tessore <n.tessore@ucl.ac.uk> <nicolas.tessore@manchester.ac.uk>
1817
Richard R <58728519+rrjbca@users.noreply.github.com> <rrjbca@users.noreply.github.com>

.readthedocs.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,17 @@
11
version: 2
22

33
build:
4-
os: ubuntu-20.04
5-
apt_packages:
6-
- graphviz
7-
tools:
8-
python: "3.7"
4+
image: latest
95

106
sphinx:
11-
builder: html
12-
configuration: docs/conf.py
137
fail_on_warning: true
148

159
python:
16-
system_packages: false
10+
version: 3.7
1711
install:
1812
- method: pip
1913
path: .
2014
extra_requirements:
2115
- docs
22-
- all
2316

2417
formats: []

.zenodo.json

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
},
2626
{
2727
"orcid": "0000-0002-1064-3400",
28-
"affiliation": "University of Portsmouth",
28+
"affiliation": "University of Manchester",
2929
"name": "Lucia F. de la Bella"
3030
},
3131
{
@@ -43,31 +43,21 @@
4343
"affiliation": "University of Manchester",
4444
"name": "Juan Pablo Cordero"
4545
},
46-
{
47-
"orcid": "0000-0003-1560-7959",
48-
"affiliation": "University of Portsmouth",
49-
"name": "Fox Davidson"
50-
},
5146
{
5247
"orcid": "0000-0002-8218-563X",
5348
"affiliation": "University of Portsmouth",
5449
"name": "Ginevra Favole"
5550
},
5651
{
5752
"orcid": "0000-0002-4437-0770",
58-
"affiliation": "University of Oxford, University of Manchester",
53+
"affiliation": "University of Manchester",
5954
"name": "Ian Harrison"
6055
},
6156
{
6257
"orcid": "0000-0002-5304-9372",
6358
"affiliation": "University of Portsmouth",
6459
"name": "Ian Harry"
6560
},
66-
{
67-
"orcid": "0000-0001-9994-1115",
68-
"affiliation": "University of Geneva",
69-
"name": "William G. Hartley"
70-
},
7161
{
7262
"orcid": "0000-0001-9233-2341",
7363
"affiliation": "University of Portsmouth",
@@ -90,19 +80,14 @@
9080
},
9181
{
9282
"orcid": "0000-0003-1291-1023",
93-
"affiliation": "University of Edinburgh",
94-
"name": "Richard P. Rollins"
83+
"affiliation": "University of Manchester",
84+
"name": "Richard Rollins"
9585
},
9686
{
9787
"orcid": "0000-0001-8685-2308",
9888
"affiliation": "University of Portsmouth",
9989
"name": "Philipp Sudek"
10090
},
101-
{
102-
"orcid": "0000-0002-6724-833X",
103-
"affiliation": "Institute of Astronomy and Astrophysics Academia Sinica",
104-
"name": "Sut-Ieng Tam"
105-
},
10691
{
10792
"orcid": "0000-0002-9696-7931",
10893
"affiliation": "UCL",
@@ -113,20 +98,10 @@
11398
"affiliation": "Institute of Astronomy and Astrophysics Academia Sinica",
11499
"name": "Keiichi Umetsu"
115100
},
116-
{
117-
"orcid": "0000-0001-9841-943X",
118-
"affiliation": "University of Portsmouth",
119-
"name": "Arthur E. Tolley"
120-
},
121101
{
122102
"orcid": "0000-0002-7627-8688",
123103
"affiliation": "University of Portsmouth",
124104
"name": "Andrew R. Williamson"
125-
},
126-
{
127-
"orcid": "0000-0003-3334-3037",
128-
"affiliation": "University of Manchester",
129-
"name": "Laura Wolz"
130105
}
131106
],
132107
"contributors": [

CITATION.rst

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,13 @@
1-
Citation Guidelines
2-
===================
3-
4-
|JOSS| |Zenodo|
5-
6-
71
If you use SkyPy for work or research presented in a publication (whether
8-
directly, or as a dependency of another package) we recommend and encourage
2+
directly, or as a dependency to another package) we recommend and encourage
93
the following acknowledgment:
104

115
This research made use of SkyPy, a Python package for forward modeling
12-
astronomical surveys (Amara et. al., 2021, SkyPy Collaboration, 202x).
13-
14-
where the citations are to our publication in the `Journal of Open Source
15-
Software`_ and the `Zenodo DOI`_ for the specific version of the software that
16-
you used. We also encourage citations within the main text wherever
17-
appropriate. DOIs and BibTeX keys are available through the links above.
18-
19-
.. _Journal of Open Source Software: https://joss.theoj.org/papers/10.21105/joss.03056
20-
.. _Zenodo DOI: https://zenodo.org/record/3755531
21-
6+
astronomical surveys (SkyPy Collaboration, 2020).
227

23-
.. |JOSS| image:: https://joss.theoj.org/papers/10.21105/joss.03056/status.svg
24-
:target: https://doi.org/10.21105/joss.03056
8+
where (SkyPy Collaboration, 2020) is a citation to the software DOI for the
9+
specific version that you used. We also encourage you to cite the software DOI
10+
in the main text wherever appropriate. DOIs and BibTeX keys for each release
11+
can be found on Zenodo_.
2512

26-
.. |Zenodo| image:: https://zenodo.org/badge/doi/10.5281/zenodo.4475347.svg
27-
:target: https://doi.org/10.5281/zenodo.3755531
13+
.. _Zenodo: https://zenodo.org/record/3755531

CONTRIBUTING.rst

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ Finally add the ``skypyproject`` repository as a *remote*. This will allow you t
3232
Create a branch for your new feature
3333
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
3434

35-
Create a *branch* off the ``skypyproject`` main branch. Working on unique branches for each new feature simplifies the development, review and merge processes by maintining logical separation. To create a feature branch:
35+
Create a *branch* off the ``skypyproject`` master branch. Working on unique branches for each new feature simplifies the development, review and merge processes by maintining logical separation. To create a feature branch:
3636

3737
::
3838

3939
git fetch skypyproject
40-
git checkout -b <your-branch-name> skypyproject/main
40+
git checkout -b <your-branch-name> skypyproject/master
4141

4242

4343
Hack away!
@@ -73,7 +73,7 @@ When you feel that work on your new feature is complete, you should create a *Pu
7373
1. Go to `SkyPy Pull Requests <https://github.com/skypyproject/skypy/pulls>`_
7474
2. Click the green **New pull request** button
7575
3. Click **compare across forks**
76-
4. Confirm that the base fork is ``skypyproject/skypy`` and the base branch is ``main``
76+
4. Confirm that the base fork is ``skypyproject/skypy`` and the base branch is ``master``
7777
5. Confirm the head fork is ``<your-account>/skypy`` and the compare branch is ``<your-branch-name>``
7878
6. Give your pull request a title and fill out the the template for the description
7979
7. Click the green **Create pull request** button
@@ -91,22 +91,22 @@ A series of automated checks will be run on your pull request, some of which wil
9191
Updating your branch
9292
^^^^^^^^^^^^^^^^^^^^
9393

94-
As you work on your feature, new commits might be made to the ``skypyproject`` main branch. You will need to update your branch with these new commits before your pull request can be accepted. You can achieve this in a few different ways:
94+
As you work on your feature, new commits might be made to the ``skypyproject`` master branch. You will need to update your branch with these new commits before your pull request can be accepted. You can achieve this in a few different ways:
9595

9696
- If your pull request has no conflicts, click **Update branch**
9797
- If your pull request has conflicts, click **Resolve conflicts**, manually resolve the conflicts and click **Mark as resolved**
98-
- *merge* the ``skypyproject`` main branch from the command line:
98+
- *merge* the ``skypyproject`` master branch from the command line:
9999

100100
::
101101

102102
git fetch skypyproject
103-
git merge skypyproject/main
103+
git merge skypyproject/master
104104

105-
- *rebase* your feature branch onto the ``skypyproject`` main branch from the command line:
105+
- *rebase* your feature branch onto the ``skypyproject`` master branch from the command line:
106106
::
107107

108108
git fetch skypyproject
109-
git rebase skypyproject/main
109+
git rebase skypyproject/master
110110

111111

112112
**Warning**: It is bad practice to *rebase* commits that have already been pushed to a remote such as your fork. Rebasing creates new copies of your commits that can cause the local and remote branches to diverge. ``git push --force`` will **overwrite** the remote branch with your newly rebased local branch. This is strongly discouraged, particularly when working on a shared branch where you could erase a collaborators commits.
@@ -129,7 +129,7 @@ Before your pull request can be merged into the codebase, it will be reviewed by
129129
General Guidelines
130130
^^^^^^^^^^^^^^^^^^
131131

132-
- SkyPy is compatible with Python>=3.7 (see `setup.cfg <https://github.com/skypyproject/skypy/blob/main/setup.cfg>`_). SkyPy *does not* support backwards compatibility with Python 2.x; `six`, `__future__` and `2to3` should not be used.
132+
- SkyPy is compatible with Python>=3.6 (see `setup.cfg <https://github.com/skypyproject/skypy/blob/master/setup.cfg>`_). SkyPy *does not* support backwards compatibility with Python 2.x; `six`, `__future__` and `2to3` should not be used.
133133
- All contributions should follow the `PEP8 Style Guide for Python Code <https://www.python.org/dev/peps/pep-0008/>`_. We recommend using `flake8 <https://flake8.pycqa.org/>`__ to check your code for PEP8 compliance.
134134
- Importing SkyPy should only depend on having `NumPy <https://www.numpy.org>`_, `SciPy <https://www.scipy.org/>`_ and `Astropy <https://www.astropy.org/>`__ installed.
135135
- Code is grouped into submodules based on broad science areas e.g. `galaxies <https://skypy.readthedocs.io/en/stable/galaxies.html>`_. There is also a `utils <https://skypy.readthedocs.io/en/stable/utils/index.html>`_ submodule for general utility functions.
@@ -150,6 +150,7 @@ All public classes, methods and functions require docstrings. You can build docu
150150
- Description
151151
- Parameters
152152
- Notes
153+
- Examples
153154
- References
154155

155156
For more information see the Astropy guide to `Writing Documentation <https://docs.astropy.org/en/stable/development/docguide.html>`_.

0 commit comments

Comments
 (0)