Skip to content

Commit d70b7fd

Browse files
authored
Merge pull request #914 from makerdao/new-vnet
Update tenderly chain id
2 parents cf83ee4 + 540bb34 commit d70b7fd

File tree

7 files changed

+123
-8
lines changed

7 files changed

+123
-8
lines changed

.github/workflows/e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
include:
1515
- test: executives.spec
1616
- test: delegates.spec
17-
- test: esmodule.spec
17+
# - test: esmodule.spec
1818
- test: polling.spec
1919
runs-on: ubuntu-latest
2020
env:

modules/tags/constants/poll-tags-mapping.json

Lines changed: 114 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4465,5 +4465,119 @@
44654465
"risk-parameter",
44664466
"d3m",
44674467
"spark"
4468+
],
4469+
"1120": [
4470+
"high-impact",
4471+
"risk-parameter",
4472+
"spark"
4473+
],
4474+
"1121": [
4475+
"high-impact",
4476+
"mips"
4477+
],
4478+
"1122": [
4479+
"high-impact",
4480+
"mips"
4481+
],
4482+
"1124": [
4483+
"high-impact",
4484+
"collateral-onboard",
4485+
"risk-parameter",
4486+
"psm"
4487+
],
4488+
"1125": [
4489+
"medium-impact",
4490+
"collateral-onboard",
4491+
"risk-parameter",
4492+
"d3m",
4493+
"spark"
4494+
],
4495+
"1126": [
4496+
"high-impact",
4497+
"risk-parameter",
4498+
"spark"
4499+
],
4500+
"1127": [
4501+
"high-impact",
4502+
"mips"
4503+
],
4504+
"1128": [
4505+
"high-impact",
4506+
"risk-parameter",
4507+
"psm"
4508+
],
4509+
"1129": [
4510+
"high-impact",
4511+
"ratification",
4512+
"mips"
4513+
],
4514+
"1130": [
4515+
"high-impact",
4516+
"mips"
4517+
],
4518+
"1131": [
4519+
"medium-impact",
4520+
"spark"
4521+
],
4522+
"1132": [
4523+
"high-impact",
4524+
"oracle",
4525+
"spark"
4526+
],
4527+
"1133": [
4528+
"high-impact",
4529+
"misc-governance",
4530+
"risk-parameter",
4531+
"endgame"
4532+
],
4533+
"1134": [
4534+
"high-impact",
4535+
"technical",
4536+
"endgame",
4537+
"spark"
4538+
],
4539+
"1135": [
4540+
"high-impact",
4541+
"collateral-offboard"
4542+
],
4543+
"1136": [
4544+
"high-impact",
4545+
"collateral-offboard"
4546+
],
4547+
"1137": [
4548+
"high-impact",
4549+
"collateral-offboard"
4550+
],
4551+
"1138": [
4552+
"high-impact",
4553+
"collateral-offboard"
4554+
],
4555+
"1139": [
4556+
"high-impact",
4557+
"collateral-offboard"
4558+
],
4559+
"1140": [
4560+
"high-impact",
4561+
"risk-parameter"
4562+
],
4563+
"1141": [
4564+
"high-impact",
4565+
"collateral-onboard",
4566+
"spark"
4567+
],
4568+
"1142": [
4569+
"high-impact",
4570+
"mips"
4571+
],
4572+
"1143": [
4573+
"high-impact",
4574+
"collateral-onboard",
4575+
"collateral-offboard",
4576+
"risk-parameter",
4577+
"psm"
4578+
],
4579+
"1144": [
4580+
"high-impact",
4581+
"endgame"
44684582
]
44694583
}

modules/web3/connections/CustomizedBridge.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ import logger from 'lib/logger';
1313

1414
export class CustomizedBridge extends Eip1193Bridge {
1515
chainId = SupportedChainId.TENDERLY;
16-
chainIdHex = '0x1df2041';
16+
chainIdHex = `0x${this.chainId.toString(16)}`;
17+
1718
address: string;
1819

1920
setAddress(add: string) {

modules/web3/constants/chainID.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ export enum SupportedChainId {
1010
MAINNET = 1,
1111
ARBITRUM = 42161,
1212
ARBITRUMTESTNET = 421614,
13-
TENDERLY = 31400001
13+
TENDERLY = 314311
1414
}

modules/web3/constants/networks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const CHAIN_INFO: ChainInfo = {
102102
defaultRpc: NodeProviders.TENDERLY,
103103
spockUrl: TENDERLY_SPOCK_URL,
104104
rpcs: {
105-
[NodeProviders.TENDERLY]: TENDERLY_RPC_URL || `https://virtual.mainnet.rpc.tenderly.co/${config.TENDERLY_RPC_KEY}`
105+
[NodeProviders.TENDERLY]: config.USE_MOCK_WALLET && TENDERLY_RPC_URL ? TENDERLY_RPC_URL : `https://virtual.mainnet.rpc.tenderly.co/${config.TENDERLY_RPC_KEY}`
106106
},
107107
showInProduction: false
108108
}

playwright/esmodule.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { test, expect } from '@playwright/test';
22
import { connectWallet, closeModal } from './shared';
33
import './forkVnet';
44

5-
test('Input 150,000MKR and burn it', async ({ page }) => {
5+
test.skip('Input 150,000MKR and burn it', async ({ page }) => {
66
await page.goto('/esmodule');
77

88
await expect(page.locator('text=Emergency Shutdown Module')).toBeVisible();

playwright/forkVnet.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ test.afterAll(async () => {
2727
export const setEthBalance = async (address: string, amount: string) => {
2828
const file = await readFile('./tenderlyTestnetData.json', 'utf-8');
2929
const { TENDERLY_RPC_URL } = JSON.parse(file);
30-
30+
const hexAmount = hexlify(parseEther(amount)).replace(/^0x0/, '0x');
3131
const response = await fetch(TENDERLY_RPC_URL, {
3232
method: 'POST',
3333
headers: {
@@ -36,7 +36,7 @@ export const setEthBalance = async (address: string, amount: string) => {
3636
},
3737
body: JSON.stringify({
3838
method: 'tenderly_setBalance',
39-
params: [[address], hexlify(parseEther(amount))],
39+
params: [[address], hexAmount],
4040
id: 42,
4141
jsonrpc: '2.0'
4242
})
@@ -88,7 +88,7 @@ const forkVnet = async (displayName: string) => {
8888
],
8989
method: 'POST',
9090
body: JSON.stringify({
91-
srcContainerId: '15f151cf-8db9-4eca-bb64-ff557c753605', //id for mainnet-fork (https://api.tenderly.co/api/v1/makerdao/testnets)
91+
srcContainerId: 'a3cdcbc9-56a7-4583-bb2d-705f3bd58e43', //id for e2e-testing-aug-28-fork
9292
dstContainerDisplayName: displayName
9393
})
9494
}

0 commit comments

Comments
 (0)