Remove some unused dependency declarations

SimonSapin · skrzyp1 · commit b4b16ae523ec · 2020-06-02T17:20:43.000+02:00
This is based on compiling with `RUSTFLAGS="-W unused_crate_dependencies"` (CC rust-lang/rust#72342) in a recent Nightly (more so than used in the tree as of this writing, CC servo#26661 for work-arounds). Only one crate is actually removed from the dependency graph, others are still dependended from other places.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/components/canvas/Cargo.toml b/components/canvas/Cargo.toml
@@ -21,7 +21,6 @@ byteorder = "1"
 canvas_traits = { path = "../canvas_traits" }
 crossbeam-channel = "0.4"
 cssparser = "0.27"
-embedder_traits = { path = "../embedder_traits" }
 euclid = "0.20"
 fnv = "1.0"
 gleam = "0.11"
diff --git a/components/constellation/Cargo.toml b/components/constellation/Cargo.toml
@@ -37,7 +37,6 @@ profile_traits = { path = "../profile_traits" }
 script_traits = { path = "../script_traits" }
 serde = "1.0"
 servo_config = { path = "../config" }
-servo_geometry = { path = "../geometry" }
 servo_rand = {path = "../rand" }
 servo_remutex = { path = "../remutex" }
 servo_url = { path = "../url" }
diff --git a/components/layout/Cargo.toml b/components/layout/Cargo.toml
@@ -17,11 +17,9 @@ app_units = "0.7"
 atomic_refcell = "0.1"
 bitflags = "1.0"
 canvas_traits = { path = "../canvas_traits" }
-crossbeam-channel = "0.4"
 embedder_traits = { path = "../embedder_traits" }
 euclid = "0.20"
 fnv = "1.0"
-fxhash = "0.2"
 gfx = { path = "../gfx" }
 gfx_traits = { path = "../gfx_traits" }
 html5ever = "0.25"
diff --git a/components/layout_2020/Cargo.toml b/components/layout_2020/Cargo.toml
@@ -39,7 +39,6 @@ script_traits = { path = "../script_traits" }
 serde = "1.0"
 serde_json = "1.0"
 servo_arc = { path = "../servo_arc" }
-servo_geometry = { path = "../geometry" }
 servo_url = { path = "../url" }
 style = { path = "../style", features = ["servo", "servo-layout-2020"] }
 style_traits = { path = "../style_traits" }
diff --git a/components/layout_thread/Cargo.toml b/components/layout_thread/Cargo.toml
@@ -45,7 +45,6 @@ servo_allocator = { path = "../allocator" }
 servo_arc = { path = "../servo_arc" }
 servo_atoms = { path = "../atoms" }
 servo_config = { path = "../config" }
-servo_geometry = { path = "../geometry" }
 servo_url = { path = "../url" }
 style = { path = "../style" }
 style_traits = { path = "../style_traits" }
diff --git a/components/layout_thread_2020/Cargo.toml b/components/layout_thread_2020/Cargo.toml
@@ -42,9 +42,7 @@ servo_allocator = { path = "../allocator" }
 servo_arc = { path = "../servo_arc" }
 servo_atoms = { path = "../atoms" }
 servo_config = { path = "../config" }
-servo_geometry = { path = "../geometry" }
 servo_url = { path = "../url" }
 style = { path = "../style" }
 style_traits = { path = "../style_traits" }
-time = "0.1.17"
 webrender_api = { git = "https://github.com/servo/webrender" }
diff --git a/components/layout_traits/Cargo.toml b/components/layout_traits/Cargo.toml
@@ -12,14 +12,12 @@ path = "lib.rs"
 
 [dependencies]
 crossbeam-channel = "0.4"
-euclid = "0.20"
 gfx = { path = "../gfx" }
 ipc-channel = "0.14"
 metrics = { path = "../metrics" }
 msg = { path = "../msg" }
 net_traits = { path = "../net_traits" }
 profile_traits = { path = "../profile_traits" }
 script_traits = { path = "../script_traits" }
-servo_geometry = { path = "../geometry" }
 servo_url = { path = "../url" }
 webrender_api = { git = "https://github.com/servo/webrender" }
diff --git a/components/msg/Cargo.toml b/components/msg/Cargo.toml
@@ -19,7 +19,6 @@ malloc_size_of = { path = "../malloc_size_of" }
 malloc_size_of_derive = "0.1"
 parking_lot = "0.10"
 serde = "1.0.60"
-servo_url = { path = "../url" }
 webrender_api = { git = "https://github.com/servo/webrender" }
 
 [dev-dependencies]
diff --git a/components/net/lib.rs b/components/net/lib.rs
@@ -44,3 +44,6 @@ pub mod test {
     pub use crate::hosts::{parse_hostsfile, replace_host_table};
     pub use crate::http_loader::HttpState;
 }
+
+// This dependency gives `build.rs` access to the `DEP_OPENSSL_VERSION_NUMBER` env variable.
+use openssl_sys as _;
diff --git a/components/profile/Cargo.toml b/components/profile/Cargo.toml
@@ -19,7 +19,6 @@ serde = "1.0"
 serde_json = "1.0"
 servo_config = {path = "../config"}
 time_crate = {package = "time", version = "0.1.12"}
-tokio = "0.1"
 
 [target.'cfg(target_os = "macos")'.dependencies]
 task_info = {path = "../../support/rust-task_info"}
diff --git a/components/profile_traits/Cargo.toml b/components/profile_traits/Cargo.toml
@@ -14,7 +14,6 @@ path = "lib.rs"
 energy-profiling = ["energymon", "energy-monitor"]
 
 [dependencies]
-bincode = "1"
 crossbeam-channel = "0.4"
 energy-monitor = {version = "0.2.0", optional = true}
 energymon = {git = "https://github.com/energymon/energymon-rust.git", optional = true}
diff --git a/components/script/Cargo.toml b/components/script/Cargo.toml
@@ -34,11 +34,9 @@ accountable-refcell = { version = "0.2.0", optional = true }
 app_units = "0.7"
 backtrace = { version = "0.3", optional = true }
 base64 = "0.10.1"
-bincode = "1"
 bitflags = "1.0"
 bluetooth_traits = { path = "../bluetooth_traits" }
 canvas_traits = { path = "../canvas_traits" }
-caseless = "0.2"
 chrono = "0.4"
 content-security-policy = { version = "0.4.0", features = ["serde"] }
 cookie = "0.11"
diff --git a/components/script_traits/Cargo.toml b/components/script_traits/Cargo.toml
@@ -40,7 +40,6 @@ servo_url = {path = "../url"}
 smallvec = "0.6"
 style_traits = {path = "../style_traits", features = ["servo"]}
 time = "0.1.12"
-url = "2.0"
 uuid = {version = "0.8", features = ["v4"]}
 webdriver = "0.40"
 webgpu = {path = "../webgpu"}
diff --git a/components/style/Cargo.toml b/components/style/Cargo.toml
@@ -16,7 +16,8 @@ path = "lib.rs"
 doctest = false
 
 [features]
-gecko = ["style_traits/gecko", "fallible/known_system_malloc", "bindgen", "regex", "toml"]
+gecko = ["style_traits/gecko", "fallible/known_system_malloc", "bindgen", "regex", "toml",
+         "num_cpus", "thin-slice"]
 servo = ["serde", "style_traits/servo", "servo_atoms", "servo_config", "html5ever",
          "cssparser/serde", "encoding_rs", "malloc_size_of/servo", "servo_url",
          "string_cache", "to_shmem/servo",
@@ -49,7 +50,7 @@ lazy_static = "1"
 log = { version = "0.4", features = ["std"] }
 malloc_size_of = { path = "../malloc_size_of" }
 malloc_size_of_derive = "0.1"
-num_cpus = {version = "1.1.0"}
+num_cpus = {version = "1.1.0", optional = true}
 num-integer = "0.1"
 num-traits = "0.2"
 num-derive = "0.3"
@@ -68,7 +69,7 @@ string_cache = { version = "0.8", optional = true }
 style_derive = {path = "../style_derive"}
 style_traits = {path = "../style_traits"}
 servo_url = {path = "../url", optional = true}
-thin-slice = "0.1.0"
+thin-slice = {version = "0.1.0", optional = true}
 to_shmem = {path = "../to_shmem"}
 to_shmem_derive = {path = "../to_shmem_derive"}
 time = "0.1"
diff --git a/components/webdriver_server/Cargo.toml b/components/webdriver_server/Cargo.toml
@@ -29,6 +29,5 @@ script_traits = {path = "../script_traits"}
 servo_config = {path = "../config"}
 servo_url = {path = "../url"}
 style_traits = {path = "../style_traits"}
-url = "2.0"
 uuid = {version = "0.8", features = ["v4"]}
 webdriver = "0.40"
diff --git a/components/webgpu/Cargo.toml b/components/webgpu/Cargo.toml
@@ -11,7 +11,6 @@ name = "webgpu"
 path = "lib.rs"
 
 [dependencies]
-embedder_traits = {path = "../embedder_traits"}
 ipc-channel = "0.14"
 log = "0.4"
 malloc_size_of = { path = "../malloc_size_of" }
diff --git a/components/webrender_traits/Cargo.toml b/components/webrender_traits/Cargo.toml
@@ -12,6 +12,5 @@ path = "lib.rs"
 
 [dependencies]
 euclid = "0.20"
-servo_geometry = {path = "../geometry"}
 webrender_api = {git = "https://github.com/servo/webrender"}
 
diff --git a/ports/gstplugin/Cargo.toml b/ports/gstplugin/Cargo.toml
@@ -17,7 +17,6 @@ path = "lib.rs"
 [dependencies]
 crossbeam-channel = "0.4"
 euclid = "0.20"
-gleam = "0.11"
 glib = "0.9"
 gstreamer = "0.15"
 gstreamer-base = "0.15"
diff --git a/ports/winit/Cargo.toml b/ports/winit/Cargo.toml
@@ -52,7 +52,6 @@ backtrace = "0.3"
 clipboard = "0.5"
 euclid = "0.20"
 getopts = "0.2.11"
-gleam = "0.11"
 keyboard-types = "0.4.3"
 lazy_static = "1"
 libc = "0.2"
@@ -63,7 +62,6 @@ shellwords = "1.0.0"
 surfman = { version = "0.2", features = ["sm-winit", "sm-x11"] }
 tinyfiledialogs = "3.0"
 webxr = { git = "https://github.com/servo/webxr", features = ["ipc", "glwindow", "headless"] }
-webxr-api = { git = "https://github.com/servo/webxr", features = ["ipc"] }
 winit = "0.19"
 
 [target.'cfg(any(target_os = "linux", target_os = "windows"))'.dependencies]

Original file line number	Diff line number	Diff line change
`@@ -44,3 +44,6 @@ pub mod test {`
`44`	`44`	`pub use crate::hosts::{parse_hostsfile, replace_host_table};`
`45`	`45`	`pub use crate::http_loader::HttpState;`
`46`	`46`	`}`
	`47`	`+`
	`48`	+// This dependency gives `build.rs` access to the `DEP_OPENSSL_VERSION_NUMBER` env variable.
	`49`	`+use openssl_sys as _;`