issues/200: support for Class files w/o location information (#202)

Author: fmck3516

skippy-core/src/main/java/io/skippy/core/Reason.java

@@ -45,11 +45,6 @@ public enum Category {
          */
         NO_IMPACT_DATA_FOUND_FOR_TEST,
 
-        /**
-         * Skippy was unable to obtain the location of the class file for the test.
-         */
-        CLASS_FILE_LOCATION_UNAVAILABLE,
-
         /**
          * Bytecode change in test detected.
          */

skippy-core/src/main/java/io/skippy/core/SkippyTestApi.java

@@ -22,17 +22,20 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Stack;
 import java.util.concurrent.ConcurrentHashMap;
 
+import static io.skippy.core.ClassUtil.getOutputFolder;
 import static io.skippy.core.JacocoUtil.mergeExecutionData;
 import static io.skippy.core.JacocoUtil.swallowJacocoExceptions;
 import static io.skippy.core.SkippyConstants.PREDICTIONS_LOG_FILE;
-import static io.skippy.core.ClassUtil.getOutputFolder;
 import static java.lang.System.lineSeparator;
-import static java.nio.file.StandardOpenOption.*;
+import static java.nio.file.StandardOpenOption.APPEND;
+import static java.nio.file.StandardOpenOption.CREATE;
 import static java.util.Arrays.asList;
-import static java.util.stream.Collectors.joining;
 
 /**
  * API that is used by Skippy's JUnit libraries to query for skip-or-execute predictions and to trigger the generation of .exec files.
@@ -114,6 +117,9 @@ private static SkippyTestApi getInstance() {
      * @param tag the {@link TestTag}
      */
     public void tagTest(Class<?> testClass, TestTag tag) {
+        if (false == ClassUtil.locationAvailable(testClass)) {
+            return;
+        }
         skippyRepository.tagTest(testClass, tag);
     }
 
@@ -125,6 +131,9 @@ public void tagTest(Class<?> testClass, TestTag tag) {
      */
     public boolean testNeedsToBeExecuted(Class<?> test) {
         return Profiler.profile("SkippyTestApi#testNeedsToBeExecuted", () -> {
+            if (false == ClassUtil.locationAvailable(test)) {
+                return true;
+            }
             try {
                 // re-use prediction made for the first test method in a class for all subsequent test methods
                 if (predictions.containsKey(test)) {
@@ -179,6 +188,9 @@ public boolean testNeedsToBeExecuted(Class<?> test) {
      */
     public void before(Class<?> testClass, String testMethod) {
         Profiler.profile("SkippyTestApi#prepareExecFileGeneration", () -> {
+            if (false == ClassUtil.locationAvailable(testClass)) {
+                return;
+            }
             swallowJacocoExceptions(() -> {
                 IAgent agent = RT.getAgent();
                 agent.reset();
@@ -193,6 +205,9 @@ public void before(Class<?> testClass, String testMethod) {
      */
     public void beforeAll(Class<?> testClass) {
         Profiler.profile("SkippyTestApi#prepareExecFileGeneration", () -> {
+            if (false == ClassUtil.locationAvailable(testClass)) {
+                return;
+            }
             swallowJacocoExceptions(() -> {
                 IAgent agent = RT.getAgent();
                 if (isNestedTest()) {
@@ -214,6 +229,9 @@ public void beforeAll(Class<?> testClass) {
      */
     public void after(Class<?> testClass, String testMethod) {
         Profiler.profile("SkippyTestApi#after", () -> {
+            if (false == ClassUtil.locationAvailable(testClass)) {
+                return;
+            }
             swallowJacocoExceptions(() -> {
                 IAgent agent = RT.getAgent();
                 skippyRepository.after(testClass, testMethod, agent.getExecutionData(true));
@@ -228,6 +246,9 @@ public void after(Class<?> testClass, String testMethod) {
      */
     public void afterAll(Class<?> testClass) {
         Profiler.profile("SkippyTestApi#afterAll", () -> {
+            if (false == ClassUtil.locationAvailable(testClass)) {
+                return;
+            }
             swallowJacocoExceptions(() -> {
                 IAgent agent = RT.getAgent();
                 var executionData = executionDataStack.lastElement();

skippy-core/src/main/java/io/skippy/core/TestImpactAnalysis.java

@@ -139,10 +139,6 @@ PredictionWithReason predict(Class<?> testClazz, SkippyConfiguration configurati
                 }
                 var maybeAnalyzedTest = classFileContainer.getAnalyzedTestForTestClass(testClazz, analyzedTests);
 
-                if (false == ClassUtil.locationAvailable(testClazz)) {
-                    return PredictionWithReason.execute(new Reason(CLASS_FILE_LOCATION_UNAVAILABLE, Optional.empty()));
-                }
-
                 if (maybeAnalyzedTest.isEmpty()) {
                     return PredictionWithReason.execute(new Reason(NO_IMPACT_DATA_FOUND_FOR_TEST, Optional.empty()));
                 }

skippy-core/src/test/java/io/skippy/core/TestImpactAnalysisPredictTest.java

@@ -19,11 +19,6 @@
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 
-
-import java.io.IOException;
-import java.net.URISyntaxException;
-import java.nio.file.Files;
-import java.nio.file.Path;
 import java.util.Optional;
 
 import static io.skippy.core.Prediction.EXECUTE;
@@ -46,43 +41,6 @@ void testNoTestImpactAnalysisFound() throws ClassNotFoundException {
             assertEquals(TEST_IMPACT_ANALYSIS_NOT_FOUND, predictionWithReason.reason().category());
         }
 
-        @Test
-        void testTestClassWithoutLocationInformation() throws ClassNotFoundException, URISyntaxException, IOException {
-            var testImpactAnalysis = TestImpactAnalysis.parse("""
-            {
-                "classes": {
-                    "0": {
-                        "name": "com.example.LeftPadderTest",
-                        "path": "com/example/LeftPadderTest.class",
-                        "outputFolder": "build/classes/java/test",
-                        "hash": "80E52EBA"
-                    }
-                },
-                "tests": [
-                    {
-                        "class": "0",
-                        "tags": ["PASSED"],
-                        "coveredClasses": ["0"]
-                    }
-                ]
-            }
-            """);
-            var location = Class.forName("com.example.LeftPadderTest").getProtectionDomain().getCodeSource().getLocation();
-            var pathToClassFile = Path.of(location.toURI()).resolve("com").resolve("example").resolve("LeftPadderTest.class");
-
-            class ByteArrayClassLoader extends ClassLoader {
-                public Class<?> loadClassFromBytes(String className, byte[] classBytes) {
-                    return defineClass(className, classBytes, 0, classBytes.length);
-                }
-            }
-
-            var testClass = new ByteArrayClassLoader().loadClassFromBytes("com.example.LeftPadderTest", Files.readAllBytes(pathToClassFile));
-
-            var predictionWithReason = testImpactAnalysis.predict(testClass, SkippyConfiguration.DEFAULT, SkippyRepository.getInstance(SkippyConfiguration.DEFAULT));
-            assertEquals(EXECUTE, predictionWithReason.prediction());
-            assertEquals(CLASS_FILE_LOCATION_UNAVAILABLE, predictionWithReason.reason().category());
-        }
-
         @Test
         void testPredictNoChange() throws ClassNotFoundException {
             var testImpactAnalysis = TestImpactAnalysis.parse("""