Hard forked at https://github.com/hazendaz/sitemesh2 - do we want to sync up?

[hazendaz]

Hi, I see this is coming back to life. I had hard-forked this over at https://github.com/hazendaz/sitemesh2. I used Maven for it and applied nearly everything that was at issue and subsequently released jakarta. I didn't do the same with sitemesh3 as I couldn't ever get it working for my needs. I auto licensed, auto formatted, and did a heavy cleanup clearing any coding issues in general. Its clearly not in a state to merge back but wanted to note this in case that is a consideration. I see this went gradle but its still early...

At the moment, I have it released both as javaEE and jakartaEE

JavaEE -> https://search.maven.org/artifact/com.github.hazendaz/sitemesh/2.5.1/jar
JakartaEE -> https://search.maven.org/artifact/com.github.hazendaz/sitemesh/2.6.0-M1/jar

The javaEE fork is used live in production already. The jarkartaEE while available and others might be using it, I have not released psi-probe on that yet as I ran into some considerations separately with more tomcat work to be done. Hence its marking as M1. It does however work.

[codeconsole]

Hi @hazendaz,

We definitely appreciate your effort. Thanks for taking such an interest in sitemesh! We would love to sync up with you. Probably best at this point is if we migrate to the maven style folder structure you have prior to looking to do that.

Other than that, I think the only complication on the merge would be the work done on DefaultFactory.java
I've cleaned that up a bit. It seemed like it was a bit buggy on how it handled things and never even bothered to set excludesFile

[codeconsole]

Hi @hazendaz,

So the plan is to merge in https://github.com/sitemesh/sitemesh2/compare/atlassian prior to looking at this since it is the same folder structure. Hoping to get this done this week.

[codeconsole]

Hi @hazendaz

So I think the folder structures are more inline now. We would be open to any pull requests and even have you involved with the main project. I believe the only issue with syncing the work you have done is your replacement of the copyright notice. We would need to maintain existing copyright and also would like to maintain existing formatting on unmodified code blocks.

Let me know what you think.

[hazendaz]

Hi @codeconsole, sorry for late response. I'm not sure if the effort will be worthwhile to try to bring these together. I don't like gradle and see you guys went full on gradle (which is fine). I've got my copy on maven. I forget if originally was ant or something. I further used Eclipse to do a full source cleanup, used error prone and other tools to cleanup code issues, and auto formatted everything so the code isn't really going to match up at this point. I presumed this was not going anywhere long back and just decided to move on. I only use this in exactly one project and reality is that if I had the expertise for angular or react, I would gut all the legacy stuff out of it including this and just retire the codebase. I also think maybe figuring out sitemesh3 would have been a better option but I was stuck there not figuring it out so I had given up and sticking the course seemed the easiest until someday I learn those more modern frameworks as I certainly would stop using JSP that is pervasive in the use case I have.

That all said, do you have a strong opinion of this staying split or needing to come together? I don't have a lot of time generally and I presume most are the same. While it would long term make sense, just not sure how much effort we all want to put into it. Anyway let me know.

[codeconsole]

Hi @hazendaz, it's really up to you. If you feel like you might have time at some point, you could submit a pull request with any changes you find valuable or necessary. At that point we could add you to the Sitemesh organization so you can pursue updates directly without having to wait for a response from anyone.