[REFACTOR] [Hacker Rank] Interview Preparation Kit: Dictionaries and Hashmaps: Two Strings.

* TEST data moved to JSON.
* Adjusted the interface to match what hackerrank expects.

Author: sir-gon

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/two_strings.js

@@ -5,7 +5,7 @@
 const __YES__ = 'YES';
 const __NO__ = 'NO';
 
-export function twoStringsCompute(s1, s2) {
+function twoStringsCompute(s1, s2) {
   for (const char of s1) {
     if (s2.includes(char)) {
       return true;
@@ -14,7 +14,7 @@ export function twoStringsCompute(s1, s2) {
   return false;
 }
 
-export function twoStrings(s1, s2) {
+function twoStrings(s1, s2) {
   return twoStringsCompute(s1, s2) ? __YES__ : __NO__;
 }
 

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/two_strings.test.js

@@ -1,73 +1,16 @@
 import { describe, expect, it } from '@jest/globals';
 import { logger as console } from '../../../logger.js';
 
-import { twoStrings } from './two_strings.js';
-
-const TEST_CASES = [
-  {
-    title: 'Example 1 and 2',
-    comparing: [
-      {
-        s1: 'and',
-        s2: 'art',
-        expected: 'YES'
-      },
-      {
-        s1: 'be',
-        s2: 'cat',
-        expected: 'NO'
-      }
-    ]
-  },
-  {
-    title: 'Sample Test Case 0',
-    comparing: [
-      {
-        s1: 'hello',
-        s2: 'world',
-        expected: 'YES'
-      },
-      {
-        s1: 'hi',
-        s2: 'world',
-        expected: 'NO'
-      }
-    ]
-  },
-  {
-    title: 'Sample Test Case 6',
-    comparing: [
-      {
-        s1: 'wouldyoulikefries',
-        s2: 'abcabcabcabcabcabc',
-        expected: 'NO'
-      },
-      {
-        s1: 'hackerrankcommunity',
-        s2: 'cdecdecdecde',
-        expected: 'YES'
-      },
-      {
-        s1: 'jackandjill',
-        s2: 'wentupthehill',
-        expected: 'YES'
-      },
-      {
-        s1: 'writetoyourparents',
-        s2: 'fghmqzldbc',
-        expected: 'NO'
-      }
-    ]
-  }
-];
+import twoStrings from './two_strings.js';
+import TEST_CASES from './two_strings.testcases.json';
 
 describe('two_strings', () => {
   it('twoStrings test cases', () => {
     expect.assertions(8);
 
     TEST_CASES.forEach((testCase) => {
-      testCase.comparing.forEach((test) => {
-        const answer = twoStrings(test.s1, test.s2);
+      testCase.tests.forEach((test) => {
+        const answer = twoStrings.twoStrings(test.s1, test.s2);
 
         console.debug(
           `twoStrings(${test.s1}, ${test.s2}) solution found: ${answer}`

src/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/two_strings.testcases.json

@@ -0,0 +1,57 @@
+[
+  {
+    "title": "Example 1 and 2",
+    "tests": [
+      {
+        "s1": "and",
+        "s2": "art",
+        "expected": "YES"
+      },
+      {
+        "s1": "be",
+        "s2": "cat",
+        "expected": "NO"
+      }
+    ]
+  },
+  {
+    "title": "Sample Test Case 0",
+    "tests": [
+      {
+        "s1": "hello",
+        "s2": "world",
+        "expected": "YES"
+      },
+      {
+        "s1": "hi",
+        "s2": "world",
+        "expected": "NO"
+      }
+    ]
+  },
+  {
+    "title": "Sample Test Case 6",
+    "tests": [
+      {
+        "s1": "wouldyoulikefries",
+        "s2": "abcabcabcabcabcabc",
+        "expected": "NO"
+      },
+      {
+        "s1": "hackerrankcommunity",
+        "s2": "cdecdecdecde",
+        "expected": "YES"
+      },
+      {
+        "s1": "jackandjill",
+        "s2": "wentupthehill",
+        "expected": "YES"
+      },
+      {
+        "s1": "writetoyourparents",
+        "s2": "fghmqzldbc",
+        "expected": "NO"
+      }
+    ]
+  }
+]