Merge pull request #653 from sir-gon/refactor

Refactor

Author: sir-gon

src/hackerrank/implementation/betweenTwoSets.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/implementation/betweenTwoSets.md]]
  */
 
-export function isFactor(n, group) {
+function isFactor(n, group) {
   let result = true;
   let i = 0;
 
@@ -19,7 +19,7 @@ export function isFactor(n, group) {
   return result;
 }
 
-export function factorOf(n, group) {
+function factorOf(n, group) {
   let result = true;
   let i = 0;
 
@@ -36,7 +36,7 @@ export function factorOf(n, group) {
   return result;
 }
 
-export function getTotalX(a, b) {
+function getTotalX(a, b) {
   let max = 0;
   for (const j of b) {
     if (j > max) max = j;
@@ -53,4 +53,5 @@ export function getTotalX(a, b) {
   return result.length;
 }
 
-export default { getTotalX };
+export default { getTotalX, isFactor, factorOf };
+export { getTotalX, isFactor, factorOf };

src/hackerrank/implementation/birthday.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function birthday(s, d, m) {
+function birthday(s, d, m) {
   let result = 0;
   console.debug(`s: ${s}`);
 
@@ -23,3 +23,4 @@ export function birthday(s, d, m) {
 }
 
 export default { birthday };
+export { birthday };

src/hackerrank/implementation/bonAppetit.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function bonAppetit(bill, k, b) {
+function bonAppetit(bill, k, b) {
   const totalSum = bill.reduce(
     (previousValue, currentValue) => previousValue + currentValue,
     0
@@ -25,3 +25,4 @@ export function bonAppetit(bill, k, b) {
 }
 
 export default { bonAppetit };
+export { bonAppetit };

src/hackerrank/implementation/breakingRecords.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/implementation/breakingRecords.md]]
  */
 
-export function breakingRecords(scores) {
+function breakingRecords(scores) {
   if (scores.length === 0) {
     throw new Error('Empty input');
   }
@@ -29,3 +29,4 @@ export function breakingRecords(scores) {
 }
 
 export default { breakingRecords };
+export { breakingRecords };

src/hackerrank/implementation/countApplesAndOranges.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/implementation/countApplesAndOranges.md]]
  */
 
-export function countApplesAndOranges(s, t, a, b, apples, oranges) {
+function countApplesAndOranges(s, t, a, b, apples, oranges) {
   let cApples = 0;
   let cOranges = 0;
 
@@ -26,3 +26,4 @@ export function countApplesAndOranges(s, t, a, b, apples, oranges) {
 }
 
 export default { countApplesAndOranges };
+export { countApplesAndOranges };

src/hackerrank/implementation/countingValleys.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function countingValleys(steps, path) {
+function countingValleys(steps, path) {
   const stepList = path.split('');
   let altitude = 0;
   let valleys = 0;
@@ -27,3 +27,4 @@ export function countingValleys(steps, path) {
 }
 
 export default { countingValleys };
+export { countingValleys };

src/hackerrank/implementation/dayOfProgrammer.js

@@ -7,7 +7,7 @@ import { daysInMonthNumber } from '../../constants/index.js';
 
 const zeroPad = (num, places) => String(num).padStart(places, '0');
 
-export function dayOfProgrammer(year) {
+function dayOfProgrammer(year) {
   const dayToSearch = 256;
   let leap;
 
@@ -51,3 +51,4 @@ export function dayOfProgrammer(year) {
 }
 
 export default { dayOfProgrammer };
+export { dayOfProgrammer };

src/hackerrank/implementation/divisibleSumPairs.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function divisibleSumPairs(n, k, ar) {
+function divisibleSumPairs(n, k, ar) {
   let pairs = 0;
   for (let i = 0; i < ar.length; i++) {
     for (let j = i + 1; j < ar.length; j++) {
@@ -19,3 +19,4 @@ export function divisibleSumPairs(n, k, ar) {
 }
 
 export default { divisibleSumPairs };
+export { divisibleSumPairs };

src/hackerrank/implementation/gradingStudents.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/implementation/gradingStudents.md]]
  */
 
-export function gradingStudents(grades) {
+function gradingStudents(grades) {
   const minimum = 38;
   const roundTo = 5;
   const result = [];
@@ -23,3 +23,4 @@ export function gradingStudents(grades) {
 }
 
 export default { gradingStudents };
+export { gradingStudents };

src/hackerrank/implementation/jumpingOnClouds.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function jumpingOnClouds(c) {
+function jumpingOnClouds(c) {
   let result = 0;
   let key = 0;
 
@@ -26,3 +26,4 @@ export function jumpingOnClouds(c) {
 }
 
 export default { jumpingOnClouds };
+export { jumpingOnClouds };

src/hackerrank/implementation/kangaroo.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/implementation/kangaroo.md]]
  */
 
-export function kangaroo(x1, v1, x2, v2) {
+function kangaroo(x1, v1, x2, v2) {
   if (v1 === v2) {
     if (x1 !== x2) return 'NO';
     return 'YES';
@@ -18,3 +18,4 @@ export function kangaroo(x1, v1, x2, v2) {
 }
 
 export default { kangaroo };
+export { kangaroo };

src/hackerrank/implementation/migratoryBirds.js

@@ -5,7 +5,7 @@
 import util from 'util';
 import { logger as console } from '../../logger.js';
 
-export function migratoryBirds(arr) {
+function migratoryBirds(arr) {
   if (arr.length === 0) {
     throw new Error('Empty input');
   }
@@ -35,3 +35,4 @@ export function migratoryBirds(arr) {
 }
 
 export default { migratoryBirds };
+export { migratoryBirds };

src/hackerrank/implementation/minimumAbsoluteDifference.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function minimumAbsoluteDifference(arr) {
+function minimumAbsoluteDifference(arr) {
   if (arr.length === 0) {
     throw new Error('Empty input');
   }
@@ -31,3 +31,4 @@ export function minimumAbsoluteDifference(arr) {
 }
 
 export default { minimumAbsoluteDifference };
+export { minimumAbsoluteDifference };

src/hackerrank/implementation/repeatedString.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function countAs(word) {
+function countAs(word) {
   let result = 0;
 
   const chars = word.split('');
@@ -18,7 +18,7 @@ export function countAs(word) {
   return result;
 }
 
-export function repeatedString(s, n) {
+function repeatedString(s, n) {
   let result = 0;
 
   const blockSize = s.length;
@@ -32,4 +32,5 @@ export function repeatedString(s, n) {
   return result;
 }
 
-export default { countAs };
+export default { repeatedString };
+export { repeatedString };

src/hackerrank/implementation/sockMerchant.js

@@ -4,7 +4,7 @@
 
 import { logger as console } from '../../logger.js';
 
-export function sockMerchant(n, ar) {
+function sockMerchant(n, ar) {
   let result = 0;
 
   const matches = {};
@@ -25,3 +25,4 @@ export function sockMerchant(n, ar) {
 }
 
 export default { sockMerchant };
+export { sockMerchant };

src/hackerrank/interview_preparation_kit/arrays/2d_array.js

@@ -58,3 +58,4 @@ function hourglassSum(arr) {
 }
 
 export default { hourglassSum };
+export { hourglassSum };

src/hackerrank/interview_preparation_kit/arrays/2d_array.test.js

@@ -1,15 +1,15 @@
 import { describe, expect, it } from '@jest/globals';
 import { logger as console } from '../../../logger.js';
 
-import twoDArray from './2d_array.js';
+import { hourglassSum } from './2d_array.js';
 import TEST_CASES from './2d_array.testcases_test.json';
 
 describe('arrays: 2d Array hourglassSum', () => {
   it('hourglassSum Test Cases', () => {
     expect.assertions(3);
 
     TEST_CASES.forEach((test) => {
-      const answer = twoDArray.hourglassSum(test.input);
+      const answer = hourglassSum(test.input);
 
       console.debug(
         `gethourGlass(${test.input.toString()}) solution found: ${answer}`

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.js

@@ -29,3 +29,4 @@ function arrayManipulation(n, queries) {
 }
 
 export default { arrayManipulation };
+export { arrayManipulation };

src/hackerrank/interview_preparation_kit/arrays/cruch_bruteforce.test.js

@@ -3,14 +3,14 @@ import { logger as console } from '../../../logger.js';
 
 import TEST_CASES from './cruch_testcases_test.json';
 
-import crush from './cruch_bruteforce.js';
+import { arrayManipulation } from './cruch_bruteforce.js';
 
 describe('arrays: crush (bruteforce) small cases', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(3);
 
     TEST_CASES.forEach((test) => {
-      const answer = crush.arrayManipulation(test.n, test.queries);
+      const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries}) solution found: ${answer}`

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.js

@@ -29,3 +29,4 @@ function arrayManipulation(n, queries) {
 }
 
 export default { arrayManipulation };
+export { arrayManipulation };

src/hackerrank/interview_preparation_kit/arrays/cruch_optimized.test.js

@@ -3,14 +3,14 @@ import { logger as console } from '../../../logger.js';
 
 import TEST_CASES from './cruch_testcases_test.json';
 
-import crush from './cruch_optimized.js';
+import { arrayManipulation } from './cruch_optimized.js';
 
 describe('arrays: crush (optimized)', () => {
   it('arrayManipulation Test Cases', () => {
     expect.assertions(3);
 
     TEST_CASES.forEach((test) => {
-      const answer = crush.arrayManipulation(test.n, test.queries);
+      const answer = arrayManipulation(test.n, test.queries);
 
       console.debug(
         `arrayManipulation(${test.n}, ${test.queries}) solution found: ${answer}`

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.js

@@ -2,7 +2,7 @@
  * @link Problem definition [[docs/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.md]]
  */
 
-export function rotLeftOne(aNumbers) {
+function rotLeftOne(aNumbers) {
   const first = aNumbers.shift();
   if (first !== undefined) {
     aNumbers.push(first);
@@ -11,7 +11,7 @@ export function rotLeftOne(aNumbers) {
   return aNumbers;
 }
 
-export function rotLeft(aNumbers, dRotations) {
+function rotLeft(aNumbers, dRotations) {
   let output = [...aNumbers];
 
   for (let i = 0; i < dRotations; i++) {
@@ -22,3 +22,4 @@ export function rotLeft(aNumbers, dRotations) {
 }
 
 export default { rotLeft, rotLeftOne };
+export { rotLeft };

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.test.js

@@ -1,42 +1,20 @@
 import { describe, expect, it } from '@jest/globals';
 import { logger as console } from '../../../logger.js';
 
-import { rotLeft, rotLeftOne } from './ctci_array_left_rotation.js';
+import { rotLeft } from './ctci_array_left_rotation.js';
 
-const ROT_LEFT_ONE_TEST_CASES = [
-  { numbers: [1, 2, 3, 4, 5], expected: [2, 3, 4, 5, 1] },
-  { numbers: [2, 3, 4, 5, 1], expected: [3, 4, 5, 1, 2] },
-  { numbers: [3, 4, 5, 1, 2], expected: [4, 5, 1, 2, 3] },
-  { numbers: [4, 5, 1, 2, 3], expected: [5, 1, 2, 3, 4] },
-  { numbers: [5, 1, 2, 3, 4], expected: [1, 2, 3, 4, 5] }
-];
-
-const ROT_LEFT_TEST_CASES = [
-  { numbers: [1, 2, 3, 4, 5], d_rotations: 4, expected: [5, 1, 2, 3, 4] }
-];
+import ROT_LEFT_TEST_CASES from './ctci_array_left_rotation.testcases.json';
 
 describe('ctci_array_left_rotation', () => {
-  it('rotLeftOne Test Cases', () => {
-    expect.assertions(5);
-
-    ROT_LEFT_ONE_TEST_CASES.forEach((value) => {
-      const answer = rotLeftOne(value.numbers);
-
-      console.debug(`rotLeftOne(${value.numbers}) solution found: ${answer}`);
-
-      expect(answer).toStrictEqual(value.expected);
-    });
-  });
-
   it('rotLeft Test cases', () => {
-    expect.assertions(1);
+    expect.assertions(8);
 
-    ROT_LEFT_TEST_CASES.forEach((value) => {
-      const answer = rotLeft(value.numbers, value.d_rotations);
+    ROT_LEFT_TEST_CASES.forEach((test) => {
+      const answer = rotLeft(test.input, test.d_rotations);
 
-      console.debug(`rotLeft(${value.numbers}) solution found: ${answer}`);
+      console.debug(`rotLeft(${test.numbers}) solution found: ${answer}`);
 
-      expect(answer).toStrictEqual(value.expected);
+      expect(answer).toStrictEqual(test.expected);
     });
   });
 });

src/hackerrank/interview_preparation_kit/arrays/ctci_array_left_rotation.testcases.json

@@ -0,0 +1,10 @@
+[
+  {"title": "Own 0", "input": [1, 2, 3, 4, 5], "d_rotations": 1, "expected": [2, 3, 4, 5, 1]},
+  {"title": "Own 1", "input": [2, 3, 4, 5, 1], "d_rotations": 1, "expected": [3, 4, 5, 1, 2]},
+  {"title": "Own 2", "input": [3, 4, 5, 1, 2], "d_rotations": 1, "expected": [4, 5, 1, 2, 3]},
+  {"title": "Own 3", "input": [4, 5, 1, 2, 3], "d_rotations": 1, "expected": [5, 1, 2, 3, 4]},
+  {"title": "Own 4", "input": [5, 1, 2, 3, 4], "d_rotations": 1, "expected": [1, 2, 3, 4, 5]},
+  {"title": "Sample Test case 0", "input": [1, 2, 3, 4, 5], "d_rotations": 4, "expected": [5, 1, 2, 3, 4]},
+  {"title": "Sample Test case 1", "input": [41, 73, 89, 7, 10, 1, 59, 58, 84, 77, 77, 97, 58, 1, 86, 58, 26, 10, 86, 51], "d_rotations": 10, "expected": [77, 97, 58, 1, 86, 58, 26, 10, 86, 51, 41, 73, 89, 7, 10, 1, 59, 58, 84, 77]},
+  {"title": "Sample Test case 2", "input": [33, 47, 70, 37, 8, 53, 13, 93, 71, 72, 51, 100, 60, 87, 97], "d_rotations": 13, "expected": [87, 97, 33, 47, 70, 37, 8, 53, 13, 93, 71, 72, 51, 100, 60]}
+]