From 717511ed1b40f5ca40e8e801cea2f3b0c1133b3a Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Fri, 24 May 2024 23:20:09 -0400 Subject: [PATCH] [REFACTOR] [Hacker Rank] Tests messages rewritten. --- .../ae/hackerrank/CompareTripletsTest.java | 28 ++++++++----- .../ae/hackerrank/DiagonalDifferenceTest.java | 40 +++++++++++++++---- .../java/ae/hackerrank/MiniMaxSumTest.java | 8 ++-- .../ae/hackerrank/SimpleArraySumTest.java | 5 ++- .../java/ae/hackerrank/SolveMeFirstTest.java | 2 +- .../java/ae/hackerrank/VeryBigSumTest.java | 2 +- 6 files changed, 62 insertions(+), 23 deletions(-) diff --git a/algorithm-exercises-java/src/test/java/ae/hackerrank/CompareTripletsTest.java b/algorithm-exercises-java/src/test/java/ae/hackerrank/CompareTripletsTest.java index 8c84981..d8fe430 100644 --- a/algorithm-exercises-java/src/test/java/ae/hackerrank/CompareTripletsTest.java +++ b/algorithm-exercises-java/src/test/java/ae/hackerrank/CompareTripletsTest.java @@ -4,9 +4,13 @@ import java.util.Arrays; import java.util.List; +import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInstance; +import org.junit.jupiter.api.TestInstance.Lifecycle; +@TestInstance(Lifecycle.PER_CLASS) class CompareTripletsTest { public class CompareTripletsTestCase { @@ -21,24 +25,28 @@ public CompareTripletsTestCase(List _la, List _lb, List testCases; - CompareTripletsTestCase[] testCases = { + @BeforeAll + public void setup() { + this.testCases = Arrays.asList( new CompareTripletsTestCase( Arrays.asList(5, 6, 7), Arrays.asList(3, 6, 10), - Arrays.asList(1, 1) - ) - }; + Arrays.asList(1, 1)) + ); + } - for (CompareTripletsTestCase testCase : testCases) { + @Test void testCompareTriplets() { + for (CompareTripletsTestCase testCase : this.testCases) { List solutionFound = CompareTriplets.compareTriplets(testCase.la, testCase.lb); assertEquals(testCase.expected, solutionFound, - String.format( - "CompareTriplets.compareTriplets() answer must be: %s", - testCase.expected.toString() - ) + String.format("%s(%s, %s) answer must be: %s", + "CompareTriplets.compareTriplets", + testCase.la.toString(), + testCase.lb.toString(), + testCase.expected.toString()) ); } } diff --git a/algorithm-exercises-java/src/test/java/ae/hackerrank/DiagonalDifferenceTest.java b/algorithm-exercises-java/src/test/java/ae/hackerrank/DiagonalDifferenceTest.java index 9297b98..e3989f4 100644 --- a/algorithm-exercises-java/src/test/java/ae/hackerrank/DiagonalDifferenceTest.java +++ b/algorithm-exercises-java/src/test/java/ae/hackerrank/DiagonalDifferenceTest.java @@ -4,23 +4,49 @@ import java.util.Arrays; import java.util.List; +import org.junit.jupiter.api.BeforeAll; import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestInstance; +import org.junit.jupiter.api.TestInstance.Lifecycle; +@TestInstance(Lifecycle.PER_CLASS) class DiagonalDifferenceTest { - @Test void testDiagonalDifference() { + public class DiagonalDifferenceTestCase { + public List> matrix; + public Integer expected; + + public DiagonalDifferenceTestCase(List> _input, int _expected) { + this.matrix = _input; + this.expected = _expected; + } + } - List> matrix = Arrays.asList( + public List testCases; + + @BeforeAll + public void setup() { + this.testCases = Arrays.asList( + new DiagonalDifferenceTestCase(Arrays.asList( Arrays.asList(11, 2, 4), Arrays.asList(4, 5, 6), Arrays.asList(10, 8, -12) + ), 15) ); - Integer expected = 15; - Integer resultFound = DiagonalDifference.diagonalDifference(matrix); + } - assertEquals(expected, resultFound, - String.format("DiagonalDifference.diagonalDifference answer must be: %d", expected) - ); + @Test void testDiagonalDifference() { + + for (DiagonalDifferenceTestCase testCase : this.testCases) { + Integer resultFound = DiagonalDifference.diagonalDifference(testCase.matrix); + + assertEquals(testCase.expected, resultFound, + String.format("%s(%s) answer must be: %s", + "MiniMaxSum.miniMaxSum", + testCase.matrix.toString(), + testCase.expected.toString()) + ); + } } } diff --git a/algorithm-exercises-java/src/test/java/ae/hackerrank/MiniMaxSumTest.java b/algorithm-exercises-java/src/test/java/ae/hackerrank/MiniMaxSumTest.java index b66e94b..d82392b 100644 --- a/algorithm-exercises-java/src/test/java/ae/hackerrank/MiniMaxSumTest.java +++ b/algorithm-exercises-java/src/test/java/ae/hackerrank/MiniMaxSumTest.java @@ -41,9 +41,11 @@ void testMiniMaxSum() { String solutionFound = MiniMaxSum.miniMaxSum(testCase.input); assertEquals(testCase.expected, solutionFound, - String.format( - "CompareTriplets.compareTriplets() answer must be: %s", - testCase.expected.toString())); + String.format("%s(%s) answer must be: %s", + "MiniMaxSum.miniMaxSum", + testCase.input.toString(), + testCase.expected.toString()) + ); } } diff --git a/algorithm-exercises-java/src/test/java/ae/hackerrank/SimpleArraySumTest.java b/algorithm-exercises-java/src/test/java/ae/hackerrank/SimpleArraySumTest.java index 8244b94..a836185 100644 --- a/algorithm-exercises-java/src/test/java/ae/hackerrank/SimpleArraySumTest.java +++ b/algorithm-exercises-java/src/test/java/ae/hackerrank/SimpleArraySumTest.java @@ -17,7 +17,10 @@ class SimpleArraySumTest { Integer solutionFound = SimpleArraySum.simpleArraySum(ar); assertEquals(answer, solutionFound, - String.format("Problem 0000 answer must be: %d", answer) + String.format("%s(%s) answer must be: %d", + "SimpleArraySum.simpleArraySum", + ar.toString(), + answer) ); } } diff --git a/algorithm-exercises-java/src/test/java/ae/hackerrank/SolveMeFirstTest.java b/algorithm-exercises-java/src/test/java/ae/hackerrank/SolveMeFirstTest.java index 10fd508..f218c86 100644 --- a/algorithm-exercises-java/src/test/java/ae/hackerrank/SolveMeFirstTest.java +++ b/algorithm-exercises-java/src/test/java/ae/hackerrank/SolveMeFirstTest.java @@ -16,7 +16,7 @@ class SolveMeFirstTest { Integer solutionFound = SolveMeFirst.solveMeFirst(a, b); assertEquals(answer, solutionFound, - String.format("Problem 0000 answer must be: %d", answer) + String.format("%s(%d, %d) answer must be: %d", "SolveMeFirst.solveMeFirst", a, b, answer) ); } } diff --git a/algorithm-exercises-java/src/test/java/ae/hackerrank/VeryBigSumTest.java b/algorithm-exercises-java/src/test/java/ae/hackerrank/VeryBigSumTest.java index 72239ae..d8b4e9e 100644 --- a/algorithm-exercises-java/src/test/java/ae/hackerrank/VeryBigSumTest.java +++ b/algorithm-exercises-java/src/test/java/ae/hackerrank/VeryBigSumTest.java @@ -17,7 +17,7 @@ class VeryBigSumTest { Long solutionFound = VeryBigSum.aVeryBigSum(arr); assertEquals(answer, solutionFound, - String.format("Problem 0000 answer must be: %d", answer) + String.format("%s(%s) answer must be: %d", "VeryBigSum.aVeryBigSum", arr.toString(), answer) ); } }