From 0b3339052c01a423b2111c59dc2d16db0b1969f0 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 20 May 2024 16:02:38 -0400 Subject: [PATCH 1/6] [BUGFIX] sonarcloud: This block of commented-out lines of code should be removed. Sections of code should not be commented out java:S125 --- algorithm-exercises-java/src/test/java/ae/Problem0000Test.java | 1 - 1 file changed, 1 deletion(-) diff --git a/algorithm-exercises-java/src/test/java/ae/Problem0000Test.java b/algorithm-exercises-java/src/test/java/ae/Problem0000Test.java index 2c05b2e..df2d2eb 100644 --- a/algorithm-exercises-java/src/test/java/ae/Problem0000Test.java +++ b/algorithm-exercises-java/src/test/java/ae/Problem0000Test.java @@ -10,7 +10,6 @@ class Problem0000Test { @Test void problem0000() { Integer answer = null; - // Integer input = 0; Integer solutionFound = Problem0000.problem0000(); assertEquals(answer, solutionFound, From 9d9b2c5d8cd671950271d98e8c616070da0a9f8e Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 20 May 2024 16:11:20 -0400 Subject: [PATCH 2/6] [BUGFIX] sonarcloud: Looks like there is a confusion with the use of java.text.MessageFormat, parameters will be simply ignored here Format strings should be used correctly java:S3457 --- .../src/test/java/ae/projecteuler/Problem0023Test.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/algorithm-exercises-java/src/test/java/ae/projecteuler/Problem0023Test.java b/algorithm-exercises-java/src/test/java/ae/projecteuler/Problem0023Test.java index 779cdac..538eb26 100644 --- a/algorithm-exercises-java/src/test/java/ae/projecteuler/Problem0023Test.java +++ b/algorithm-exercises-java/src/test/java/ae/projecteuler/Problem0023Test.java @@ -22,7 +22,7 @@ void problem0023smallCase1( Integer solutionFound = Problem0023.problem0023(inputUnderLimit, inputSuperLimit); - String log = String.format("Problem 0023 {0} answer must be: {1}", testCase, answer); + String log = String.format("Problem 0023 %s answer must be: %d", testCase, answer); assertEquals(answer, solutionFound, log); } From 6d128e4761694ad612c0169984dbb109cbad1e5d Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 20 May 2024 16:12:48 -0400 Subject: [PATCH 3/6] [BUGFIX] sonarcloud: Remove this useless assignment to local variable "solutionFound". Unused assignments should be removed java:S1854 --- .../src/test/java/ae/projecteuler/helper/BigNumTest.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java index 0090ef2..e4de2ee 100644 --- a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java +++ b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java @@ -70,9 +70,6 @@ class BigNumTest { expectedAnswer, solutionFound.toArray() ); - - solutionFound = solutionFound.bigSum(new BigNum(6)); - } @Test void bigMultiplyRowToBigNumTest() { From 770ef6073a065274a7bf698490ee67895f8dd01c Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 20 May 2024 16:13:36 -0400 Subject: [PATCH 4/6] [BUGFIX] sonarcloud: Remove this useless assignment to local variable "solutionFound". Unused assignments should be removed java:S1854 --- .../src/test/java/ae/projecteuler/helper/BigNumTest.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java index e4de2ee..f6ebf97 100644 --- a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java +++ b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java @@ -99,8 +99,6 @@ class BigNumTest { new Integer[]{ 8, 9, 9, 1 }, BigNum.bigMultiplyRowToBigNum("999", 9).toArray() ); - solutionFound = solutionFound.bigSum(new BigNum(6)); - } @Test void bigMultiplyTest() { From 97e47b798d729e0abcf57674211aa57541cc5e96 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 20 May 2024 16:14:12 -0400 Subject: [PATCH 5/6] [BUGFIX] sonarcloud: This block of commented-out lines of code should be removed. Sections of code should not be commented out java:S125 --- .../java/ae/projecteuler/helper/PalindromeTest.java | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/PalindromeTest.java b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/PalindromeTest.java index 2c27c25..5763ce9 100644 --- a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/PalindromeTest.java +++ b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/PalindromeTest.java @@ -17,16 +17,6 @@ private class PalindromTestCase { } } - // @Test void instanceCaseTest() { - // Palindrome classUnderTest = new Palindrome(); - - // assertNotNull(classUnderTest); - // assertInstanceOf( - // Palindrome.class, - // classUnderTest, - // String.format("Must be an instance of %s", Palindrome.class)); - // } - @Test void listOfPalindromBorderCaseTest() { PalindromTestCase[] testCases = { @@ -37,6 +27,4 @@ private class PalindromTestCase { assertEquals(testCase.answer, Palindrome.isPalindrome(testCase.input)); } } - - } From 318e9f8cc5c26b2fc5505396e138c04344f336b0 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 20 May 2024 16:37:46 -0400 Subject: [PATCH 6/6] [REFACTOR] better coverage --- .../src/test/java/ae/projecteuler/helper/BigNumTest.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java index f6ebf97..381e4d9 100644 --- a/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java +++ b/algorithm-exercises-java/src/test/java/ae/projecteuler/helper/BigNumTest.java @@ -70,6 +70,14 @@ class BigNumTest { expectedAnswer, solutionFound.toArray() ); + + BigNum solutionFoundB = new BigNum(input); + solutionFoundB.bigSum(solutionFound); + + assertArrayEquals( + expectedAnswer, + solutionFoundB.toArray() + ); } @Test void bigMultiplyRowToBigNumTest() {