From 302054c777bf25df81143c2d505d3fc460a951f2 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Mon, 1 Jul 2024 20:51:32 -0400 Subject: [PATCH] [REFACTOR] test code de-duplication. Generic added. [REFACTOR] test code de-duplication. --- .../linked_list/LinkedListCycle.Test.cs | 18 +++++++++--------- .../linked_list/LinkedListCycle.cs | 6 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs index 1217508..7dbcced 100644 --- a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs +++ b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs @@ -6,7 +6,7 @@ public class LinkedListCycleTest class LinkedListCycleTestCase { public string title = ""; - public LinkedList.Node? llist; + public LinkedList.Node? llist; public bool expected; } @@ -16,11 +16,11 @@ class LinkedListCycleTestCase public void testInitialize() { // Linked list sample data: - LinkedList.Node ll1_1 = new(1); - LinkedList.Node ll1_2 = new(2); - LinkedList.Node ll1_3 = new(3); - LinkedList.Node ll1_4 = new(4); - LinkedList.Node ll1_5 = new(5); + LinkedList.Node ll1_1 = new("a"); + LinkedList.Node ll1_2 = new("b"); + LinkedList.Node ll1_3 = new("c"); + LinkedList.Node ll1_4 = new("d"); + LinkedList.Node ll1_5 = new("e"); ll1_1.next = ll1_2; ll1_2.next = ll1_3; @@ -28,9 +28,9 @@ public void testInitialize() ll1_4.next = ll1_5; ll1_4.next = ll1_3; // <- cycle - LinkedList.Node ll2_1 = new(1); - LinkedList.Node ll2_2 = new(2); - LinkedList.Node ll2_3 = new(3); + LinkedList.Node ll2_1 = new("a"); + LinkedList.Node ll2_2 = new("b"); + LinkedList.Node ll2_3 = new("c"); ll2_1.next = ll2_2; ll2_2.next = ll2_3; diff --git a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs index 6c703a2..4a40295 100644 --- a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs +++ b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs @@ -9,11 +9,11 @@ public class LinkedListCycle [ExcludeFromCodeCoverage] protected LinkedListCycle() { } - public static bool hasCycle(LinkedList.Node? head) + public static bool hasCycle(LinkedList.Node? head) { - List.Node> llindex = []; + List.Node> llindex = []; - LinkedList.Node? node = head; + LinkedList.Node? node = head; while (node != null) {