From 898cee515b16e81711bbf2121f3d1b17a04d3b80 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Sat, 29 Jun 2024 01:22:59 -0400 Subject: [PATCH] [REFACTOR] [BREAKING] generic-typed LinkedList Node. --- .../linked_list/FindMergeNode.Test.cs | 20 +++++++++---------- .../linked_list/LinkedListCycle.Test.cs | 18 ++++++++--------- .../linked_list/lib/Node.Test.cs | 16 +++++++-------- .../linked_list/FindMergeNode.cs | 6 +++--- .../linked_list/LinkedListCycle.cs | 6 +++--- .../linked_list/lib/Node.cs | 6 +++--- 6 files changed, 36 insertions(+), 36 deletions(-) diff --git a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.Test.cs b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.Test.cs index bf8db9a..5d86b1f 100644 --- a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.Test.cs +++ b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.Test.cs @@ -6,8 +6,8 @@ public class FindMergeNodeTest class FindMergeNodeTestCase() { public string title = ""; - public LinkedList.Node llist1 = new(0); - public LinkedList.Node llist2 = new(0); + public LinkedList.Node llist1 = new(0); + public LinkedList.Node llist2 = new(0); public int expected; } @@ -24,13 +24,13 @@ public void testInitialize() // / // 1 // - LinkedList.Node tc0_ll1_1 = new(1); - LinkedList.Node tc0_ll1_2 = new(2); - LinkedList.Node tc0_ll1_3 = new(3); + LinkedList.Node tc0_ll1_1 = new(1); + LinkedList.Node tc0_ll1_2 = new(2); + LinkedList.Node tc0_ll1_3 = new(3); tc0_ll1_1.next = tc0_ll1_2; tc0_ll1_2.next = tc0_ll1_3; - LinkedList.Node tc0_ll2_1 = new(1); + LinkedList.Node tc0_ll2_1 = new(1); tc0_ll2_1.next = tc0_ll1_2; // Test Case 1 @@ -41,13 +41,13 @@ public void testInitialize() // / // 1 // - LinkedList.Node tc1_ll1_1 = new(1); - LinkedList.Node tc1_ll1_2 = new(2); - LinkedList.Node tc1_ll1_3 = new(3); + LinkedList.Node tc1_ll1_1 = new(1); + LinkedList.Node tc1_ll1_2 = new(2); + LinkedList.Node tc1_ll1_3 = new(3); tc1_ll1_1.next = tc1_ll1_2; tc1_ll1_2.next = tc1_ll1_3; - LinkedList.Node tc1_ll2_1 = new(1); + LinkedList.Node tc1_ll2_1 = new(1); tc1_ll2_1.next = tc1_ll1_3; tests = [ diff --git a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs index 9d078b2..1217508 100644 --- a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs +++ b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.Test.cs @@ -6,7 +6,7 @@ public class LinkedListCycleTest class LinkedListCycleTestCase { public string title = ""; - public LinkedList.Node? llist; + public LinkedList.Node? llist; public bool expected; } @@ -16,11 +16,11 @@ class LinkedListCycleTestCase public void testInitialize() { // Linked list sample data: - LinkedList.Node ll1_1 = new(1); - LinkedList.Node ll1_2 = new(2); - LinkedList.Node ll1_3 = new(3); - LinkedList.Node ll1_4 = new(4); - LinkedList.Node ll1_5 = new(5); + LinkedList.Node ll1_1 = new(1); + LinkedList.Node ll1_2 = new(2); + LinkedList.Node ll1_3 = new(3); + LinkedList.Node ll1_4 = new(4); + LinkedList.Node ll1_5 = new(5); ll1_1.next = ll1_2; ll1_2.next = ll1_3; @@ -28,9 +28,9 @@ public void testInitialize() ll1_4.next = ll1_5; ll1_4.next = ll1_3; // <- cycle - LinkedList.Node ll2_1 = new(1); - LinkedList.Node ll2_2 = new(2); - LinkedList.Node ll2_3 = new(3); + LinkedList.Node ll2_1 = new(1); + LinkedList.Node ll2_2 = new(2); + LinkedList.Node ll2_3 = new(3); ll2_1.next = ll2_2; ll2_2.next = ll2_3; diff --git a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.Test.cs b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.Test.cs index d8dd767..06bd7e8 100644 --- a/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.Test.cs +++ b/algorithm-exercises-csharp-test/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.Test.cs @@ -6,7 +6,7 @@ public class NodeTest class NodeTestCase { public string title = ""; - public LinkedList.Node? llist; + public LinkedList.Node? llist; public string separator = ""; public string expected = ""; } @@ -17,11 +17,11 @@ class NodeTestCase public void testInitialize() { // Linked list sample data: - LinkedList.Node ll1_1 = new(1); - LinkedList.Node ll1_2 = new(2); - LinkedList.Node ll1_3 = new(3); - LinkedList.Node ll1_4 = new(4); - LinkedList.Node ll1_5 = new(5); + LinkedList.Node ll1_1 = new(1); + LinkedList.Node ll1_2 = new(2); + LinkedList.Node ll1_3 = new(3); + LinkedList.Node ll1_4 = new(4); + LinkedList.Node ll1_5 = new(5); ll1_1.next = ll1_2; ll1_2.next = ll1_3; @@ -46,14 +46,14 @@ public void testPrintLinkedList() { StringWriter sw = new(); - LinkedList.printSinglyLinkedList(test.llist, test.separator, sw); + LinkedList.printSinglyLinkedList(test.llist, test.separator, sw); string result = sw.ToString(); Assert.AreEqual( test.expected, result, String.Format( - "{0} testPrintLinkedList(, {1}, ) => must be: {2}", + "{0} testPrintLinkedList(, {1}, ) => must be: {2}", test.title, test.separator, test.expected diff --git a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs index e5e45ad..7715d00 100644 --- a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs +++ b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs @@ -9,10 +9,10 @@ public class FindMergeNode [ExcludeFromCodeCoverage] protected FindMergeNode() { } - public static int? findMergeNode(LinkedList.Node head1, LinkedList.Node head2) + public static int? findMergeNode(LinkedList.Node head1, LinkedList.Node head2) { - List llindex = []; - LinkedList.Node? node = head1; + List.Node> llindex = []; + LinkedList.Node? node = head1; int? result = null; while (node != null) diff --git a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs index 6ef3dc4..6c703a2 100644 --- a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs +++ b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs @@ -9,11 +9,11 @@ public class LinkedListCycle [ExcludeFromCodeCoverage] protected LinkedListCycle() { } - public static bool hasCycle(LinkedList.Node? head) + public static bool hasCycle(LinkedList.Node? head) { - List llindex = []; + List.Node> llindex = []; - LinkedList.Node? node = head; + LinkedList.Node? node = head; while (node != null) { diff --git a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.cs b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.cs index 51aa9bb..5cd7380 100644 --- a/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.cs +++ b/algorithm-exercises-csharp/src/hackerrank/interview_preparation_kit/linked_list/lib/Node.cs @@ -1,10 +1,10 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit; -public class LinkedList +public class LinkedList { - public class Node(int nodeData) + public class Node(T nodeData) { - public int data { get; set; } = nodeData; + public T data { get; set; } = nodeData; public Node? next { get; set; } = null; }