From 1261c461e64348801337eb04d23ceb25d6768f25 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Tue, 10 Dec 2024 12:55:45 -0300 Subject: [PATCH 1/3] [CONFIG] [Github Actions] Now use fixed version of Github Actions images. --- .github/workflows/codeql.yml | 3 +-- .github/workflows/docker-image.yml | 10 +++++----- .github/workflows/dotnet-coverage.yml | 2 +- .github/workflows/dotnet.yml | 6 +----- .github/workflows/gitleaks.yml | 2 +- .github/workflows/markdown-lint.yml | 5 ++--- .github/workflows/snyk-code.yml | 2 +- .github/workflows/sonarcloud.yml | 5 ++--- .github/workflows/yamllint.yml | 2 +- 9 files changed, 15 insertions(+), 22 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 4205cef..1645496 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -37,8 +37,7 @@ jobs: # - https://gh.io/using-larger-runners (GitHub.com only) # Consider using larger runners or machines with greater resources # for possible analysis time improvements. - runs-on: - ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} + runs-on: ${{ (matrix.language == 'swift' && 'macos-14') || 'ubuntu-24.04' }} timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }} permissions: # required for all workflows diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml index 4e185c5..d014452 100644 --- a/.github/workflows/docker-image.yml +++ b/.github/workflows/docker-image.yml @@ -16,7 +16,7 @@ env: jobs: build: name: "Build Docker images" - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 @@ -71,7 +71,7 @@ jobs: lint: name: "Run in docker: LINT" - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: build steps: - name: Download artifact @@ -91,7 +91,7 @@ jobs: test: name: "Run in docker: TEST" - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: build steps: - name: Download artifact @@ -111,7 +111,7 @@ jobs: security: name: "Snyk Container" - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: build permissions: actions: read @@ -158,7 +158,7 @@ jobs: sarif_file: "snyk.sarif" scan: name: "Trivy" - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: build permissions: actions: read diff --git a/.github/workflows/dotnet-coverage.yml b/.github/workflows/dotnet-coverage.yml index 95c9d39..d02c6ab 100644 --- a/.github/workflows/dotnet-coverage.yml +++ b/.github/workflows/dotnet-coverage.yml @@ -21,7 +21,7 @@ jobs: strategy: fail-fast: false matrix: - os: ["windows-latest"] + os: ["windows-2022"] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index d12ee48..1f923e6 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -21,11 +21,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ - "windows-latest", - "ubuntu-latest", - "macOS-latest" - ] + os: ["windows-2022", "ubuntu-24.04", "macos-14"] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/gitleaks.yml b/.github/workflows/gitleaks.yml index a9081e3..e0356e7 100644 --- a/.github/workflows/gitleaks.yml +++ b/.github/workflows/gitleaks.yml @@ -20,7 +20,7 @@ on: # yamllint disable-line rule:truthy jobs: scan: name: gitleaks - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 with: diff --git a/.github/workflows/markdown-lint.yml b/.github/workflows/markdown-lint.yml index 7ab4636..a82e726 100644 --- a/.github/workflows/markdown-lint.yml +++ b/.github/workflows/markdown-lint.yml @@ -14,12 +14,11 @@ permissions: read-all jobs: build: - - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 strategy: matrix: - os: [ubuntu-latest] + os: [ubuntu-24.04] node-version: [22.x] # See supported Node.js release schedule # at https://nodejs.org/en/about/releases/ diff --git a/.github/workflows/snyk-code.yml b/.github/workflows/snyk-code.yml index ddaaa06..ad85719 100644 --- a/.github/workflows/snyk-code.yml +++ b/.github/workflows/snyk-code.yml @@ -14,7 +14,7 @@ on: # yamllint disable-line rule:truthy jobs: security: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: actions: read contents: read diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index 58514ec..307c40a 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -1,5 +1,4 @@ --- - name: SonarCloud on: # yamllint disable-line rule:truthy @@ -12,14 +11,14 @@ on: # yamllint disable-line rule:truthy jobs: build: name: Build and analyze - runs-on: windows-latest + runs-on: windows-2022 steps: - name: Set up JDK uses: actions/setup-java@v4 with: java-version: 21 # Alternative distribution options are available. - distribution: 'temurin' + distribution: "temurin" - uses: actions/checkout@v4 with: # Shallow clones should be disabled for a better relevancy of analysis diff --git a/.github/workflows/yamllint.yml b/.github/workflows/yamllint.yml index 293de31..2141c43 100644 --- a/.github/workflows/yamllint.yml +++ b/.github/workflows/yamllint.yml @@ -11,7 +11,7 @@ on: # yamllint disable-line rule:truthy jobs: lint: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Checkout repository uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 From ecd06ccf6837d180e3dcd3ef32f521f950eec3b7 Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Tue, 10 Dec 2024 15:23:12 -0300 Subject: [PATCH 2/3] [CONFIG] [Github Actions] markdownlint standarization. --- .github/workflows/markdown-lint.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/markdown-lint.yml b/.github/workflows/markdown-lint.yml index a82e726..e5b2186 100644 --- a/.github/workflows/markdown-lint.yml +++ b/.github/workflows/markdown-lint.yml @@ -1,5 +1,4 @@ --- - name: Markdown Lint on: # yamllint disable-line rule:truthy @@ -13,19 +12,18 @@ on: # yamllint disable-line rule:truthy permissions: read-all jobs: - build: + markdownlint: runs-on: ubuntu-24.04 strategy: matrix: - os: [ubuntu-24.04] node-version: [22.x] # See supported Node.js release schedule # at https://nodejs.org/en/about/releases/ steps: - name: Checkout repository - uses: actions/checkout@v4 + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 - name: Set up Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 From d0594e67eeddc70a0aa553f7126f5bde163b352f Mon Sep 17 00:00:00 2001 From: Gonzalo Diaz Date: Tue, 10 Dec 2024 13:13:40 -0300 Subject: [PATCH 3/3] [CONFIG] [Github Actions] Better naming for actions --- .github/workflows/dotnet-coverage.yml | 7 +++---- .github/workflows/dotnet.yml | 7 +++---- .github/workflows/markdown-lint.yml | 1 + .github/workflows/yamllint.yml | 1 + 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/dotnet-coverage.yml b/.github/workflows/dotnet-coverage.yml index d02c6ab..b71183c 100644 --- a/.github/workflows/dotnet-coverage.yml +++ b/.github/workflows/dotnet-coverage.yml @@ -4,8 +4,7 @@ # yamllint enable rule:line-length --- - -name: .NET Coverage +name: dotNET Coverage on: # yamllint disable-line rule:truthy push: @@ -16,8 +15,8 @@ on: # yamllint disable-line rule:truthy workflow_dispatch: jobs: - build: - name: "Run CI" + coverage: + name: "Run Coverage" strategy: fail-fast: false matrix: diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 1f923e6..aed4055 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -4,8 +4,7 @@ # yamllint enable rule:line-length --- - -name: .NET Tests +name: dotNET Tests on: # yamllint disable-line rule:truthy push: @@ -16,8 +15,8 @@ on: # yamllint disable-line rule:truthy workflow_dispatch: jobs: - build: - name: "Run CI" + test: + name: "Run Tests" strategy: fail-fast: false matrix: diff --git a/.github/workflows/markdown-lint.yml b/.github/workflows/markdown-lint.yml index e5b2186..1b47c9a 100644 --- a/.github/workflows/markdown-lint.yml +++ b/.github/workflows/markdown-lint.yml @@ -13,6 +13,7 @@ permissions: read-all jobs: markdownlint: + name: Markdown Lint runs-on: ubuntu-24.04 strategy: diff --git a/.github/workflows/yamllint.yml b/.github/workflows/yamllint.yml index 2141c43..d155b52 100644 --- a/.github/workflows/yamllint.yml +++ b/.github/workflows/yamllint.yml @@ -11,6 +11,7 @@ on: # yamllint disable-line rule:truthy jobs: lint: + name: YAML Lint runs-on: ubuntu-24.04 steps: - name: Checkout repository