[REFACTOR] "static" classes marked as static

Gonzalo Diaz · Gonzalo Diaz · commit 3345990490bb · 2025-05-14T16:05:59.000-04:00
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/ArraysLeftRotation.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/ArraysLeftRotation.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class ArraysLeftRotation
+public static class ArraysLeftRotation
 {
-  [ExcludeFromCodeCoverage]
-  protected ArraysLeftRotation() { }
-
   public const int FIRST_POSITION = 0;
 
   /**
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/CrushBruteForce.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/CrushBruteForce.cs
@@ -5,11 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class CrushBruteForce
+public static class CrushBruteForce
 {
-  [ExcludeFromCodeCoverage]
-  protected CrushBruteForce() { }
-
   private const int INITIALIZER = 0;
 
   public static long arrayManipulation(int n, List<List<int>> queries)
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/CrushOptimized.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/CrushOptimized.cs
@@ -5,10 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class CrushOptimized
+public static class CrushOptimized
 {
-  [ExcludeFromCodeCoverage]
-  private CrushOptimized() { }
 
   /**
   // arrayManipulation.
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/TwoDArray.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/arrays/TwoDArray.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays
 
 using System.Diagnostics.CodeAnalysis;
 
-public class TwoDArray
+public static class TwoDArray
 {
-  [ExcludeFromCodeCoverage]
-  protected TwoDArray() { }
-
   private static List<int> getHourGlass(List<List<int>> arr, int positionX, int positionY)
   {
     List<int> result = [];
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.cs
@@ -6,11 +6,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 
 using System.Collections.Generic;
 
-public class CountTriplets
+public static class CountTriplets
 {
-  [ExcludeFromCodeCoverage]
-  protected CountTriplets() { }
-
   public static long countTriplets(List<long> arr, long r)
   {
     ArgumentNullException.ThrowIfNull(arr);
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTripletsBruteForce.cs
@@ -5,11 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 
-public class CountTripletsBruteForce
+public static class CountTripletsBruteForce
 {
-  [ExcludeFromCodeCoverage]
-  protected CountTripletsBruteForce() { }
-
   public static long countTriplets(List<long> arr, long r)
   {
     ArgumentNullException.ThrowIfNull(arr);
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/RansomNote.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/RansomNote.cs
@@ -5,22 +5,23 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 
-public class RansomNote
+public static class RansomNote
 {
-  [ExcludeFromCodeCoverage]
-  protected RansomNote() { }
-
   public class InvalidValueException : Exception
   {
     // constructor for the InvalidAgeException class
     public InvalidValueException(string msg)
     {
       Console.WriteLine(msg);
     }
+
+    public InvalidValueException()
+    {
+    }
   }
 
-  private static readonly string __YES__ = "Yes";
-  private static readonly string __NO__ = "No";
+  private const string __YES__ = "Yes";
+  private const string __NO__ = "No";
 
   public static bool checkMagazineCompute(List<string> magazine, List<string> note)
   {
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/SherlockAndAnagrams.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/SherlockAndAnagrams.cs
@@ -5,10 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 using System.Diagnostics.CodeAnalysis;
 using System.Numerics;
 
-public class SherlockAndAnagrams
+public static class SherlockAndAnagrams
 {
-  [ExcludeFromCodeCoverage]
-  protected SherlockAndAnagrams() { }
 
   /**
    * factorial().
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/TwoStrings.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/TwoStrings.cs
@@ -4,14 +4,11 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
 
 using System.Diagnostics.CodeAnalysis;
 
-public class TwoStrings
+public static class TwoStrings
 {
-  [ExcludeFromCodeCoverage]
-  protected TwoStrings() { }
-
-  private static readonly string __YES__ = "Yes";
-  private static readonly string __NO__ = "No";
-  private static readonly char __EMPTY_CHAR__ = '\0';
+  private const string __YES__ = "Yes";
+  private const string __NO__ = "No";
+  private const char __EMPTY_CHAR__ = '\0';
 
   public static bool twoStringsCompute(string s1, string s2)
   {
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/greedy_algorithms/LuckBalance.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/greedy_algorithms/LuckBalance.cs
@@ -4,17 +4,14 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.greedy
 
 using System.Diagnostics.CodeAnalysis;
 
-public class LuckBalance
+public static class LuckBalance
 {
   public class Competition(int _luck, int _important)
   {
     public int luck => _luck;
     public int important => _important;
   }
 
-  [ExcludeFromCodeCoverage]
-  protected LuckBalance() { }
-
   public static int luckBalance(int k, List<List<int>> contests)
   {
     ArgumentNullException.ThrowIfNull(contests);
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/greedy_algorithms/MinimumAbsoluteDifferenceInAnArray.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/greedy_algorithms/MinimumAbsoluteDifferenceInAnArray.cs
@@ -4,12 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.greedy
 
 using System.Diagnostics.CodeAnalysis;
 
-public class MinimumAbsoluteDifferenceInAnArray
+public static class MinimumAbsoluteDifferenceInAnArray
 {
-  [ExcludeFromCodeCoverage]
-  private MinimumAbsoluteDifferenceInAnArray()
-  {
-  }
 
   /**
    * minimumAbsoluteDifference.
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/FindMergeNode.cs
@@ -5,11 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked
 
 using System.Diagnostics.CodeAnalysis;
 
-public class FindMergeNode
+public static class FindMergeNode
 {
-  [ExcludeFromCodeCoverage]
-  protected FindMergeNode() { }
-
   public static int? findMergeNode(LinkedList<int>.Node head1, LinkedList<int>.Node head2)
   {
     List<LinkedList<int>.Node> llindex = [];
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/LinkedListCycle.cs
@@ -5,11 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked
 
 using System.Diagnostics.CodeAnalysis;
 
-public class LinkedListCycle
+public static class LinkedListCycle
 {
-  [ExcludeFromCodeCoverage]
-  protected LinkedListCycle() { }
-
   public static bool hasCycle<T>(LinkedList<T>.Node? head)
   {
     List<LinkedList<T>.Node> llindex = [];
diff --git a/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/lib/Node.cs b/src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/linked_list/lib/Node.cs
@@ -1,6 +1,6 @@
 namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.linked_list.lib;
 
-public class LinkedList<T>
+public static class LinkedList<T>
 {
   public class Node(T nodeData)
   {
diff --git a/src/algorithm_exercises_csharp/hackerrank/projecteuler/Euler001.cs b/src/algorithm_exercises_csharp/hackerrank/projecteuler/Euler001.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.projecteuler;
 
 using System.Diagnostics.CodeAnalysis;
 
-public class Euler001
+public static class Euler001
 {
-  [ExcludeFromCodeCoverage]
-  protected Euler001() { }
-
   public static int sumOfArithmeticProgression(int n, int d)
   {
     int new_n = n / d;
diff --git a/src/algorithm_exercises_csharp/hackerrank/projecteuler/Euler002.cs b/src/algorithm_exercises_csharp/hackerrank/projecteuler/Euler002.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.projecteuler;
 
 using System.Diagnostics.CodeAnalysis;
 
-public class Euler002
+public static class Euler002
 {
-  [ExcludeFromCodeCoverage]
-  protected Euler002() { }
-
   public static int fiboEvenSum(int n)
   {
     Log.info("fiboEvenSum({n})", n);
diff --git a/src/algorithm_exercises_csharp/hackerrank/projecteuler/Euler003.cs b/src/algorithm_exercises_csharp/hackerrank/projecteuler/Euler003.cs
@@ -6,11 +6,8 @@ namespace algorithm_exercises_csharp.hackerrank.projecteuler;
 
 using System.Diagnostics.CodeAnalysis;
 
-public class Euler003
+public static class Euler003
 {
-  [ExcludeFromCodeCoverage]
-  protected Euler003() { }
-
   public static int? primeFactor(int n)
   {
     if (n < 2)
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/BirthdayCakeCandles.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/BirthdayCakeCandles.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Diagnostics.CodeAnalysis;
 
-public class BirthdayCakeCandles
+public static class BirthdayCakeCandles
 {
-  [ExcludeFromCodeCoverage]
-  protected BirthdayCakeCandles() { }
-
   public static int birthdayCakeCandles(List<int> _arr)
   {
     ArgumentNullException.ThrowIfNull(_arr);
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/CompareTriplets.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/CompareTriplets.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Diagnostics.CodeAnalysis;
 
-public class CompareTriplets
+public static class CompareTriplets
 {
-  [ExcludeFromCodeCoverage]
-  protected CompareTriplets() { }
-
   public static List<int> compareTriplets(List<int> _a, List<int> _b)
   {
     ArgumentNullException.ThrowIfNull(_a);
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/DiagonalDifference.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/DiagonalDifference.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Diagnostics.CodeAnalysis;
 
-public class DiagonalDifference
+public static class DiagonalDifference
 {
-  [ExcludeFromCodeCoverage]
-  protected DiagonalDifference() { }
-
   public static int diagonalDifference(List<List<int>> _arr)
   {
     ArgumentNullException.ThrowIfNull(_arr);
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/PlusMinus.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/PlusMinus.cs
@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Globalization;
 
-public class PlusMinus
+public static class PlusMinus
 {
-  [ExcludeFromCodeCoverage]
-  protected PlusMinus() { }
-
   public static string plusMinus(List<int> arr)
   {
     ArgumentNullException.ThrowIfNull(arr);
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/SimpleArraySum.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/SimpleArraySum.cs
@@ -2,6 +2,8 @@
 
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
+using System.Diagnostics.CodeAnalysis;
+
 public static class SimpleArraySum
 {
   public static int simpleArraySum(List<int> ar)
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/SolveMeFirst.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/SolveMeFirst.cs
@@ -2,13 +2,8 @@
 
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
-using System.Diagnostics.CodeAnalysis;
-
-public class SolveMeFirst
+public static class SolveMeFirst
 {
-  [ExcludeFromCodeCoverage]
-  protected SolveMeFirst() { }
-
   public static int solveMeFirst(int _a, int _b)
   {
     return _a + _b;
diff --git a/src/algorithm_exercises_csharp/hackerrank/warmup/Staircase.cs b/src/algorithm_exercises_csharp/hackerrank/warmup/Staircase.cs
@@ -3,13 +3,9 @@
 namespace algorithm_exercises_csharp.hackerrank.warmup;
 
 using System.Text;
-using System.Diagnostics.CodeAnalysis;
 
-public class Staircase
+public static class Staircase
 {
-  [ExcludeFromCodeCoverage]
-  protected Staircase() { }
-
   public static string staircase(int _n)
   {
     List<string> result = [];
@@ -32,6 +28,6 @@ public static string staircase(int _n)
 
       result.Add(line.ToString());
     }
-    return String.Join("\n", result);
+    return string.Join("\n", result);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -5,10 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays`
`5`	`5`
`6`	`6`	`using System.Diagnostics.CodeAnalysis;`
`7`	`7`
`8`		`-public class CrushOptimized`
	`8`	`+public static class CrushOptimized`
`9`	`9`	`{`
`10`		`- [ExcludeFromCodeCoverage]`
`11`		`- private CrushOptimized() { }`
`12`	`10`
`13`	`11`	`/**`
`14`	`12`	`// arrayManipulation.`
Original file line number	Diff line number	Diff line change
`@@ -4,11 +4,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.arrays`
`4`	`4`
`5`	`5`	`using System.Diagnostics.CodeAnalysis;`
`6`	`6`
`7`		`-public class TwoDArray`
	`7`	`+public static class TwoDArray`
`8`	`8`	`{`
`9`		`- [ExcludeFromCodeCoverage]`
`10`		`- protected TwoDArray() { }`
`11`		`-`
`12`	`9`	`private static List<int> getHourGlass(List<List<int>> arr, int positionX, int positionY)`
`13`	`10`	`{`
`14`	`11`	`List<int> result = [];`
Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio`
`6`	`6`
`7`	`7`	`using System.Collections.Generic;`
`8`	`8`
`9`		`-public class CountTriplets`
	`9`	`+public static class CountTriplets`
`10`	`10`	`{`
`11`		`- [ExcludeFromCodeCoverage]`
`12`		`- protected CountTriplets() { }`
`13`		`-`
`14`	`11`	`public static long countTriplets(List<long> arr, long r)`
`15`	`12`	`{`
`16`	`13`	`ArgumentNullException.ThrowIfNull(arr);`
Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio`
`5`	`5`	`using System.Diagnostics.CodeAnalysis;`
`6`	`6`	`using System.Collections.Generic;`
`7`	`7`
`8`		`-public class CountTripletsBruteForce`
	`8`	`+public static class CountTripletsBruteForce`
`9`	`9`	`{`
`10`		`- [ExcludeFromCodeCoverage]`
`11`		`- protected CountTripletsBruteForce() { }`
`12`		`-`
`13`	`10`	`public static long countTriplets(List<long> arr, long r)`
`14`	`11`	`{`
`15`	`12`	`ArgumentNullException.ThrowIfNull(arr);`
Original file line number	Diff line number	Diff line change
`@@ -5,22 +5,23 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio`
`5`	`5`	`using System.Diagnostics.CodeAnalysis;`
`6`	`6`	`using System.Collections.Generic;`
`7`	`7`
`8`		`-public class RansomNote`
	`8`	`+public static class RansomNote`
`9`	`9`	`{`
`10`		`- [ExcludeFromCodeCoverage]`
`11`		`- protected RansomNote() { }`
`12`		`-`
`13`	`10`	`public class InvalidValueException : Exception`
`14`	`11`	`{`
`15`	`12`	`// constructor for the InvalidAgeException class`
`16`	`13`	`public InvalidValueException(string msg)`
`17`	`14`	`{`
`18`	`15`	`Console.WriteLine(msg);`
`19`	`16`	`}`
	`17`	`+`
	`18`	`+ public InvalidValueException()`
	`19`	`+ {`
	`20`	`+ }`
`20`	`21`	`}`
`21`	`22`
`22`		`- private static readonly string __YES__ = "Yes";`
`23`		`- private static readonly string __NO__ = "No";`
	`23`	`+ private const string __YES__ = "Yes";`
	`24`	`+ private const string __NO__ = "No";`
`24`	`25`
`25`	`26`	`public static bool checkMagazineCompute(List<string> magazine, List<string> note)`
`26`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -4,17 +4,14 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.greedy`
`4`	`4`
`5`	`5`	`using System.Diagnostics.CodeAnalysis;`
`6`	`6`
`7`		`-public class LuckBalance`
	`7`	`+public static class LuckBalance`
`8`	`8`	`{`
`9`	`9`	`public class Competition(int _luck, int _important)`
`10`	`10`	`{`
`11`	`11`	`public int luck => _luck;`
`12`	`12`	`public int important => _important;`
`13`	`13`	`}`
`14`	`14`
`15`		`- [ExcludeFromCodeCoverage]`
`16`		`- protected LuckBalance() { }`
`17`		`-`
`18`	`15`	`public static int luckBalance(int k, List<List<int>> contests)`
`19`	`16`	`{`
`20`	`17`	`ArgumentNullException.ThrowIfNull(contests);`