Skip to content

Commit ed25cb5

Browse files
author
MarcoFalke
committed
Merge bitcoin-core/gui#217: qt: Make warning label look clickable
67c59ae qt: Make warning label look clickable (Jarol Rodriguez) Pull request description: The warning icon on the overview page indicates that there is something important the user should know about, but a user may not be aware that they can click it because, on `master`, the warning label does not look clickable. As detailed in issue #23, the reason to make it look clickable is that it if they "had a more clickable-appearance (borders or beveled button edges) it could help users more quickly understand what they are being alerted to." This PR removes the `flat` property from both `QPushButton`'s to make them look like a button, and therefore clickable. Furthermore, it updates the `Maximum Width` to `45` to fix the small hit-box issue outlined in issue bitcoin#215. Below are screenshots showing how the warning icon looks under `master` and this `PR`: **macOS 11.1: Qt 5.15** | Master | PR | | ----------- | ----------- | | <img width="754" alt="Screen Shot 2021-02-22 at 5 00 40 PM" src="https://user-images.githubusercontent.com/23396902/108776135-f6d50380-752f-11eb-9f96-25163c6a2a02.png"> | <img width="754" alt="Screen Shot 2021-02-22 at 3 08 40 PM" src="https://user-images.githubusercontent.com/23396902/108776068-e0c74300-752f-11eb-9545-3580e2b8f187.png"> | **Ubuntu 20.04: Qt 5.12** | Master | PR | | ----------- | ----------- | | <img width="783" alt="Screen Shot 2021-02-22 at 4 57 32 PM" src="https://user-images.githubusercontent.com/23396902/108776249-284dcf00-7530-11eb-8325-7fe13a9243a7.png"> | ![Screen Shot 2021-02-22 at 4 12 54 PM](https://user-images.githubusercontent.com/23396902/108776428-60eda880-7530-11eb-8999-59ddd70de85f.png) | Closes #23 Closes bitcoin#215 ACKs for top commit: Talkless: tACK 67c59ae, tested on Debian Sid. Does look as expected. Tree-SHA512: 2b7302fb990ea49e2f01df6f4a23e2bc3de0797da89deaeb299742e6b285a0c21ea80d8259dc0222640cccc2bccc4ea09df443b9a11bf8b88a828e5fb2aec12c
2 parents f7653eb + 67c59ae commit ed25cb5

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/qt/forms/overviewpage.ui

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
</property>
6969
<property name="maximumSize">
7070
<size>
71-
<width>30</width>
71+
<width>45</width>
7272
<height>16777215</height>
7373
</size>
7474
</property>
@@ -89,9 +89,6 @@
8989
<height>24</height>
9090
</size>
9191
</property>
92-
<property name="flat">
93-
<bool>true</bool>
94-
</property>
9592
</widget>
9693
</item>
9794
<item>
@@ -406,7 +403,7 @@
406403
</property>
407404
<property name="maximumSize">
408405
<size>
409-
<width>30</width>
406+
<width>45</width>
410407
<height>16777215</height>
411408
</size>
412409
</property>
@@ -427,9 +424,6 @@
427424
<height>24</height>
428425
</size>
429426
</property>
430-
<property name="flat">
431-
<bool>true</bool>
432-
</property>
433427
</widget>
434428
</item>
435429
<item>

0 commit comments

Comments
 (0)