Skip to content

Commit 8a36a47

Browse files
committed
Merge bitcoin#32781: refactor: modernize deprecated ipc headers
74b7e9c refactor: modernize deprecated ipc headers (Sjors Provoost) Pull request description: Split off from bitcoin#31802. Pre-empt tidy warning when multiprocess is on by default: ``` [10:33:51.654] /ci_container_base/src/ipc/capnp/protocol.cpp:20:10: error: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead [modernize-deprecated-headers,-warnings-as-errors] [10:33:51.654] 20 | #include <errno.h> [10:33:51.654] | ^~~~~~~~~ [10:33:51.654] | <cerrno> [10:33:51.654] 919 warnings generated. ``` https://github.com/bitcoin/bitcoin/pull/31802/checks?check_run_id=43968493627 ACKs for top commit: maflcko: lgtm ACK 74b7e9c ryanofsky: Code review ACK 74b7e9c Tree-SHA512: a629e9849b420c9de52dc7a74d35ca14c3522784ac101a189b20d3439a4735e2f3bb766864938abb2fc248eb94ec15c71c35db69a3267b6c29ef26e0f91a79ab
2 parents ed060e0 + 74b7e9c commit 8a36a47

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/ipc/capnp/protocol.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#include <mp/util.h>
1717
#include <util/threadnames.h>
1818

19-
#include <assert.h>
20-
#include <errno.h>
19+
#include <cassert>
20+
#include <cerrno>
2121
#include <future>
2222
#include <memory>
2323
#include <mutex>

src/ipc/interfaces.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@
1515

1616
#include <cstdio>
1717
#include <cstdlib>
18+
#include <cstring>
1819
#include <functional>
1920
#include <memory>
2021
#include <stdexcept>
21-
#include <string.h>
2222
#include <string>
2323
#include <unistd.h>
2424
#include <utility>

src/ipc/process.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313

1414
#include <cstdint>
1515
#include <cstdlib>
16-
#include <errno.h>
16+
#include <cstring>
17+
#include <cerrno>
1718
#include <exception>
1819
#include <iostream>
1920
#include <stdexcept>
20-
#include <string.h>
2121
#include <sys/socket.h>
2222
#include <sys/un.h>
2323
#include <unistd.h>

0 commit comments

Comments
 (0)