Skip to content

Commit 6d3dc52

Browse files
committed
Merge bitcoin#9254: [depends] ZeroMQ 4.2.2
126999d depends: fix zmq build with mingw < 4.0 (Cory Fields) 387879d [depends] ZeroMQ 4.2.2 (fanquake) Pull request description: Update depends ZeroMQ to 4.2.2, the release notes are available [here](https://github.com/zeromq/libzmq/releases). We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). `--without-documentation` is deprecated and has been replaced with `--without-docs`. `--disable-perf` disables building performance measuring tools, which are enabled by default, see the libzmq [configure.ac](https://github.com/zeromq/libzmq/blob/master/configure.ac#L367). Updated dependencies.md. `--disable-curve-keygen` disable building the curve key generation tool. See [here](https://github.com/zeromq/libzmq/blob/master/configure.ac#L405). Can someone on windows test that this is still working correctly. Maybe @achow101 ? Tree-SHA512: c6c4b15f545b6de21648f05027b5500fca0e6b5b72e791ac9a0aa523c57f2feb5aae94e42531275dddd922e11e462a52f08be1118ba1629c3cae765b18e5d720
2 parents 6816484 + 126999d commit 6d3dc52

File tree

5 files changed

+38
-53
lines changed

5 files changed

+38
-53
lines changed

depends/packages/zeromq.mk

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
11
package=zeromq
2-
$(package)_version=4.1.5
3-
$(package)_download_path=https://github.com/zeromq/zeromq4-1/releases/download/v$($(package)_version)/
2+
$(package)_version=4.2.2
3+
$(package)_download_path=https://github.com/zeromq/libzmq/releases/download/v$($(package)_version)/
44
$(package)_file_name=$(package)-$($(package)_version).tar.gz
5-
$(package)_sha256_hash=04aac57f081ffa3a2ee5ed04887be9e205df3a7ddade0027460b8042432bdbcf
6-
$(package)_patches=9114d3957725acd34aa8b8d011585812f3369411.patch 9e6745c12e0b100cd38acecc16ce7db02905e27c.patch
5+
$(package)_sha256_hash=5b23f4ca9ef545d5bd3af55d305765e3ee06b986263b31967435d285a3e6df6b
6+
$(package)_patches=0001-fix-build-with-older-mingw64.patch
77

88
define $(package)_set_vars
9-
$(package)_config_opts=--without-documentation --disable-shared --without-libsodium --disable-curve
9+
$(package)_config_opts=--without-docs --disable-shared --without-libsodium --disable-curve --disable-curve-keygen --disable-perf
1010
$(package)_config_opts_linux=--with-pic
1111
$(package)_cxxflags=-std=c++11
1212
endef
1313

1414
define $(package)_preprocess_cmds
15-
patch -p1 < $($(package)_patch_dir)/9114d3957725acd34aa8b8d011585812f3369411.patch && \
16-
patch -p1 < $($(package)_patch_dir)/9e6745c12e0b100cd38acecc16ce7db02905e27c.patch && \
15+
patch -p1 < $($(package)_patch_dir)/0001-fix-build-with-older-mingw64.patch && \
1716
./autogen.sh
1817
endef
1918

@@ -22,7 +21,7 @@ define $(package)_config_cmds
2221
endef
2322

2423
define $(package)_build_cmds
25-
$(MAKE) libzmq.la
24+
$(MAKE) src/libzmq.la
2625
endef
2726

2827
define $(package)_stage_cmds
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
From 1a159c128c69a42d90819375c06a39994f3fbfc1 Mon Sep 17 00:00:00 2001
2+
From: Cory Fields <cory-nospam-@coryfields.com>
3+
Date: Tue, 28 Nov 2017 20:33:25 -0500
4+
Subject: [PATCH] fix build with older mingw64
5+
6+
---
7+
src/windows.hpp | 7 +++++++
8+
1 file changed, 7 insertions(+)
9+
10+
diff --git a/src/windows.hpp b/src/windows.hpp
11+
index 99e889d..e69038e 100644
12+
--- a/src/windows.hpp
13+
+++ b/src/windows.hpp
14+
@@ -55,6 +55,13 @@
15+
#include <winsock2.h>
16+
#include <windows.h>
17+
#include <mswsock.h>
18+
+
19+
+#if defined __MINGW64_VERSION_MAJOR && __MINGW64_VERSION_MAJOR < 4
20+
+// Workaround for mingw-w64 < v4.0 which did not include ws2ipdef.h in iphlpapi.h.
21+
+// Fixed in mingw-w64 by 9bd8fe9148924840d315b4c915dd099955ea89d1.
22+
+#include <ws2def.h>
23+
+#include <ws2ipdef.h>
24+
+#endif
25+
#include <iphlpapi.h>
26+
27+
#if !defined __MINGW32__
28+
--
29+
2.7.4
30+

depends/patches/zeromq/9114d3957725acd34aa8b8d011585812f3369411.patch

Lines changed: 0 additions & 22 deletions
This file was deleted.

depends/patches/zeromq/9e6745c12e0b100cd38acecc16ce7db02905e27c.patch

Lines changed: 0 additions & 22 deletions
This file was deleted.

doc/dependencies.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ These are the dependencies currently used by Bitcoin Core. You can find instruct
2727
| Qt | [5.7.1](https://download.qt.io/official_releases/qt/) | 4.7+ | No | | |
2828
| XCB | | | | | [Yes](https://github.com/bitcoin/bitcoin/blob/master/depends/packages/qt.mk#L94) (Linux only) |
2929
| xkbcommon | | | | | [Yes](https://github.com/bitcoin/bitcoin/blob/master/depends/packages/qt.mk#L93) (Linux only) |
30-
| ZeroMQ | [4.1.5](https://github.com/zeromq/libzmq/releases) | | No | | |
30+
| ZeroMQ | [4.2.2](https://github.com/zeromq/libzmq/releases) | | No | | |
3131
| zlib | [1.2.11](http://zlib.net/) | | | | No |

0 commit comments

Comments
 (0)