Skip to content

Commit f908d91

Browse files
Changed definitions of overridden functions to match the original (#49)
Summary: In #46 I override 4 functions of the MySqlGrammar and added a return type to the definition. Occurred that this is a breaking change as all users that extended from our class and override the same functions - also should add the return type.
1 parent 0c72883 commit f908d91

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Query/Grammar.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ protected function wrapJsonFieldAndPath($column)
145145
* @param string $sql
146146
* @return string
147147
*/
148-
protected function wrapUnion($sql): string
148+
protected function wrapUnion($sql)
149149
{
150150
return 'SELECT * FROM ('.$sql.')';
151151
}
@@ -156,7 +156,7 @@ protected function wrapUnion($sql): string
156156
* @param Builder $query
157157
* @return string
158158
*/
159-
protected function compileUnions(Builder $query): string
159+
protected function compileUnions(Builder $query)
160160
{
161161
$sql = '';
162162

@@ -173,7 +173,7 @@ protected function compileUnions(Builder $query): string
173173
* @param Builder $query
174174
* @return string
175175
*/
176-
public function compileSelect(Builder $query): string
176+
public function compileSelect(Builder $query)
177177
{
178178
$sql = parent::compileSelect($query);
179179

@@ -203,7 +203,7 @@ public function compileSelect(Builder $query): string
203203
* @param $offset
204204
* @return string
205205
*/
206-
protected function compileOffset(Builder $query, $offset): string
206+
protected function compileOffset(Builder $query, $offset)
207207
{
208208
return $this->compileOffsetWithLimit($offset, $query->limit);
209209
}

0 commit comments

Comments
 (0)