check poin

Author: AdalbertMemSQL

src/Query/Grammar.php

@@ -4,22 +4,40 @@
 
 use Illuminate\Database\Query\Builder;
 use Illuminate\Database\Query\Grammars\MySqlGrammar;
+use Illuminate\Support\Facades\Log;
+use Exception;
 
 class Grammar extends MySqlGrammar
 {
     public function compileOptions(array $options): string
     {
         $optionString = '';
         foreach ($options as $key => $value) {
-            if (! empty($optionString)) {
+            if (!empty($optionString)) {
                 $optionString .= ',';
             }
-            $optionString .= $key.'='.$value;
+            $optionString .= $key . '=' . $value;
         }
 
         return "OPTION ({$optionString})";
     }
 
+    public function compileDelete(Builder $query)
+    {
+        if (isset($query->orders)) {
+            if ($query->connection->getConfig('ignore_order_by_in_deletes')) {
+                if (env('APP_ENV') !== 'production') {
+                    Log::warning('SingleStore does not support "order by" in a delete statement. The "order by" clause will be ignored.');
+                }
+                $query->orders = [];
+            } else {
+                throw new Exception('SingleStore does not support "order by" in a delete statement. Use "ignore_order_by_in_deletes" configuration to ignore orderBy in delete operations.');
+            }
+        }
+
+        return parent::compileDelete($query);
+    }
+
     /**
      * Compile a "where fulltext" clause.
      *
@@ -81,7 +99,7 @@ protected function whereNull(Builder $query, $where)
         if ($this->isJsonSelector($where['column'])) {
             [$field, $path] = $this->wrapJsonFieldAndPath($where['column']);
 
-            return '(JSON_EXTRACT_JSON('.$field.$path.') IS NULL OR JSON_GET_TYPE(JSON_EXTRACT_JSON('.$field.$path.')) = \'NULL\')';
+            return '(JSON_EXTRACT_JSON(' . $field . $path . ') IS NULL OR JSON_GET_TYPE(JSON_EXTRACT_JSON(' . $field . $path . ')) = \'NULL\')';
         }
 
         return parent::whereNull($query, $where);
@@ -92,7 +110,7 @@ protected function whereNotNull(Builder $query, $where)
         if ($this->isJsonSelector($where['column'])) {
             [$field, $path] = $this->wrapJsonFieldAndPath($where['column']);
 
-            return '(JSON_EXTRACT_JSON('.$field.$path.') IS NOT NULL AND JSON_GET_TYPE(JSON_EXTRACT_JSON('.$field.$path.')) != \'NULL\')';
+            return '(JSON_EXTRACT_JSON(' . $field . $path . ') IS NOT NULL AND JSON_GET_TYPE(JSON_EXTRACT_JSON(' . $field . $path . ')) != \'NULL\')';
         }
 
         return parent::whereNotNull($query, $where);
@@ -103,7 +121,7 @@ protected function wrapJsonSelector($value)
         // Break apart the column name from the JSON keypath.
         [$field, $path] = $this->wrapJsonFieldAndPath($value);
 
-        if (! $path) {
+        if (!$path) {
             return $field;
         }
 
@@ -144,7 +162,7 @@ protected function wrapJsonFieldAndPath($column)
             return "'$part'";
         }, $parts);
 
-        $path = count($parts) ? ', '.implode(', ', $parts) : '';
+        $path = count($parts) ? ', ' . implode(', ', $parts) : '';
 
         return [$field, $path];
     }
@@ -157,7 +175,7 @@ protected function wrapJsonFieldAndPath($column)
      */
     protected function wrapUnion($sql)
     {
-        return 'SELECT * FROM ('.$sql.')';
+        return 'SELECT * FROM (' . $sql . ')';
     }
 
     /**
@@ -185,7 +203,7 @@ protected function compileUnion(array $union)
     {
         $conjunction = $union['all'] ? ' union all ' : ' union ';
 
-        return $conjunction.'('.$union['query']->toSql().')';
+        return $conjunction . '(' . $union['query']->toSql() . ')';
     }
 
     /**
@@ -203,19 +221,19 @@ public function compileSelect(Builder $query)
             return ltrim($sql);
         }
 
-        if (! empty($query->unionOrders) || isset($query->unionLimit) || isset($query->unionOffset)) {
-            $sql = 'SELECT * FROM ('.$sql.') ';
+        if (!empty($query->unionOrders) || isset($query->unionLimit) || isset($query->unionOffset)) {
+            $sql = 'SELECT * FROM (' . $sql . ') ';
 
-            if (! empty($query->unionOrders)) {
-                $sql .= ' '.$this->compileOrders($query, $query->unionOrders);
+            if (!empty($query->unionOrders)) {
+                $sql .= ' ' . $this->compileOrders($query, $query->unionOrders);
             }
 
             if (isset($query->unionLimit)) {
-                $sql .= ' '.$this->compileLimit($query, $query->unionLimit);
+                $sql .= ' ' . $this->compileLimit($query, $query->unionLimit);
             }
 
             if (isset($query->unionOffset)) {
-                $sql .= ' '.$this->compileUnionOffset($query, $query->unionOffset);
+                $sql .= ' ' . $this->compileUnionOffset($query, $query->unionOffset);
             }
         }
 
@@ -247,11 +265,11 @@ private function compileOffsetWithLimit($offset, $limit): string
     {
         // OFFSET is not valid without LIMIT
         // Add a huge LIMIT clause
-        if (! isset($limit)) {
+        if (!isset($limit)) {
             // 9223372036854775807 - max 64-bit integer
-            return ' LIMIT 9223372036854775807 OFFSET '.(int) $offset;
+            return ' LIMIT 9223372036854775807 OFFSET ' . (int) $offset;
         }
 
-        return ' OFFSET '.(int) $offset;
+        return ' OFFSET ' . (int) $offset;
     }
 }

tests/BaseTest.php

@@ -33,6 +33,7 @@ public function getEnvironmentSetUp($app)
         // configuration possible, making for the ideal developer experience.
         $app['config']->set('database.default', 'mysql');
         $app['config']->set('database.connections.mysql.driver', 'singlestore');
-        $app['config']->set('database.connections.mysql.options.'.PDO::ATTR_EMULATE_PREPARES, true);
+        $app['config']->set('database.connections.mysql.options.' . PDO::ATTR_EMULATE_PREPARES, true);
+        $app['config']->set('database.connections.mysql.ignore_order_by_in_deletes', true);
     }
 }