Update XO (#1562)

Author: fisker

.github/workflows/main.yml

@@ -24,7 +24,7 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npx ava
   lint-test:
     runs-on: ubuntu-latest
@@ -33,8 +33,8 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: 16
-      - run: npm install --legacy-peer-deps
-      # - run: npx xo
+      - run: npm install
+      - run: npx xo
       # Force update snapshots, https://github.com/avajs/ava/discussions/2754
       - run: npx nyc ava --update-snapshots
         env:
@@ -45,19 +45,17 @@ jobs:
       - uses: codecov/codecov-action@v1
         with:
           fail_ci_if_error: true
-      # `xo` can't work on ESLint 8
-      - run: npm install eslint@7 && npx xo
   run-rules-on-codebase:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npm run run-rules-on-codebase
   integration:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
-      - run: npm install --legacy-peer-deps
+      - run: npm install
       - run: npm run integration

package.json

@@ -76,7 +76,7 @@
 		"outdent": "^0.8.0",
 		"typescript": "^4.4.2",
 		"vue-eslint-parser": "^8.0.0",
-		"xo": "^0.44.0"
+		"xo": "^0.46.3"
 	},
 	"peerDependencies": {
 		"eslint": ">=7.32.0"
@@ -134,7 +134,8 @@
 					],
 					"eslint-plugin/require-meta-docs-url": "off",
 					"eslint-plugin/require-meta-has-suggestions": "off",
-					"eslint-plugin/require-meta-schema": "off"
+					"eslint-plugin/require-meta-schema": "off",
+					"eslint-plugin/no-deprecated-context-methods": "off"
 				}
 			}
 		]

rules/prefer-spread.js

@@ -446,6 +446,7 @@ const create = context => {
 					return;
 				}
 
+				// eslint-disable-next-line unicorn/prefer-spread
 				const resultBySplit = value.split('');
 				const resultBySpread = [...value];
 

test/run-rules-on-codebase/lint.mjs

@@ -61,15 +61,6 @@ const eslint = new ESLint({
 					'unicorn/prefer-module': 'off',
 				},
 			},
-			{
-				files: [
-					'rules/prefer-spread.js',
-				],
-				rules: {
-					// TODO[xo@>=0.45.0]: Enable this rule when `xo` updated `eslint-plugin-unicorn`
-					'unicorn/prefer-spread': 'off',
-				},
-			},
 		],
 	},
 });