The 10,001 rows bug (across multiple plugins)

[simonw]

The feature I added here:

• Stop counting at 10,000 on table view as well #2408

Introduced bugs in plugins. This may require a change to core to help them work around it:

• 10,001 row count confuses things a lot datasette/datasette-enrichments#57
• Showing 1,000 of 10,001 bug datasette-cluster-map#52

[Findus23]

Because it is semi-related, I might also mention it here:

The changes in #2408 also mean that datasette inspect now returns 10001, which I think might not be intended (after all that's where we have the time to count properly).

A quick, ugly workaround would be

diff --git a/datasette/cli.py b/datasette/cli.py
index fb1fe7b9..048d5a9d 100644
--- a/datasette/cli.py
+++ b/datasette/cli.py
@@ -148,6 +148,7 @@ async def inspect_(files, sqlite_extensions):
     app = Datasette([], immutables=files, sqlite_extensions=sqlite_extensions)
     data = {}
     for name, database in app.databases.items():
+        database.count_limit = 100000000
         counts = await database.table_counts(limit=3600 * 1000)
         data[name] = {
             "hash": database.hash,

to make sure when running the cli inspect arbitrary large row numbers are counted.