Skip to content

Commit 010d3b9

Browse files
committed
Fix missing '-' for negative offset values smaller than an hour
1 parent 8d873f1 commit 010d3b9

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

src/main/java/ch/poole/openinghoursparser/VariableTime.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,11 @@ public String toString() {
5757
if (offset != 0) {
5858
b.append("(");
5959
b.append(event);
60-
if (offset > 0) {
61-
b.append("+");
62-
}
63-
b.append(String.format(Locale.US, "%02d", offset / 60));
60+
b.append(offset >= 0 ? '+' : '-');
61+
int absOffset = Math.abs(offset);
62+
b.append(String.format(Locale.US, "%02d", absOffset / 60));
6463
b.append(":");
65-
b.append(String.format(Locale.US, "%02d", Math.abs(offset) % 60));
64+
b.append(String.format(Locale.US, "%02d", absOffset % 60));
6665
b.append(")");
6766
} else {
6867
b.append(event);

test-data/oh.txt-result

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99156,7 +99156,7 @@
9915699156
0 Mo-Su 09:30-23:30
9915799157
0 Mo-Su 09:30-24:00
9915899158
0 Mo-Su 09:30+; Fr,Sa 09:00+
99159-
0 Mo-Su 09:30-(sunset-1:00); Nov-Feb off
99159+
0 Mo-Su 09:30-(sunset-01:00); Nov-Feb off
9916099160
1
9916199161
0 Mo-Su 09:45-01:00
9916299162
0 Mo-Su 09:45-12:25,12:55-17:50
@@ -102824,7 +102824,7 @@
102824102824
0 Mo-Su,Su 12:00-23:00; Fr,Sa 12:00-01:00
102825102825
0 Mo-Su,Su 15:00-01:00; Th-Sa 15:00-03:00
102826102826
0 Mo-Su,Su 17:00-23:00; Fr,Sa 17:00-01:00
102827-
0 Mo-Su (sunrise00:30)-(sunset+00:30)
102827+
0 Mo-Su (sunrise-00:30)-(sunset+00:30)
102828102828
0 Mo-Su (sunrise+01:00)-(sunset+01:00)
102829102829
0 Mo-Su sunrise-22:00
102830102830
0 Mo-Su sunrise-23:00
@@ -136708,9 +136708,9 @@
136708136708
1
136709136709
1
136710136710
0 sunrise
136711-
0 (sunrise+01:00)-(sunset00:30)
136712-
0 (sunrise+01:45)-(sunset00:15)
136713-
0 (sunrise+02:00)-(sunset00:30)
136711+
0 (sunrise+01:00)-(sunset-00:30)
136712+
0 (sunrise+01:45)-(sunset-00:15)
136713+
0 (sunrise+02:00)-(sunset-00:30)
136714136714
0 sunrise-12:00
136715136715
0 sunrise-16:00
136716136716
0 sunrise-16:00
@@ -136743,7 +136743,7 @@
136743136743
0 sunset
136744136744
0 sunset-24:00
136745136745
0 sunset-sunrise
136746-
0 sunset-(sunrise-7:00)
136746+
0 sunset-(sunrise-07:00)
136747136747
0 sunset-sunrise open
136748136748
0 Su-Su 11:00-24:00
136749136749
0 Su-Th 08:00-24:00; Fr-Sa 08:00-01:00

test-data/oh.txt-result-strict

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99156,7 +99156,7 @@
9915699156
0 Mo-Su 09:30-23:30
9915799157
0 Mo-Su 09:30-24:00
9915899158
0 Mo-Su 09:30+; Fr,Sa 09:00+
99159-
0 Mo-Su 09:30-(sunset-1:00); Nov-Feb off
99159+
0 Mo-Su 09:30-(sunset-01:00); Nov-Feb off
9916099160
1
9916199161
1
9916299162
0 Mo-Su 09:45-12:25,12:55-17:50
@@ -102824,7 +102824,7 @@
102824102824
1
102825102825
1
102826102826
1
102827-
0 Mo-Su (sunrise00:30)-(sunset+00:30)
102827+
0 Mo-Su (sunrise-00:30)-(sunset+00:30)
102828102828
0 Mo-Su (sunrise+01:00)-(sunset+01:00)
102829102829
0 Mo-Su sunrise-22:00
102830102830
0 Mo-Su sunrise-23:00
@@ -136708,9 +136708,9 @@
136708136708
1
136709136709
1
136710136710
0 sunrise
136711-
0 (sunrise+01:00)-(sunset00:30)
136712-
0 (sunrise+01:45)-(sunset00:15)
136713-
0 (sunrise+02:00)-(sunset00:30)
136711+
0 (sunrise+01:00)-(sunset-00:30)
136712+
0 (sunrise+01:45)-(sunset-00:15)
136713+
0 (sunrise+02:00)-(sunset-00:30)
136714136714
0 sunrise-12:00
136715136715
0 sunrise-16:00
136716136716
0 sunrise-16:00
@@ -136743,7 +136743,7 @@
136743136743
0 sunset
136744136744
0 sunset-24:00
136745136745
0 sunset-sunrise
136746-
0 sunset-(sunrise-7:00)
136746+
0 sunset-(sunrise-07:00)
136747136747
0 sunset-sunrise open
136748136748
1
136749136749
1

0 commit comments

Comments
 (0)