Merge pull request #136 from nikosavola/enable-more-ruff

Enable more ruff checks

Author: simbilod

.pre-commit-config.yaml

@@ -1,5 +1,6 @@
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
+
     rev: "9260cbc9c84c06022993bfbcc42fdbf0305c5b8e"
     hooks:
       - id: check-added-large-files

docs/gdsfactory_interface.py

@@ -65,7 +65,7 @@
 #     gmsh.initialize()
 #     gmsh.open("heater_uz.msh")
 #     gmsh.fltk.run()
-# except:  # noqa: E722
+# except:
 #     print("Skipping CAD GUI visualization - only available when running locally")
 # ```
 
@@ -93,7 +93,7 @@
 #     gmsh.initialize()
 #     gmsh.open("heater_3D.msh")
 #     gmsh.fltk.run()
-# except:  # noqa: E722
+# except:
 #     print("Skipping CAD GUI visualization - only available when running locally")
 # ```
 # %%

docs/importing_gds.py

@@ -7,17 +7,17 @@
 # First, assume we have a GDS file (here we write a small one with gdstk):
 
 # %%
-from typing import List
+
 import gdstk
-from meshwell.import_gds import read_gds_layers
+import matplotlib.pyplot as plt
 import shapely
 import shapely.geometry as sg
-from meshwell.visualization import colors
-from meshwell.polysurface import PolySurface
-import matplotlib.pyplot as plt
-from meshwell.visualization import plot2D
+
 from meshwell.cad import cad
+from meshwell.import_gds import read_gds_layers
 from meshwell.mesh import mesh
+from meshwell.polysurface import PolySurface
+from meshwell.visualization import colors, plot2D
 
 lib = gdstk.Library()
 cell = lib.new_cell("TOP")
@@ -50,7 +50,7 @@
 # Add all shapes to cell
 shapes = [rect1a, poly1b, poly1c, rect2a, poly2b, poly2c, circle1, circle2, circle3]
 for shape in shapes:
-    if isinstance(shape, List):
+    if isinstance(shape, list):
         for subshape in shape:
             cell.add(subshape)
     else:
@@ -64,10 +64,7 @@
 ymax = float("-inf")
 
 for shape in shapes:
-    if isinstance(shape, List):
-        shape_list = shape
-    else:
-        shape_list = [shape]
+    shape_list = shape if isinstance(shape, list) else [shape]
 
     for s in shape_list:
         bbox = s.bounding_box()
@@ -236,7 +233,7 @@
 # %%
 # Helper function to plot shapely geometries
 def plot_geometry(geometry, title=None, color="blue", alpha=0.5, show_layer4=True):
-    fig, ax = plt.subplots(figsize=(8, 8))
+    _fig, ax = plt.subplots(figsize=(8, 8))
 
     # Plot the main geometry
     if isinstance(geometry, sg.MultiPolygon):

docs/intro_gmsh.py

@@ -5,6 +5,7 @@
 # %%
 import gmsh
 import meshio
+
 from meshwell.visualization import plot2D
 
 # %% [markdown]

docs/models.py

@@ -3,14 +3,16 @@
 # Multiple GMSH entities (and polysurfaces or prisms) can be provided to a model to create a single mesh.
 
 # %%
-import shapely
-import gmsh
 from functools import partial
-from meshwell.polysurface import PolySurface
-from meshwell.gmsh_entity import GMSH_entity
-from meshwell.visualization import plot2D
+
+import gmsh
+import shapely
+
 from meshwell.cad import cad
+from meshwell.gmsh_entity import GMSH_entity
 from meshwell.mesh import mesh
+from meshwell.polysurface import PolySurface
+from meshwell.visualization import plot2D
 
 # %%
 polygon_hull = shapely.Polygon(

docs/polysurfaces.py

@@ -6,9 +6,9 @@
 import matplotlib.pyplot as plt
 import shapely
 
-from meshwell.polysurface import PolySurface
 from meshwell.cad import cad
 from meshwell.mesh import mesh
+from meshwell.polysurface import PolySurface
 from meshwell.visualization import plot2D
 
 # %%

docs/prisms.py

@@ -3,12 +3,13 @@
 # Polygons can be associated with arbitrarily complex extrusion rules to form 3D Prisms.
 
 # %%
-import shapely
 import matplotlib.pyplot as plt
-from meshwell.polyprism import PolyPrism
 import plotly.graph_objects as go
+import shapely
+
 from meshwell.cad import cad
 from meshwell.mesh import mesh
+from meshwell.polyprism import PolyPrism
 
 # %%
 # We use shapely as an API to enter polygons

docs/resolution_advanced.py

@@ -4,11 +4,12 @@
 
 # %%
 import shapely
-from meshwell.polysurface import PolySurface
-from meshwell.visualization import plot2D
-from meshwell.resolution import ConstantInField, ThresholdField
+
 from meshwell.cad import cad
 from meshwell.mesh import mesh
+from meshwell.polysurface import PolySurface
+from meshwell.resolution import ConstantInField, ThresholdField
+from meshwell.visualization import plot2D
 
 # %% [markdown]
 # ## Filtering by mass

docs/resolution_basic.py

@@ -3,13 +3,15 @@
 # When defining entities, ResolutionSpecs can be attached to control the mesh size within or near the entity and its boundaries.
 
 # %%
-import shapely
 from collections import OrderedDict
-from meshwell.polysurface import PolySurface
-from meshwell.visualization import plot2D
-from meshwell.resolution import ConstantInField, ThresholdField, ExponentialField
+
+import shapely
+
 from meshwell.cad import cad
 from meshwell.mesh import mesh
+from meshwell.polysurface import PolySurface
+from meshwell.resolution import ConstantInField, ExponentialField, ThresholdField
+from meshwell.visualization import plot2D
 
 # %% [markdown]
 # ## Default characteristic length

meshwell/__init__.py

@@ -1,4 +1,4 @@
-"""meshwell - GMSH wrapper, with integrated photonics focus"""
+"""meshwell - GMSH wrapper, with integrated photonics focus."""
 
 __version__ = "0.0.1"
 __author__ = "Simon Bilodeau <sb30@princeton.edu>"