Order_StatusEmail.ss can't be overridden by user's custom template and $FromEmail results in template php error

[elkebe]

Try changing an order status to 'sent' or 'processed' and you get a template php error due to the $FromEmail in silvershop/core/templates/SilverShop/Model/Order_StatusEmail.ss

This results in no email being sent for order status change.

Also, it seems to be impossible to override this template with a custom user template in eg. /themes/my-theme/templates/SilverShop/Model/Order_StatusEmail.ss
Note that other email templates Order_AdminNotificationEmail.ss, Order_ConfirmationEmail.ss and Order_ReceiptEmail.ss can be overridden without issue.

Suggested fix: replace $FromEmail with $CurrentMember.FirstName

Note: this also appears to be in the SS5 branch.

[AntonyThorpe]

To set the $FromEmail try:

SilverStripe\Control\Email\Email:
  admin_email: yourname@example.net

[elkebe]

@AntonyThorpe Thanks. I already have the following .yml config which doesn’t seem to make any difference to the $FromEmail error:

---
Name: myemailconfig
After:
  - '#emailconfig'
---
SilverStripe\Control\Email\Email:
  admin_email:
    email@example.com: ‘Example email'