Skip to content

Faraday::TimeoutError not mapped into any ClickHouse error #44

@madejejej

Description

@madejejej

Currently, the library can raise a Faraday::TimeoutError.

In the RaiseError middleware we catch Faraday::ConnectionFailed and remap it to ClickHouse::NetworkException:

rescue Faraday::ConnectionFailed => e

However, TimeoutError isn't a descendant of ConnectionFailed:

https://github.com/lostisland/faraday/blob/ea30bd0b543882f1cf26e75ac4e46e0705fa7e68/lib/faraday/error.rb#L132

I suggest we also catch Faraday::TimeoutError (and perhaps a few more Faraday errors?) and remap it to ClickHouse errors

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions