ForbidCheckedExceptionInYieldingMethodRule: ignore implicit throw points (#114)

Author: JanTvrdik

src/Rule/ForbidCheckedExceptionInYieldingMethodRule.php

@@ -44,6 +44,10 @@ public function processNode(
         $errors = [];
 
         foreach ($node->getStatementResult()->getThrowPoints() as $throwPoint) {
+            if (!$throwPoint->isExplicit()) {
+                continue;
+            }
+
             foreach ($throwPoint->getType()->getObjectClassNames() as $exceptionClass) {
                 if ($this->exceptionTypeResolver->isCheckedException($exceptionClass, $throwPoint->getScope())) {
                     $errors[] = RuleErrorBuilder::message("Throwing checked exception $exceptionClass in yielding method is denied as it gets thrown upon Generator iteration")

tests/Rule/ForbidCheckedExceptionInYieldingMethodRuleTest.php

@@ -2,9 +2,11 @@
 
 namespace ShipMonk\PHPStan\Rule;
 
+use ForbidCheckedExceptionInYieldingMethodRule\CheckedException;
 use PHPStan\Rules\Exceptions\DefaultExceptionTypeResolver;
 use PHPStan\Rules\Rule;
 use ShipMonk\PHPStan\RuleTestCase;
+use Throwable;
 
 /**
  * @extends RuleTestCase<ForbidCheckedExceptionInYieldingMethodRule>
@@ -19,7 +21,7 @@ protected function getRule(): Rule
             ->expects(self::any())
             ->method('isCheckedException')
             ->willReturnCallback(static function (string $className): bool {
-                return $className === 'ForbidCheckedExceptionInYieldingMethodRule\CheckedException';
+                return $className === CheckedException::class || $className === Throwable::class;
             });
 
         return new ForbidCheckedExceptionInYieldingMethodRule($exceptionTypeResolverMock);