Fix UselessPrivatePropertyNullabilityRule false-positive for promoted properties (#55)

Author: enumag

src/Rule/UselessPrivatePropertyNullabilityRule.php

@@ -74,7 +74,7 @@ public function processNode(Node $node, Scope $scope): array
         $errors = [];
 
         foreach ($node->getProperties() as $property) {
-            $shouldBeChecked = $property->isPrivate() || $property->isReadOnly();
+            $shouldBeChecked = ($property->isPrivate() || $property->isReadOnly()) && !$property->isPromoted();
 
             if (!$shouldBeChecked) {
                 continue;

tests/Rule/data/UselessPrivatePropertyNullabilityRule/code.php

@@ -26,7 +26,8 @@ public function __construct(
         int $isPrivate,
         int $isPrivateWithConditionalAssignment,
         int $isPrivateWithDefaultNull,
-        int $isPrivateWithDefaultNotNull
+        int $isPrivateWithDefaultNotNull,
+        private ?int $isPrivatePromoted
     ) {
         $this->isPublic = $isPublic;
         $this->isProtected = $isProtected;