Fix false positive with interface parent (#221)

Author: janedbal

src/Rule/DeadCodeRule.php

@@ -465,9 +465,7 @@ private function findDefinerMemberKey(
         }
 
         if ($includeParentLookup) {
-            $parentNames = $memberType === MemberType::CONSTANT
-                ? $this->getAncestorNames($className) // constants can be declared in interfaces
-                : $this->getParentNames($className);
+            $parentNames = $this->getAncestorNames($className);
 
             // search for definition in parents (and its traits)
             foreach ($parentNames as $parentName) {
@@ -522,9 +520,7 @@ private function getPossibleDefinerMemberKeys(
         }
 
         if ($includeParentLookup) {
-            $parentNames = $memberType === MemberType::CONSTANT
-                ? $this->getAncestorNames($className) // constants can be declared in interfaces
-                : $this->getParentNames($className);
+            $parentNames = $this->getAncestorNames($className);
 
             // search for definition in parents (and its traits)
             foreach ($parentNames as $parentName) {
@@ -740,14 +736,6 @@ private function buildError(array $blackMembersGroup): IdentifierRuleError
         return $builder->build();
     }
 
-    /**
-     * @return list<string>
-     */
-    private function getParentNames(string $typeName): array
-    {
-        return array_keys($this->typeDefinitions[$typeName]['parents'] ?? []);
-    }
-
     /**
      * @return list<string>
      */

tests/Rule/DeadCodeRuleTest.php

@@ -713,6 +713,7 @@ public static function provideFiles(): Traversable
         yield 'method-indirect-interface-6' => [__DIR__ . '/data/methods/indirect-interface-6.php'];
         yield 'method-indirect-interface-7' => [__DIR__ . '/data/methods/indirect-interface-7.php'];
         yield 'method-indirect-interface-8' => [__DIR__ . '/data/methods/indirect-interface-8.php'];
+        yield 'method-indirect-interface-9' => [__DIR__ . '/data/methods/indirect-interface-9.php'];
         yield 'method-parent-call-1' => [__DIR__ . '/data/methods/parent-call-1.php'];
         yield 'method-parent-call-2' => [__DIR__ . '/data/methods/parent-call-2.php'];
         yield 'method-parent-call-3' => [__DIR__ . '/data/methods/parent-call-3.php'];
@@ -777,6 +778,7 @@ public static function provideFiles(): Traversable
         yield 'mixed-member-indirect-6' => [__DIR__ . '/data/mixed-member/indirect-interface-6.php'];
         yield 'mixed-member-indirect-7' => [__DIR__ . '/data/mixed-member/indirect-interface-7.php'];
         yield 'mixed-member-indirect-8' => [__DIR__ . '/data/mixed-member/indirect-interface-8.php'];
+        yield 'mixed-member-indirect-9' => [__DIR__ . '/data/mixed-member/indirect-interface-9.php'];
         yield 'mixed-member-overwriting-1' => [__DIR__ . '/data/mixed-member/overwriting-methods-1.php'];
         yield 'mixed-member-overwriting-2' => [__DIR__ . '/data/mixed-member/overwriting-methods-2.php'];
         yield 'mixed-member-overwriting-3' => [__DIR__ . '/data/mixed-member/overwriting-methods-3.php'];

tests/Rule/data/methods/indirect-interface-9.php

@@ -0,0 +1,27 @@
+<?php declare(strict_types = 1);
+
+namespace DeadIndirect9;
+
+interface Root
+{
+    public function getFoo(): string;
+}
+
+interface Intermediate extends Root
+{
+
+}
+
+class Baz implements Intermediate
+{
+    public function getFoo(): string
+    {
+        return 'Foo';
+    }
+
+}
+
+function foobar(Intermediate $intermediate): void
+{
+    echo $intermediate->getFoo();
+}

tests/Rule/data/mixed-member/indirect-interface-9.php

@@ -0,0 +1,27 @@
+<?php declare(strict_types = 1);
+
+namespace MixedMemberIndirect9;
+
+interface Root
+{
+    public function getFoo(): string;
+}
+
+interface Intermediate extends Root
+{
+
+}
+
+class Baz implements Intermediate
+{
+    public function getFoo(): string
+    {
+        return 'Foo';
+    }
+
+}
+
+function foobar(Intermediate $intermediate, string $method): void
+{
+    echo $intermediate->$method();
+}