Fix symfony.configDir wiring + ensure no regression (#216)

Author: janedbal

rules.neon

@@ -48,6 +48,7 @@ services:
             - shipmonk.deadCode.memberUsageProvider
         arguments:
             enabled: %shipmonkDeadCode.usageProviders.symfony.enabled%
+            configDir: %shipmonkDeadCode.usageProviders.symfony.configDir%
 
     -
         class: ShipMonk\PHPStan\DeadCode\Provider\TwigUsageProvider

tests/AllServicesInConfigTest.php

@@ -83,15 +83,6 @@ public function test(): void
             if (self::getContainer()->findServiceNamesByType($className) === []) {
                 self::fail('Class ' . $className . ' not registered in rules.neon');
             }
-
-            $parameters = $reflectionClass->getConstructor() !== null ? $reflectionClass->getConstructor()->getParameters() : [];
-
-            foreach ($parameters as $parameter) {
-                if ($parameter->isDefaultValueAvailable()) {
-                    $why = 'This is not allowed to ensure we properly wire all (possibly configurable) parameters via DIC.';
-                    self::fail('Service ' . $className . ' uses default value for parameter ' . $parameter->getName() . '. ' . $why);
-                }
-            }
         }
     }
 

tests/ParamsArePassedToServicesTest.php

@@ -0,0 +1,65 @@
+<?php declare(strict_types = 1);
+
+namespace ShipMonk\PHPStan\DeadCode;
+
+use PHPStan\Testing\PHPStanTestCase;
+use function array_merge;
+use function file_get_contents;
+use function is_array;
+use function strpos;
+
+class ParamsArePassedToServicesTest extends PHPStanTestCase
+{
+
+    /**
+     * @return string[]
+     */
+    public static function getAdditionalConfigFiles(): array
+    {
+        return array_merge(
+            parent::getAdditionalConfigFiles(),
+            [__DIR__ . '/../rules.neon'],
+        );
+    }
+
+    public function test(): void
+    {
+        $parameters = self::getContainer()->getParameters();
+        self::assertArrayHasKey('shipmonkDeadCode', $parameters);
+        self::assertIsArray($parameters['shipmonkDeadCode']);
+
+        $paths = $this->getArrayPaths($parameters['shipmonkDeadCode'], 'shipmonkDeadCode');
+
+        $neonContents = file_get_contents(__DIR__ . '/../rules.neon');
+        self::assertNotFalse($neonContents);
+
+        foreach ($paths as $path) {
+            self::assertTrue(
+                strpos($neonContents, "%$path%") !== false,
+                'Usage of parameter %' . $path . '% not found in rules.neon. It should probably be passed to some service.',
+            );
+        }
+    }
+
+    /**
+     * @param array<mixed> $input
+     * @return list<string>
+     */
+    private function getArrayPaths(array $input, string $currentPath = ''): array
+    {
+        $resultPaths = [];
+
+        foreach ($input as $key => $value) {
+            $newPathSegment = $currentPath === '' ? (string) $key : $currentPath . '.' . $key;
+
+            if (is_array($value)) {
+                $resultPaths = array_merge($resultPaths, $this->getArrayPaths($value, $newPathSegment));
+            } else {
+                $resultPaths[] = $newPathSegment;
+            }
+        }
+
+        return $resultPaths;
+    }
+
+}