TestsExcluder not to exclude mixed usages in tests (#214)

Author: janedbal

src/Excluder/TestsUsageExcluder.php

@@ -68,14 +68,14 @@ public function shouldExclude(ClassMemberUsage $usage, Node $node, Scope $scope)
             return false;
         }
 
-        return $this->isWithinDevPaths($this->realpath($scope->getFile()))
-            && !$this->isWithinDevPaths($this->getDeclarationFile($usage->getMemberRef()->getClassName()));
+        return $this->isWithinDevPaths($this->realpath($scope->getFile())) === true
+            && $this->isWithinDevPaths($this->getDeclarationFile($usage->getMemberRef()->getClassName())) === false;
     }
 
-    private function isWithinDevPaths(?string $filePath): bool
+    private function isWithinDevPaths(?string $filePath): ?bool
     {
         if ($filePath === null) {
-            return false;
+            return null;
         }
 
         foreach ($this->devPaths as $devPath) {

tests/Rule/data/excluders/tests/src/code.php

@@ -2,6 +2,7 @@
 
 class DeclaredInSrcUsedInTests {
     const CONST = 1; // error: Unused DeclaredInSrcUsedInTests::CONST (all usages excluded by tests excluder)
+    const MIXED = 2;
 }
 
 class DeclaredInSrcUsedInBoth {

tests/Rule/data/excluders/tests/tests/code.php

@@ -12,9 +12,10 @@ class DeclaredInTestsUsedInSrc {
     const CONST = 1;
 }
 
-function test1() {
+function test1($mixed) {
     echo DeclaredInSrcUsedInBoth::CONST;
     echo DeclaredInSrcUsedInTests::CONST;
     echo DeclaredInTestsUsedInTests::CONST;
     echo DeclaredInTestsUsedInBoth::CONST;
+    $mixed::MIXED;
 }