Report dead method line at its name (#192)

Author: janedbal

src/Collector/ClassDefinitionCollector.php

@@ -76,7 +76,7 @@ public function processNode(
 
         foreach ($node->getMethods() as $method) {
             $methods[$method->name->toString()] = [
-                'line' => $method->getStartLine(),
+                'line' => $method->name->getStartLine(),
                 'params' => count($method->params),
                 'abstract' => $method->isAbstract() || $node instanceof Interface_,
                 'visibility' => $method->flags & (Visibility::PUBLIC | Visibility::PROTECTED | Visibility::PRIVATE),

tests/Rule/DeadCodeRuleTest.php

@@ -546,7 +546,7 @@ public static function provideGroupingFiles(): Traversable
             [
                 [
                     'Unused AttributeGrouping\Foo::endpoint',
-                    9,
+                    10,
                 ],
             ],
         ];
@@ -761,6 +761,9 @@ public static function provideFiles(): Traversable
         yield 'mixed-member-const-traits-10' => [__DIR__ . '/data/mixed-member/traits-const-10.php'];
         yield 'mixed-member-const-traits-14' => [__DIR__ . '/data/mixed-member/traits-const-14.php'];
         yield 'mixed-member-const-traits-21' => [__DIR__ . '/data/mixed-member/traits-const-21.php'];
+
+        // other
+        yield 'report-lines' => [__DIR__ . '/data/other/report-lines.php'];
     }
 
     /**

tests/Rule/data/other/report-lines.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace ReportLines;
+
+class Foo
+{
+    public
+    const
+    BAR // error: Unused ReportLines\Foo::BAR
+    =
+    1
+    ;
+
+    #[
+        Bar
+    ]
+    public
+    function
+    endpoint // error: Unused ReportLines\Foo::endpoint
+    ()
+    :
+    void
+    {
+    }
+
+}

tests/Rule/data/providers/symfony.php

@@ -31,8 +31,8 @@ private function setDependency(): void
     {
     }
 
-    #[Unknown] // error: Unused Symfony\SomeController::dead
-    public function dead(): void
+    #[Unknown]
+    public function dead(): void // error: Unused Symfony\SomeController::dead
     {
     }