IntervalTrigger.Interval can't be used. Bug or intended behaviour?

[ChilloDE]

The AssertValid Method in Shiny.Notifications.IntervalTrigger does not allow the use of Interval at all. The last check always fails, when TimeOfDay is null, even when Interval is set.

public void AssertValid()
{
    if (this.Interval == null && this.TimeOfDay == null)
        throw new InvalidOperationException("You must set TimeOfDay or Interval");

    if (this.Interval != null && this.TimeOfDay != null)
        throw new InvalidOperationException("TimeOfDay and Interval cannot be set");

    if (this.TimeOfDay!.Value.TotalMinutes > (24 * 60))
        throw new InvalidOperationException("TimeOfDay must be within 24 hours");
}

I'm not sure if that's on purpose or not, but if it was, why even provide the Interval-Property at all.
I think the last check should be like this instread:

if (this.TimeOfDay.HasValue && this.TimeOfDay.Value.TotalMinutes > (24 * 60)
    throw new InvalidOperationException("TimeOfDay must be within 24 hours");

or if you prefer the ?-Syntax:

if ((this.TimeOfDay?.TotalMinutes ?? 0) > (24 * 60))
    throw new InvalidOperationException("TimeOfDay must be within 24 hours");

[aritchie]

Can you share how you are calling the notification so I have something to test against?

[ChilloDE]

Hi, thank you for your reply!

I don't think my Code is relevant here, just doing new IntervalTrigger() { Interval = TimeSpan.FromSeconds(30) }.AssertValid() will give you the error.
Anyway what I am trying to do is: Send the notification in my Implementation of the IPushDelegate in the OnReceived Method when receiving a Data-Message from FCM.

Simplified i'm just doing the following:

await _notificationManager.Send(
    new Shiny.Notifications.Notification()
    {
        RepeatInterval = new IntervalTrigger() { Interval = TimeSpan.FromSeconds(30) },
        Channel = "Channel Id",
        Message = "Some Text",
        Thread = "Thread Name",
        Id = 1337,
    });

Getting the following Error:
System.InvalidOperationException: Nullable object must have a value.
at System.Nullable`1[[System.TimeSpan, System.Private.CoreLib, Version=8.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].get_Value()
at Shiny.Notifications.IntervalTrigger.AssertValid()
at Shiny.Notifications.NotificationExtensions.AssertValid(Notification notification)
at Shiny.Notifications.NotificationManager.Send(Notification notification)
at M3Alarm.AppClient.Delegates.PushMessageDelegate.OnReceived(PushNotification notification)
[...]

I hope this helps, thank you again.

It's getting late here and I should be off work for hours, if you need it I can try to create a minimal example tomorrow.

[ChilloDE]

Here's a minimal project to recreate the Problem:
https://github.com/ChilloDE/ShinyIntervalTest

[ChilloDE]

This is kinda related but also a separate Issue.
I was digging though the Shiny Codebase some more, because I was wondering, why I also get Shiny.AccessState.Restricted as a result to INotificationManager.RequestAccess(AccessRequestFlags) with AccessRequestFlags.TimeSensitivity.

I realized while the System UI for normal Notifications-Permission is being displayed as expected, the UI requestet by the following line from the Shiny.Notifications/Platforms/Android/NotificationManager.cs is never shown to me:
this.platform.CurrentActivity!.StartActivity(new Intent("android.settings.REQUEST_SCHEDULE_EXACT_ALARM"));

While reading though the Andoid Documentation I did realize that I was missing the SCHEDULE_EXACT_ALARM permission in my AndroidManifest.xml, though adding that didn't change the result/behaviour of the RequestAccess-Method.

I tried uninstalling the app to reset permissions, but I'm still only getting the UI for regular notifications and Shiny.AccessState.Restricted as a result. Even if I go into the System-Settings an giving the Permission for "Alarms & reminders" manually, I still get Shiny.AccessState.Restricted
Am I missing something here?

I'm currently targeting android34 and deploying to / testing on a Pixel 7a (Android 15 - API 35)
This is also reproduced by the minimal example I've provided earlier.

[aritchie]

Please make sure you're filing in issues especially if you have crashes. The forums are meant for questions and issues will get lost in here.

There is already an existing bug around precision timers here: #1406