liwebrtc のバージョンを m142.7444.2.0 に上げる #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
!sonnet レビューをお願い |
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
!sonnet リリースするまで libwebrtc への追従は一つの変更履歴項目とするので変更する予定はありません。 |
|
Claude finished @miosakuma's task —— View job 了解しましたリリースまでは libwebrtc への追従を一つの変更履歴項目としてまとめる方針とのこと、承知しました。 CHANGES.md の記載方法についての指摘は取り下げます。リリース時の運用方針に従った記載であることを確認しました。 |
melpon
reviewed
Nov 4, 2025
src/android/android_capturer.cpp
Outdated
Comment on lines
63
to
65
| webrtc::ScopedJavaLocalRef<jclass> camcls = | ||
| webrtc::ScopedJavaLocalRef<jclass>::Adopt( | ||
| env, env->GetObjectClass(camera2enumerator.obj())); |
Contributor
There was a problem hiding this comment.
webrtc::ScopedJavaLocalRef<jclass> が何度も発生してて冗長なので Adopt() 使ってる場所の変数の宣言は全部 auto にして下さい。
auto camcls =
webrtc::ScopedJavaLocalRef<jclass>::Adopt(
env, env->GetObjectClass(camera2enumerator.obj()));
Contributor
Author
|
確認ありがとうございました、マージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libwebrtc m142 の変更へ追従し以下の対応を行っています。
PeerConnectionFactoryのコンストラクタにenvの引数を追加ScopedJavaLocalRef<jobject>(env, obj)からScopedJavaLocalRef<jobject>::Adopt(env, obj)を使うように変更