Skip to content

Commit f11a890

Browse files
fix(typings): resolve typing issues
1 parent 94538ab commit f11a890

File tree

9 files changed

+10
-11
lines changed

9 files changed

+10
-11
lines changed

src/dynamo/request/base.request.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ModelConstructor } from '../../model/model-constructor'
44
import { BaseRequest } from './base.request'
55

66
describe('base request', () => {
7-
class TestRequest<T> extends BaseRequest<T, any, BaseRequest<T, any, any>> {
7+
class TestRequest<T> extends BaseRequest<T, T, any, BaseRequest<T, T, any, any>> {
88
constructor(modelClazz: ModelConstructor<T>) {
99
super(<any>null, modelClazz)
1010
}

src/dynamo/request/delete/delete.request.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { WriteRequest } from '../write.request'
1111
/**
1212
* Request class for the DeleteItem operation.
1313
*/
14-
export class DeleteRequest<T, T2 = T> extends WriteRequest<
14+
export class DeleteRequest<T, T2 = void> extends WriteRequest<
1515
T,
1616
T2,
1717
DynamoDB.DeleteItemInput,

src/dynamo/request/query/query.request.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class QueryRequest<T, T2 = T> extends ReadManyRequest<
1919
DynamoDB.QueryInput,
2020
DynamoDB.QueryOutput,
2121
QueryResponse<T2>,
22-
QueryRequest<T2>
22+
QueryRequest<T, T2>
2323
> {
2424
protected readonly logger: Logger
2525

src/dynamo/request/read-many.request.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import { or } from '../expression/logical-operator/public.api'
1414
import { getTableName } from '../get-table-name.function'
1515
import { ReadManyRequest } from './read-many.request'
1616

17-
class TestRequest<T> extends ReadManyRequest<T, any, any, any, any> {
17+
class TestRequest<T> extends ReadManyRequest<T, T, any, any, any, any> {
1818
constructor(modelClazz: ModelConstructor<T>) {
1919
super(<any>null, modelClazz)
2020
this.logger = createLogger('TestRequest', modelClazz)

src/dynamo/request/read-many.request.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export abstract class ReadManyRequest<
3434
I extends DynamoDB.QueryInput | DynamoDB.ScanInput,
3535
O extends DynamoDB.QueryOutput | DynamoDB.ScanOutput,
3636
Z extends QueryResponse<T2> | ScanResponse<T2>,
37-
R extends QueryRequest<T2> | ScanRequest<T2>
37+
R extends QueryRequest<T, T2> | ScanRequest<T, T2>
3838
> extends StandardRequest<T, T2, I, ReadManyRequest<T, T2, I, O, Z, R>> {
3939
/** Infinite limit will remove the Limit param from request params when calling ReadManyRequest.limit(ReadManyRequest.INFINITE_LIMIT) */
4040
static INFINITE_LIMIT = -1
@@ -112,7 +112,6 @@ export abstract class ReadManyRequest<
112112
* Specifies the list of model attributes to be returned from the table instead of returning the entire document
113113
* @param attributesToGet List of model attributes to be returned
114114
*/
115-
// @ts-ignore: type R does not satisfy the constraint, don't know how to resolve
116115
projectionExpression(...attributesToGet: Array<keyof T | string>): ReadManyRequest<T, Partial<T>, I, O, Z, R> {
117116
addProjectionExpressionParam(attributesToGet, this.params, this.metadata)
118117
return <any>this
@@ -213,7 +212,7 @@ export abstract class ReadManyRequest<
213212
* fetches all pages. may uses all provisionedOutput, therefore for client side use cases rather use pagedDatasource (exec)
214213
*/
215214
execFetchAll(): Promise<T2[]> {
216-
return fetchAll(<R>(<any>this))
215+
return fetchAll(<any>this)
217216
}
218217

219218
protected mapFromDb = (output: O) => {

src/dynamo/request/scan/scan.request.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class ScanRequest<T, T2 = T> extends ReadManyRequest<
1717
DynamoDB.ScanInput,
1818
DynamoDB.ScanOutput,
1919
ScanResponse<T2>,
20-
ScanRequest<T2>
20+
ScanRequest<T, T2>
2121
> {
2222
protected readonly logger: Logger
2323

src/dynamo/request/standard.request.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { getTableName } from '../get-table-name.function'
44
import { StandardRequest } from './standard.request'
55

66
describe('StandardRequest', () => {
7-
class MyStandardRequest<T> extends StandardRequest<T, any, MyStandardRequest<T>> {
7+
class MyStandardRequest<T> extends StandardRequest<T, T, any, MyStandardRequest<T>> {
88
constructor(c: ModelConstructor<T>) {
99
super(<any>null, c)
1010
}

src/dynamo/request/update/update.request.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { WriteRequest } from '../write.request'
1515
/**
1616
* Request class for the UpdateItem operation.
1717
*/
18-
export class UpdateRequest<T, T2 = T> extends WriteRequest<
18+
export class UpdateRequest<T, T2 = void> extends WriteRequest<
1919
T,
2020
T2,
2121
DynamoDB.UpdateItemInput,

src/dynamo/request/write.request.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { or } from '../expression/logical-operator/public.api'
77
import { WriteRequest } from './write.request'
88

99
describe('write request', () => {
10-
class TestWriteRequest<T> extends WriteRequest<T, any, any, TestWriteRequest<T>> {
10+
class TestWriteRequest<T> extends WriteRequest<T, T, any, any, TestWriteRequest<T>> {
1111
protected readonly logger: Logger
1212
readonly params: any = {}
1313

0 commit comments

Comments
 (0)