Skip to content

Commit 2ec7c3f

Browse files
author
Michael Wittwer
committed
test(gh-action): add node16 in test matrix
1 parent e2bcb11 commit 2ec7c3f

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ jobs:
1717
test:
1818
strategy:
1919
matrix:
20-
# Test with Node.js v18 (LTS) and v19 current
20+
# Test with Node.js v16 (maintenance), v18 (LTS) and v19 current
2121
node:
22+
- 16
2223
- 18
2324
- 19
2425
name: Node.js v${{ matrix.node }}
@@ -50,6 +51,7 @@ jobs:
5051
# Run tests
5152
- run: npm run test:ci
5253
build:
54+
needs: test
5355
runs-on: ubuntu-latest
5456
steps:
5557
- uses: actions/checkout@v3

v2-v3-migration.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111

1212
## Todo
1313
Search for `TODO v3:` to see open issues / notes, here are some more general ones:
14-
- [ ] Make sure the snippets compile
14+
- [x] Make sure the snippets compile
1515
- [ ] Check on new attribute type [$UnknownAttribute](./src/mapper/type/attribute.type.ts) and implement tests
16-
- [ ] Add new demo with aws-cdk
17-
- [ ] Make tests compile and run successfully
16+
- [ ] Add new [demo](https://github.com/shiftcode/dynamo-easy-demo) with aws-cdk
17+
- [x] Make tests compile and run successfully
1818
- [ ] Remove [sessionValidityEnsurer](./src/config/dynamo-easy-config.ts) and add demo with using [middleware stack](https://github.com/aws/aws-sdk-js-v3#middleware-stack)
1919
to implement the same
2020
- [ ] Switch to new implementation of pagination, see [official doc](https://github.com/aws/aws-sdk-js-v3#paginators).

0 commit comments

Comments
 (0)