v50 Waiting List editing does not save species and breed

[inghamn]

Using the v50 release, when editing a waiting list entry (https://hostname/asm/waitinglist?id=3988 ), changes to the species and breed are lost. After clicking "save" the screen reloads with no selection chosen for species or breed. The [Add to Waiting List] works as expected.

There is no error showing up in the error log. It's as if the form field is not being handled. The animalwaitinglist table gets updated with the speciesid of the first entry in the species dropdown; however, the breedid field does end up having the actual chosen breed.

To Reproduce

1. Go to an existing waiting list entry
2. Make a change to the species or breed
3. Click save

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 24.04
• Browser Firefox

[inghamn]

When clicking "save" the POST request ends up containing two species values, instead of one. The first element is the one that was chosen. The second element is always the first option in the select element.

[bobintetley]

I think you must have an additional field of type animal on your waiting list records. The embedded add screen of the widget is being included in the post, which is causing this issue. Thanks for raising it!

It's fixed by this commit 9de208c

[inghamn]

Thanks so much, the change to waitinglist.js results in the edit form work as expected.

Is the additional animal field something we should remove? I do not believe any of the records are populate that field with data. Is it something we should change in our configuration?

[bobintetley]

It's up to you - the fact that it caused problems here was definitely a bug and there shouldn't be any reason why you can't use animal additional fields on waiting list records.

On the other hand, if you have added this field and aren't actually using it, then it would make sense to remove it since there is a very small performance cost to additional fields.