Using AWS SDK With Go for EC2 AMI Metrics - sheldonhull.com

[utterances-bot]

Using AWS SDK With Go for EC2 AMI Metrics - sheldonhull.com

https://www.sheldonhull.com/blog/using-aws-sdk-with-go-for-ec2-ami-metrics/

[mrxinu]

Instead of going horizontal like this:

log.Info().Int("result_count", len(respInstances.Reservations)).Dur("duration", time.Since(start)).Msg("\tresults returned for ec2instances")

It would read better on separate lines:

log.Info().
    Int("result_count", len(respInstances.Reservations)).
    Dur("duration", time.Since(start)).
    Msg("\tresults returned for ec2instances")

As long as you end with periods the parser won't choke on it.

[sheldonhull]

Good feedback. I agree, much easier to read.

[sheldonhull]

@mrxinu I'm designing so that it would use structured output in the first place. However, is there any more elegant way to handle the nesting of the log messages for output other than embedded tabs \t for the level of logging that is standard for easier console review?

Normally I'd just output to text and be done, but I did that to make the debugging a little easier.
I'm guessing it's just better to remove that to keep things cleaner.

https://github.com/sheldonhull/go-aws-ami-metrics/blob/103dd05418a8ed12b9ed8a378738a63a054667e6/v1/main.go#L204-L211

[mrxinu]

I wouldn't conflate logging with debugging output. I would strip the logging of any formatting, maybe even go with JSON output for easy consumption later, and then have a separate file handle to stdout and/or a log. I'd check out the io.MultiWriter interface and the lumberjack package.

https://golang.org/pkg/io/#MultiWriter
https://github.com/natefinch/lumberjack