Fixed crash when weather forecast is not available

Fixed Date display format

Author: sharky76

services/DateTime/DateTime.c

@@ -4,13 +4,16 @@
 #include <string.h>
 #include <stdio.h>
 #include "datetime_cli.h"
+#include "logger.h"
 
 variant_t*  datetime_get_time_string(service_method_t* method, va_list args);
 variant_t*  datetime_get_timestamp(service_method_t* method, va_list args);
 variant_t*  datetime_time_less_than(service_method_t* method, va_list args);
 variant_t*  datetime_time_greater_than(service_method_t* method, va_list args);
 variant_t*  datetime_get_date_string(service_method_t* method, va_list args);
 
+int DT_DATETIME;
+
 void    service_create(service_t** service, int service_id)
 {
     SERVICE_INIT(DateTime, "Provides date/time display")
@@ -22,7 +25,7 @@ void    service_create(service_t** service, int service_id)
 
 
     (*service)->get_config_callback = datetime_cli_get_config;
-
+    DT_DATETIME = service_id;
     datetime_time_format = strdup("%H:%M");
     datetime_date_format = strdup("%m/%d/%Y");
 }
@@ -103,9 +106,11 @@ variant_t*  datetime_get_date_string(service_method_t* method, va_list args)
     time_t t = time(NULL);
     struct tm* p_tm = localtime(&t);
 
-    char* datebuf = (char*)calloc(11, sizeof(char));
+    char* datebuf = (char*)calloc(15, sizeof(char));
+
+    strftime(datebuf, 14, datetime_date_format, p_tm);
 
-    strftime(datebuf, 10, datetime_date_format, p_tm);
+    LOG_DEBUG(DT_DATETIME, "Date %s with format %s", datebuf, datetime_date_format);
 
     return variant_create_string(datebuf);
 }

services/IFTTT/IFTTT.c

@@ -104,7 +104,7 @@ variant_t* ifttt_trigger_event(service_method_t* method, va_list args)
         /* check for errors */ 
         if(res != CURLE_OK) 
         {
-            LOG_ERROR(DT_IFTTT, "curl_easy_perform() failed: %s", curl_easy_strerror(res));
+            LOG_ERROR(DT_IFTTT, "Event trigger failed: %s", curl_easy_strerror(res));
         }
         else 
         {

services/Weather/weather_cache.c

@@ -175,9 +175,17 @@ void    weather_cache_parse_forecast(struct json_object* weather_response_obj)
     stack_empty(weather_cache.forecast_hourly);
 
     free(weather_cache.raw_forecast);
+    weather_cache.raw_forecast = NULL;
 
     json_object* entries_array;
     json_object_object_get_ex(weather_response_obj, "list", &entries_array);
+
+    if(NULL == entries_array)
+    {
+        LOG_ERROR(DT_WEATHER, "Forecast is empty");
+        return;
+    }
+
     int weather_entries = json_object_array_length(entries_array);
 
     for(int i = 0; i < weather_entries; i++)