Skip to content

Trade quotes should arrive in one go #9984

@linear

Description

@linear

Description

Currently, work is being done in #9927 (SS-4653) to consolidate quote refresh spinners.

This should be considered a temporary hack, as the goal is to consolidate quotes to "arrive" (be populated, really) in one go, similar to if we were hitting a /quotes endpoint, which would return all quotes as a single response, and is how things are done conventionally in our competitors.

AC

  • Logic from feat: consolidate quote cards to use one refresh spinner #9951 should be reverted fully or partially, leveraging a simpler way to do the countdown thing (wink wink CoW)
  • Create a single RTK API (or similar) endpoint that will fetch quotes for all applicable swappers.
  • Logic should inherently be the same as currently for all swappers, this is mostly an architectural changes around swappers to unify them
  • Endpoint should have a sane timeout to avoid the case of Portals being very slow and taking up to 8s (to-be-confirmed what that timeout is when we groom this, recommending 5s as a starting point)
  • The quotes/rates logic we have should still be working - be very cognizant of testing the odd ones bits too i.e ZRX, approval required, and that final quote fetch still works, under the same heuristics as currently

Designs & Product

Below includes new design for swapper loader 👇

PROD-18

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions