-
Notifications
You must be signed in to change notification settings - Fork 6
Description
When attempting to connect from a website using Chrome or Firefox on Android, intending to use the new WalletConnect dApps linking feature, ShapeShift does not show up in the list of potential apps that could be used to open the WalletConnect deeplink.
This makes the WalletConnect dApp feature harder to use as you need to copy/paste the non-default option through the QR code. I'm not sure if many users will find it either as it requires for the user to open the NavBar which is collapsed to click on "Connect dApp".
The fix should be to add an intent-filter
entry to support the wc:
deeplink scheme as described in the WalletConnect documentation in AndroidManifest.xml
. We could maybe handle this in the PR #85 that intends to already add shapeshift://
deeplink support.
EDIT: It does imply more changes than just the intent-filter
, the links need to be handled to trigger a WalletConnect connection or other operations in the app and/or the mobile-app as far as I could test.
Screenshot of the missing "ShapeShift" option while trying to link an app using WalletConnect: